Skip to contentSkip to conversation

x86: qemu: Remove dead code

PATCH New Andy Shevchenko 2 participants 2 messages Sep 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 x86: qemu: Remove dead code

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply replace the rule in it. We use stub C-file like it's done for other boards.

---
v3: fixed linker error (Bin)

 board/emulation/qemu-x86/Makefile   | 2 +-
 board/emulation/qemu-x86/qemu-x86.c | 0
 board/emulation/qemu-x86/start.S    | 8 --------
 3 files changed, 1 insertion(+), 9 deletions(-)
 create mode 100644 board/emulation/qemu-x86/qemu-x86.c
 delete mode 100644 board/emulation/qemu-x86/start.S
board/emulation/qemu-x86/Makefile +1 -1
index 782e298b74ce..ff4aaa51c540 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2015, Bin Meng <[email protected]>
 
-obj-y	+= start.o
+obj-y	+= qemu-x86.o
board/emulation/qemu-x86/qemu-x86.c new file +0 -0
new file mode 100644
index 000000000000..e69de29bb2d1
board/emulation/qemu-x86/start.S deleted +0 -8
deleted file mode 100644
index e4bde561b20d..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.28.0
#1 lore raw

PATCH v3 1/1 x86: qemu: Remove dead code

Quoted 8 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply replace the rule in it. We use stub C-file like it's done for other boards.

Quoted 9 lines

---
v3: fixed linker error (Bin)

 board/emulation/qemu-x86/Makefile   | 2 +-
 board/emulation/qemu-x86/qemu-x86.c | 0
 board/emulation/qemu-x86/start.S    | 8 --------
 3 files changed, 1 insertion(+), 9 deletions(-)
 create mode 100644 board/emulation/qemu-x86/qemu-x86.c
 delete mode 100644 board/emulation/qemu-x86/start.S

applied to u-boot-x86, thanks!