Skip to contentSkip to conversation

hw/acpi/tco: Remove unused definitions

PATCH Applied Philippe Mathieu-Daudé 2 participants 3 messages Sep 1, 2020 – Sep 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/acpi/tco: Remove unused definitions

TCO_DEBUG() and DEBUG definitions are not used, remove them.

---
 hw/acpi/tco.c | 11 -----------
 1 file changed, 11 deletions(-)
hw/acpi/tco.c +0 -11
index fb9052dbca2..cf1e68a5393 100644
@@ -15,17 +15,6 @@
 #include "hw/acpi/tco.h"
 #include "trace.h"
 
-//#define DEBUG
-
-#ifdef DEBUG
-#define TCO_DEBUG(fmt, ...)                                     \
-    do {                                                        \
-        fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__);    \
-    } while (0)
-#else
-#define TCO_DEBUG(fmt, ...) do { } while (0)
-#endif
-
 enum {
     TCO_RLD_DEFAULT         = 0x0000,
     TCO_DAT_IN_DEFAULT      = 0x00,
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw

Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :

Quoted 20 lines

TCO_DEBUG() and DEBUG definitions are not used, remove them.

---
 hw/acpi/tco.c | 11 -----------
 1 file changed, 11 deletions(-)
hw/acpi/tco.c +0 -4
index fb9052dbca2..cf1e68a5393 100644
@@ -15,17 +15,6 @@
 #include "hw/acpi/tco.h"
 #include "trace.h"
 
-//#define DEBUG
-
-#ifdef DEBUG
-#define TCO_DEBUG(fmt, ...)                                     \

hw/acpi/tco.c line 20

Quoted 10 lines
hw/acpi/tco.c +0 -7
-    do {                                                        \
-        fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__);    \
-    } while (0)
-#else
-#define TCO_DEBUG(fmt, ...) do { } while (0)
-#endif
-
 enum {
     TCO_RLD_DEFAULT         = 0x0000,
     TCO_DAT_IN_DEFAULT      = 0x00,
#2 lore raw
In reply to Philippe Mathieu-Daudé

Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :

Quoted 20 lines

TCO_DEBUG() and DEBUG definitions are not used, remove them.

---
 hw/acpi/tco.c | 11 -----------
 1 file changed, 11 deletions(-)
hw/acpi/tco.c +0 -4
index fb9052dbca2..cf1e68a5393 100644
@@ -15,17 +15,6 @@
 #include "hw/acpi/tco.h"
 #include "trace.h"
 
-//#define DEBUG
-
-#ifdef DEBUG
-#define TCO_DEBUG(fmt, ...)                                     \

hw/acpi/tco.c line 20

Quoted 10 lines
hw/acpi/tco.c +0 -7
-    do {                                                        \
-        fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__);    \
-    } while (0)
-#else
-#define TCO_DEBUG(fmt, ...) do { } while (0)
-#endif
-
 enum {
     TCO_RLD_DEFAULT         = 0x0000,
     TCO_DAT_IN_DEFAULT      = 0x00,

Applied to my trivial-patches branch.

Thanks,
Laurent