dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
Subsystems (8)
Krzysztof Kozlowski
maintainerPATCH 1/10 dt-bindings: arm: samsung: pmu: Use unevaluatedProperties
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
--- Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/samsung/pmu.yaml +1 -1
@@ -86,7 +86,7 @@ required: - compatible - reg -additionalProperties: false +unevaluatedProperties: false allOf: - if:
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 2/10 dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties
Additional properties or nodes actually might appear (e.g. operating points table) so use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+'
--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +1 -1
@@ -96,7 +96,7 @@ required: - interrupt-names - clocks -additionalProperties: false +unevaluatedProperties: false allOf: - if:
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties
Quoted 8 lines · Krzysztof Kozlowski
Additional properties or nodes actually might appear (e.g. operating points table) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>
Rob Herring
maintainerRe: [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties
In reply to Krzysztof KozlowskiQuoted 11 lines · Krzysztof Kozlowski
Additional properties or nodes actually might appear (e.g. operating points table) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: gpu@14ac0000:
'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 3/10 dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties
In reply to Krzysztof KozlowskiAdditional properties actually might appear (e.g. clocks) so use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: timer@101c0000:
'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
--- .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml +1 -1
@@ -52,7 +52,7 @@ required: - interrupts - reg -additionalProperties: false +unevaluatedProperties: false examples: - |
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 03/10] dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties
Quoted 7 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: timer@101c0000:
'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerRe: [PATCH 03/10] dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: timer@101c0000:
'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 4/10 dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
In reply to Krzysztof KozlowskiSamsung Exynos SoCs use syscon for system registers so document its compatibles.
--- Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +4 -0
@@ -40,6 +40,10 @@ properties: - allwinner,sun50i-a64-system-controller - microchip,sparx5-cpu-syscon - mstar,msc313-pmsleep + - samsung,exynos3-sysreg + - samsung,exynos4-sysreg + - samsung,exynos5-sysreg + - samsung,exynos5433-sysreg - const: syscon
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
Quoted 13 lines · Krzysztof Kozlowski
Samsung Exynos SoCs use syscon for system registers so document its compatibles.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ 1 file changed, 4 insertions(+)Documentation/devicetree/bindings/mfd/syscon.yaml +0
-0
Documentation/devicetree/bindings/mfd/syscon.yaml properties: · line 46
Quoted 7 lines
Documentation/devicetree/bindings/mfd/syscon.yaml +4
-0@@ -40,6 +40,10 @@ properties: - allwinner,sun50i-a64-system-controller - microchip,sparx5-cpu-syscon - mstar,msc313-pmsleep + - samsung,exynos3-sysreg + - samsung,exynos4-sysreg + - samsung,exynos5-sysreg + - samsung,exynos5433-sysreg
Do you also have a patch updating Documentation/devicetree/ bindings/arm/samsung/sysreg.yaml with new compatibles?
Signature · 6 lines
Regards, Sylwester _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
Quoted 24 lines · Sylwester Nawrocki
Quoted 13 lines · Krzysztof Kozlowski
Samsung Exynos SoCs use syscon for system registers so document its compatibles.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ 1 file changed, 4 insertions(+)Documentation/devicetree/bindings/mfd/syscon.yaml +0
-0Documentation/devicetree/bindings/mfd/syscon.yaml properties: · line 46
Quoted 7 lines
Documentation/devicetree/bindings/mfd/syscon.yaml +4
-0@@ -40,6 +40,10 @@ properties: - allwinner,sun50i-a64-system-controller - microchip,sparx5-cpu-syscon - mstar,msc313-pmsleep + - samsung,exynos3-sysreg + - samsung,exynos4-sysreg + - samsung,exynos5-sysreg + - samsung,exynos5433-sysregReviewed-by Sylwester Nawrocki <[email protected]>
Quoted 2 lines
Do you also have a patch updating
Documentation/devicetree/bindings/arm/samsung/sysreg.yamlwith new compatibles?
Good point. This file should be probably dropped as everything is documented in syscon.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles
In reply to Krzysztof KozlowskiQuoted 7 lines · Krzysztof Kozlowski
Samsung Exynos SoCs use syscon for system registers so document its compatibles.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ 1 file changed, 4 insertions(+)
As pointed by Sylwester, I will send a follow up to remove other YAML file. This patch could be dropped.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 5/10 dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema
In reply to Krzysztof KozlowskiAdd Samsung 11-pin USB-C connector into standard dtschema bindings file.
--- .../connector/samsung,usb-connector-11pin.txt | 49 ------------------- .../bindings/connector/usb-connector.yaml | 44 +++++++++++++++++ 2 files changed, 44 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt
Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt deleted +0 -49
@@ -1,49 +0,0 @@ -Samsung micro-USB 11-pin connector -================================== - -Samsung micro-USB 11-pin connector is an extension of micro-USB connector. -It is present in multiple Samsung mobile devices. -It has additional pins to route MHL traffic simultanously with USB. - -The bindings are superset of usb-connector bindings for micro-USB connector[1]. - -Required properties: -- compatible: must be: "samsung,usb-connector-11pin", "usb-b-connector", -- type: must be "micro". - -Required nodes: -- any data bus to the connector should be modeled using the OF graph bindings - specified in bindings/graph.txt, unless the bus is between parent node and - the connector. Since single connector can have multpile data buses every bus - has assigned OF graph port number as follows: - 0: High Speed (HS), - 3: Mobile High-Definition Link (MHL), specific to 11-pin Samsung micro-USB. - -[1]: bindings/connector/usb-connector.yaml - -Example -------- - -Micro-USB connector with HS lines routed via controller (MUIC) and MHL lines -connected to HDMI-MHL bridge (sii8620): - -muic-max77843@66 { - ... - usb_con: connector { - compatible = "samsung,usb-connector-11pin", "usb-b-connector"; - label = "micro-USB"; - type = "micro"; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@3 { - reg = <3>; - usb_con_mhl: endpoint { - remote-endpoint = <&sii8620_mhl>; - }; - }; - }; - }; -};
Documentation/devicetree/bindings/connector/usb-connector.yaml +44 -0
59 lines not on this page · raw message
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerRe: [PATCH 05/10] dt-bindings: connector: Convert Samsung 11-pin USB bindings to dtschema
Quoted 9 lines · Krzysztof Kozlowski
Add Samsung 11-pin USB-C connector into standard dtschema bindings file.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../connector/samsung,usb-connector-11pin.txt | 49 ------------------- .../bindings/connector/usb-connector.yaml | 44 +++++++++++++++++ 2 files changed, 44 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/connector/samsung,usb-connector-11pin.txt
Applied, thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 6/10 dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
In reply to Krzysztof KozlowskiAdditional properties actually might appear (e.g. power-domains) so use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@11440000:
Additional properties are not allowed ('power-domains', '#address-cells', 'interrupts', '#size-cells' were unexpected)
--- Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/samsung-i2s.yaml +1 -1
@@ -115,7 +115,7 @@ required: - clocks - clock-names -additionalProperties: false +unevaluatedProperties: false examples: - |
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
Quoted 7 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. power-domains) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@11440000:
Additional properties are not allowed ('power-domains', '#address-cells', 'interrupts', '#size-cells' were unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Mark Brown
maintainerRe: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
In reply to Krzysztof KozlowskiQuoted 2 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. power-domains) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerRe: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. power-domains) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@11440000:
Additional properties are not allowed ('power-domains', '#address-cells', 'interrupts', '#size-cells' were unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/sound/samsung-i2s.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 7/10 arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
In reply to Krzysztof Kozlowski"gpios" property is deprecated. Update the Exynos5433 DTS to fix dtbs_checks warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required property arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required property
--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +2 -2
@@ -87,8 +87,8 @@ i2c_max98504: i2c-gpio-0 { compatible = "i2c-gpio"; - gpios = <&gpd0 1 GPIO_ACTIVE_HIGH /* SPK_AMP_SDA */ - &gpd0 0 GPIO_ACTIVE_HIGH /* SPK_AMP_SCL */ >; + sda-gpios = <&gpd0 1 GPIO_ACTIVE_HIGH>; + scl-gpios = <&gpd0 0 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; #address-cells = <1>; #size-cells = <0>;
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
Quoted 7 lines · Krzysztof Kozlowski
"gpios" property is deprecated. Update the Exynos5433 DTS to fix
dtbs_checkswarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required propertyarch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>
Quoted 9 lines
--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-0
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 94
Quoted 10 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +2
-2@@ -87,8 +87,8 @@ i2c_max98504: i2c-gpio-0 { compatible = "i2c-gpio"; - gpios = <&gpd0 1 GPIO_ACTIVE_HIGH /* SPK_AMP_SDA */ - &gpd0 0 GPIO_ACTIVE_HIGH /* SPK_AMP_SCL */ >; + sda-gpios = <&gpd0 1 GPIO_ACTIVE_HIGH>; + scl-gpios = <&gpd0 0 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; #address-cells = <1>; #size-cells = <0>;
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
In reply to Krzysztof KozlowskiQuoted 7 lines · Krzysztof Kozlowski
"gpios" property is deprecated. Update the Exynos5433 DTS to fix
dtbs_checkswarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required propertyarch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433
In reply to Krzysztof KozlowskiQuoted 9 lines · Krzysztof Kozlowski
"gpios" property is deprecated. Update the Exynos5433 DTS to fix
dtbs_checkswarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'sda-gpios' is a required propertyarch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--
Applied.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 8/10 arm64: dts: exynos: Add compatibles to sysreg nodes
In reply to Krzysztof KozlowskiSystem register nodes, implementing syscon binding, should use appropriate compatible. This fixes dtbs_check warnings:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000:
compatible: ['syscon'] is not valid under any of the given schemas
--- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +3 -3
@@ -1015,17 +1015,17 @@ }; syscon_disp: syscon@13b80000 { - compatible = "syscon"; + compatible = "samsung,exynos5433-sysreg", "syscon"; reg = <0x13b80000 0x1010>; }; syscon_cam0: syscon@120f0000 { - compatible = "syscon"; + compatible = "samsung,exynos5433-sysreg", "syscon"; reg = <0x120f0000 0x1020>; }; syscon_cam1: syscon@145f0000 { - compatible = "syscon"; + compatible = "samsung,exynos5433-sysreg", "syscon"; reg = <0x145f0000 0x1038>; };
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes
Quoted 7 lines · Krzysztof Kozlowski
System register nodes, implementing syscon binding, should use appropriate compatible. This fixes
dtbs_checkwarnings:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000:
compatible: ['syscon'] is not valid under any of the given schemasSigned-off-by Krzysztof Kozlowski <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes
In reply to Krzysztof KozlowskiQuoted 9 lines · Krzysztof Kozlowski
System register nodes, implementing syscon binding, should use appropriate compatible. This fixes
dtbs_checkwarnings:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: syscon@13b80000:
compatible: ['syscon'] is not valid under any of the given schemasSigned-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
Applied.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 9/10 arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
In reply to Krzysztof KozlowskiThe USB-C connector bindings require port@0. Such port was already described in DTS but outside of the connector itself. Put it into proper place to fix dtbs_check warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property
---
Not tested on HQ. Please kindly review and test.
Best regards,
Krzysztof
--- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +7 -8
@@ -871,6 +871,13 @@ #address-cells = <1>; #size-cells = <0>; + port@0 { + reg = <0>; + muic_to_usb: endpoint { + remote-endpoint = <&usb_to_muic>; + }; + }; + port@3 { reg = <3>; musb_con_to_mhl: endpoint {
@@ -879,14 +886,6 @@ }; }; }; - - ports { - port { - muic_to_usb: endpoint { - remote-endpoint = <&usb_to_muic>; - }; - }; - }; }; regulators {
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
The USB-C connector bindings require port@0. Such port was already described in DTS but outside of the connector itself. Put it into proper place to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml:musb_connector: ports: 'port@0' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>
I'm not sure if topic should be about USB-C, I will call it simply USB connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, which has nothing in common with USB Type-C.
Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, so something has to be somehow adjusted or fixed. Added CC Andrzej Hajda, who actually worked on this.
Quoted 33 lines
---
Not tested on HQ. Please kindly review and test.
Best regards,
Krzysztof--- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +7
-1@@ -871,6 +871,13 @@ #address-cells = <1>; #size-cells = <0>; + port@0 { + reg = <0>; + muic_to_usb: endpoint { + remote-endpoint = <&usb_to_muic>; + }; + }; + port@3 { reg = <3>; musb_con_to_mhl: endpoint {@@ -879,14 +886,6 @@ }; }; }; -
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 891
Quoted 10 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-7- ports { - port { - muic_to_usb: endpoint { - remote-endpoint = <&usb_to_muic>; - }; - }; - }; }; regulators {
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
Quoted 36 lines · Marek Szyprowski
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
The USB-C connector bindings require port@0. Such port was already described in DTS but outside of the connector itself. Put it into proper place to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml:musb_connector: ports: 'port@0' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>I'm not sure if topic should be about USB-C, I will call it simply USB connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, which has nothing in common with USB Type-C.
Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, so something has to be somehow adjusted or fixed. Added CC Andrzej Hajda, who actually worked on this.
Quoted 18 lines
---
Not tested on HQ. Please kindly review and test.
Best regards,
Krzysztof--- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-0@@ -871,6 +871,13 @@ #address-cells = <1>; #size-cells = <0>;
Quoted 7 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 880
Quoted 7 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +7
-0+ port@0 { + reg = <0>; + muic_to_usb: endpoint { + remote-endpoint = <&usb_to_muic>; + }; + }; +
According to not-yet-yaml documentation of dt-bindings (patch 05/10):
Review
Quoted 4 lines
(quoted diff) +0
-4-Required nodes: -- any data bus to the connector should be modeled using the OF graph bindings - specified in bindings/graph.txt, unless the bus is between parent node and - the connector.
This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary.
Quoted 6 lines
Quoted 6 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-0port@3 { reg = <3>; musb_con_to_mhl: endpoint {@@ -879,14 +886,6 @@ }; };
Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 888
Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-7}; - - ports { - port { - muic_to_usb: endpoint { - remote-endpoint = <&usb_to_muic>; - }; - };
And this port belongs to MUIC - it describes connection between USB-HOST and MUIC, it has nothing to do with the connector, and is necessary.
Regards
Andrzej
Quoted 5 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 891
Quoted 4 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-1- }; }; regulators {Best regards
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2
Quoted 66 lines · Andrzej Hajda
Quoted 36 lines · Marek Szyprowski
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
The USB-C connector bindings require port@0. Such port was already described in DTS but outside of the connector itself. Put it into proper place to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml:musb_connector: ports: 'port@0' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>I'm not sure if topic should be about USB-C, I will call it simply USB connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, which has nothing in common with USB Type-C.
Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, so something has to be somehow adjusted or fixed. Added CC Andrzej Hajda, who actually worked on this.
Quoted 18 lines
---
Not tested on HQ. Please kindly review and test.
Best regards,
Krzysztof--- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-0@@ -871,6 +871,13 @@ #address-cells = <1>; #size-cells = <0>;Quoted 7 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 880
Quoted 7 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +7
-0+ port@0 { + reg = <0>; + muic_to_usb: endpoint { + remote-endpoint = <&usb_to_muic>; + }; + }; +According to not-yet-yaml documentation of dt-bindings (patch 05/10):
Review
Quoted 4 lines
(quoted diff) +0
-4-Required nodes: -- any data bus to the connector should be modeled using the OF graph bindings - specified in bindings/graph.txt, unless the bus is between parent node and - the connector.This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary.
Quoted 10 lines
Quoted 10 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-3port@3 { reg = <3>; musb_con_to_mhl: endpoint {@@ -879,14 +886,6 @@ }; }; }; - - ports { - port {
Quoted 8 lines
Quoted 4 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 888
Quoted 4 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-4- muic_to_usb: endpoint { - remote-endpoint = <&usb_to_muic>; - }; - };And this port belongs to MUIC - it describes connection between USB-HOST and MUIC, it has nothing to do with the connector, and is necessary.
Thanks for checking this. It's really appreciated!
I'll work on v2 later to address the schema warning, hopefully without breaking things...
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerPATCH 10/10 arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
In reply to Krzysztof KozlowskiThe Wolfson Arizona codec is interrupt controller which is required by bindings. This fixes dtbs_check warnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property
---
Not tested on HQ. Please kindly review and test.
Best regards,
Krzysztof
--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +2 -0
@@ -1242,6 +1242,8 @@ gpio-controller; #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; wlf,micd-detect-debounce = <300>; wlf,micd-bias-start-time = <0x1>;
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
Quoted 7 lines · Krzysztof Kozlowski
The Wolfson Arizona codec is interrupt controller which is required by bindings. This fixes
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required propertyarch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>
However I really wonder if it makes sense to expose this to DTS. Indeed, the main MFD device of the WM5110 chip is interrupt controller, but its interrupts are requested internally by the respective drivers.
Quoted 15 lines
---
Not tested on HQ. Please kindly review and test.
Best regards,
Krzysztof--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-0
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi line 1249
Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +2
-0@@ -1242,6 +1242,8 @@ gpio-controller; #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; wlf,micd-detect-debounce = <300>; wlf,micd-bias-start-time = <0x1>;
Best regards
Signature · 7 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
Quoted 9 lines · Marek Szyprowski
Quoted 6 lines · Krzysztof Kozlowski
The Wolfson Arizona codec is interrupt controller which is required by bindings. This fixes
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required propertyarch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property
Quoted 7 lines
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>Tested-by Marek Szyprowski <[email protected]>However I really wonder if it makes sense to expose this to DTS. Indeed, the main MFD device of the WM5110 chip is interrupt controller, but its interrupts are requested internally by the respective drivers.
In such case maybe the schema should be updated? Feel free to send a follow up or a replacement patch for this one.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>
Krzysztof Kozlowski
maintainerQuoted 10 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Rob,
Could you pick all of my dt-bindings schema patches if they are ok? From this and other series. You already have few of them in your tree so it will help to avoid conflicts.
I am afraid that subsystem maintainers can leave them to you and vice versa :)
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Mark Brown
maintainerQuoted 5 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: samsung-i2s: Use unevaluatedProperties
commit: 8187d8300251a99e40e288be80bef6a15b7b22e4
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerQuoted 7 lines · Mark Brown
Quoted 5 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
Quoted 8 lines
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: samsung-i2s: Use unevaluatedProperties
commit: 8187d8300251a99e40e288be80bef6a15b7b22e4
Please revert or drop. All these 'unevaluatedProperties' changes are wrong.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerQuoted 10 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: system-controller@105c0000:
'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel