Skip to contentSkip to conversation

dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

PATCH In review Krzysztof Kozlowski 4 participants 14 messages Aug 30, 2020 – Sep 3, 2020

Subsystems (3)
Device tree bindings ASoC Samsung audio (ASoC) drivers
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/2 dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles

The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like:

arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 .../devicetree/bindings/sound/samsung,midas-audio.yaml      | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml +4 -2
index 1c755de686f7..578928e67e5c 100644
@@ -21,7 +21,8 @@ properties:
     type: object
     properties:
       sound-dai:
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: /schemas/types.yaml#/definitions/phandle-array
+        maxItems: 1
         description: phandle to the I2S controller
     required:
       - sound-dai

@@ -30,7 +31,8 @@ properties:
     type: object
     properties:
       sound-dai:
-        $ref: /schemas/types.yaml#/definitions/phandle
+        $ref: /schemas/types.yaml#/definitions/phandle-array
+        maxItems: 1
         description: phandle to the WM1811 CODEC
     required:
       - sound-dai
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/2 dt-bindings: sound: odroid: Use unevaluatedProperties

Additional properties or nodes actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound:
'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 Documentation/devicetree/bindings/sound/samsung,odroid.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/samsung,odroid.yaml +1 -1
index 8ff2d39e7d17..de1be3d6d1e9 100644
@@ -69,7 +69,7 @@ required:
   - cpu
   - codec
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dt-bindings: sound: odroid: Use unevaluatedProperties

Quoted 8 lines · Krzysztof Kozlowski

Additional properties or nodes actually might appear (e.g. assigned-clocks) so use unevaluatedProperties to fix dtbs_check warnings like:

arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound:
'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by Krzysztof Kozlowski <[email protected]>
Reviewed-by Sylwester Nawrocki <[email protected]>
maintainer Reviewed-by on v1 1/2
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like:

arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long

Signed-off-by Krzysztof Kozlowski <[email protected]>
Reviewed-by Sylwester Nawrocki <[email protected]>
maintainer
#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like:

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

author
#5 lore raw
Quoted 10 lines · Mark Brown
Quoted 3 lines · Krzysztof Kozlowski

The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like:

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

The usual prefix for bindings is "dt-bindings: ..." so I wonder what type of prefix you expect:
1. ASoC: dt-bindings: ...
2. dt-bindings: ASoC: ...

Which one of these?

Best regards,
Krzysztof

maintainer
#6 lore raw
Quoted 8 lines · Krzysztof Kozlowski
Quoted 2 lines · Mark Brown

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches.

The usual prefix for bindings is "dt-bindings: ..." so I wonder what type of prefix you expect:
1. ASoC: dt-bindings: ...

This. Bindings aren't a separate subsystem.

author
#7 lore raw
Quoted 11 lines · Mark Brown
Quoted 8 lines · Krzysztof Kozlowski
Quoted 2 lines · Mark Brown

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches.

The usual prefix for bindings is "dt-bindings: ..." so I wonder what type of prefix you expect:
1. ASoC: dt-bindings: ...

This. Bindings aren't a separate subsystem.

Sure, thanks!

Best regards,
Krzysztof

maintainer
#8 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like:

arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: midas-audio: Correct parsing sound-dai phandles

      commit: 3e7ba1c0432ef9a792b9c77d36f78037626303b0
[2/2] ASoC: odroid: Use unevaluatedProperties
      commit: a57307ca6b661e16f9435a25f376ac277c3de697

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

maintainer
#9 lore raw
Quoted 10 lines · Mark Brown
Quoted 6 lines · Krzysztof Kozlowski

The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like:

arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long

Applied to

Quoted 8 lines

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: midas-audio: Correct parsing sound-dai phandles

      commit: 3e7ba1c0432ef9a792b9c77d36f78037626303b0
[2/2] ASoC: odroid: Use unevaluatedProperties
      commit: a57307ca6b661e16f9435a25f376ac277c3de697

This one should be reverted/dropped too. Patch 1 is fine.

maintainer
#10 lore raw
Quoted 4 lines · Rob Herring
Quoted 2 lines

[2/2] ASoC: odroid: Use unevaluatedProperties

      commit: a57307ca6b661e16f9435a25f376ac277c3de697

This one should be reverted/dropped too. Patch 1 is fine.

There are others? What's the issue with them? It'd be easiest if you could send patches doing whatever reverts you're looking for.

maintainer
#11 lore raw
Quoted 10 lines · Mark Brown
Quoted 4 lines · Rob Herring
Quoted 2 lines

[2/2] ASoC: odroid: Use unevaluatedProperties

      commit: a57307ca6b661e16f9435a25f376ac277c3de697

This one should be reverted/dropped too. Patch 1 is fine.

There are others? What's the issue with them? It'd be easiest if you could send patches doing whatever reverts you're looking for.

Just 1 other you picked up. See "ASoC: samsung-i2s: Use unevaluatedProperties". Patches adding the missing properties (and restoring 'additionalProperties' on these 2 if not reverted) is the correct change.

I've gone thru and NAKed all of the others so more don't get picked up.

Rob

author
#12 lore raw
Quoted 13 lines · Rob Herring
Quoted 10 lines · Mark Brown
Quoted 4 lines · Rob Herring
Quoted 2 lines

[2/2] ASoC: odroid: Use unevaluatedProperties

      commit: a57307ca6b661e16f9435a25f376ac277c3de697

This one should be reverted/dropped too. Patch 1 is fine.

There are others? What's the issue with them? It'd be easiest if you could send patches doing whatever reverts you're looking for.

Quoted 6 lines

Just 1 other you picked up. See "ASoC: samsung-i2s: Use unevaluatedProperties". Patches adding the missing properties (and restoring 'additionalProperties' on these 2 if not reverted) is the correct change.

I've gone thru and NAKed all of the others so more don't get picked up.

Ah, my bad... Mark, I can send a follow up which restores the additionalProperties (so kind of revert of the second patch) and fixes the warning. Other way is that you just drop it and I will send a correct fix later.

Sorry for the mess.

Best regards,
Krzysztpf

maintainer
#13 lore raw
Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Rob Herring

Just 1 other you picked up. See "ASoC: samsung-i2s: Use unevaluatedProperties". Patches adding the missing properties (and restoring 'additionalProperties' on these 2 if not reverted) is the correct change.

Quoted 6 lines
Quoted 1 line

I've gone thru and NAKed all of the others so more don't get picked up.

Ah, my bad... Mark, I can send a follow up which restores the additionalProperties (so kind of revert of the second patch) and fixes the warning. Other way is that you just drop it and I will send a correct fix later.

Sure, that sounds great - I'm just finishing up for today anyway so I'll look out for something tomorrow.