Skip to contentSkip to conversation

fix build with make 3.81

PATCH In review Juergen Gross 2 participants 2 messages Sep 1, 2020 – Sep 4, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix build with make 3.81

make 3.81 doesn't support multiline variables defined with

define var =
...
endef

Dropping the "=" in the first line will fix the issue.

Fixes ded08cdfa72bb ("tools: generate most contents of library make variables")
Fixes ddb2934a914df ("stubdom: add correct dependencies for Xen libraries")
---
 stubdom/Makefile | 2 +-
 tools/Rules.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
stubdom/Makefile +1 -1
index 4fd86dd44b..98eba8efe3 100644
@@ -25,7 +25,7 @@ endif
 
 include $(XEN_ROOT)/tools/libs/uselibs.mk
 
-define LIB_deps =
+define LIB_deps
  LIBDEPS_$(1) = $$(foreach use,$$(USELIBS_$(1)),libxen$$(use))
 endef
 $(foreach lib,$(LIBS_LIBS),$(eval $(call LIB_deps,$(lib))))
tools/Rules.mk +1 -1
index 7e019a8a65..385807a71c 100644
@@ -94,7 +94,7 @@ endif
 # Consumers of libfoo should not directly use $(SHDEPS_libfoo) or
 # $(SHLIB_libfoo)
 
-define LIB_defs =
+define LIB_defs
  XEN_libxen$(1) = $$(XEN_ROOT)/tools/libs/$(1)
  CFLAGS_libxen$(1) = -I$$(XEN_libxen$(1))/include $$(CFLAGS_xeninclude)
  SHDEPS_libxen$(1) = $$(foreach use,$$(USELIBS_$(1)),$$(SHLIB_libxen$$(use)))
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw

Juergen Gross writes ("[PATCH] fix build with make 3.81"):

Quoted 5 lines

make 3.81 doesn't support multiline variables defined with

define var =
...
endef

And commited, thanks.

Ian.