fuse, dax: Couple of fixes for fuse dax support
Subsystems (2)
cover fuse, dax: Couple of fixes for fuse dax support
Hi Miklos,
I am testing fuse dax branch now. To begin with here are couple of simple fixes to make sure I/O is going through dax path.
Either you can roll these fixes into existing patches or apply on top.
I ran blogbench workload and some fio mmap jobs and these seem to be running fine after these fixes.
Thanks
Vivek
Vivek Goyal (2):
fuse, dax: Use correct config option CONFIG_FUSE_DAX fuse, dax: Save dax device in fuse_conn_dax
fs/fuse/dax.c | 1 + fs/fuse/file.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.4
PATCH 1/2 fuse, dax: Use correct config option CONFIG_FUSE_DAX
Correct config option to use is CONFIG_FUSE_DAX and not CONFIG_VIRTIO_FS_DAX.
--- fs/fuse/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -1
@@ -3480,6 +3480,6 @@ void fuse_init_file_inode(struct inode *inode)init_waitqueue_head (&fi->page_waitq); fi->writepages =RB_ROOT ; -if (IS_ENABLED (CONFIG_VIRTIO_FS_DAX )) +if (IS_ENABLED (CONFIG_FUSE_DAX ))fuse_dax_inode_init (inode); }
Signature · 1 line
2.25.4
PATCH 2/2 fuse, dax: Save dax device in fuse_conn_dax
In reply to Vivek GoyalThis is needed later in fuse_iomap_begin to fill iomap->dax_dev. Otherwise dax generic code (dax_iomap_rw()) returns -EOPNOTSUPP.
--- fs/fuse/dax.c | 1 + 1 file changed, 1 insertion(+)
fs/fuse/dax.c +1 -0
@@ -1296,6 +1296,7 @@ int fuse_dax_conn_alloc(struct fuse_conn *fc, struct dax_device *dax_dev) fcd->nr_free_ranges = nr_ranges; fcd->nr_ranges = nr_ranges; + fcd->dev = dax_dev; fc->dax = fcd;return 0 ;
Signature · 1 line
2.25.4
Miklos Szeredi
maintainerQuoted 11 lines · Vivek Goyal
Hi Miklos,
I am testing fuse dax branch now. To begin with here are couple of simple fixes to make sure I/O is going through dax path.
Either you can roll these fixes into existing patches or apply on top.
I ran blogbench workload and some fio mmap jobs and these seem to be running fine after these fixes.
Thanks for testing and fixing.
Pushed a rerolled series to #for-next. Would be good if you cour retest.
There's one checkpatch warning I'm unsure about:
| WARNING: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
| #173: FILE: fs/fuse/virtio_fs.c:812:
| + dev_dbg(&vdev->dev, "%s: window kaddr 0x%px phys_addr 0x%llx
len 0x%llx\n",
| + __func__, fs->window_kaddr, cache_reg.addr, cache_reg.len); | | total: 0 errors, 1 warnings, 175 lines checked | | NOTE: For some of the reported defects, checkpatch may be able to | mechanically convert to the typical style using --fix or --fix-inplace. | | patches/virtio_fs-dax-set-up-virtio_fs-dax_device.patch has style
problems, please review.
Do you think that the kernel address in the debug output is necessary?
Thanks,
Miklos
Quoted 10 lines · Miklos Szeredi
Quoted 9 lines · Vivek Goyal
Hi Miklos,
I am testing fuse dax branch now. To begin with here are couple of simple fixes to make sure I/O is going through dax path.
Either you can roll these fixes into existing patches or apply on top.
Quoted 6 lines
Quoted 2 lines
I ran blogbench workload and some fio mmap jobs and these seem to be running fine after these fixes.
Thanks for testing and fixing.
Pushed a rerolled series to #for-next. Would be good if you cour retest.
Thanks. Will test again next week.
Quoted 17 lines
There's one checkpatch warning I'm unsure about:
| WARNING: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
| #173: FILE:fs/fuse/virtio_fs.c:812:
| + dev_dbg(&vdev->dev, "%s: window kaddr 0x%pxphys_addr0x%llx
len 0x%llx\n",| + __func__, fs->window_kaddr, cache_reg.addr, cache_reg.len); | | total: 0 errors, 1 warnings, 175 lines checked | | NOTE: For some of the reported defects, checkpatch may be able to | mechanically convert to the typical style using --fix or --fix-inplace. | | patches/virtio_fs-dax-set-up-virtio_fs-dax_device.patch has style
Quoted 3 lines
problems, please review.
Do you think that the kernel address in the debug output is necessary?
It is more of a nice to have thing. Was more useful in initial development. Now things have stablized, so I don't use it that much anymore.
So I am fine converting %px to %p. I am not sure though how people practically make use of %p output for debugging. IIUC, that's a hash of actual value.
This debug output atleast tells us that a certain virtio device provided a cache window and driver mapped it.
Thanks
Vivek