Skip to contentSkip to conversation

selftests: arm64: Add floating point selftests

PATCH In review Mark Brown 4 participants 14 messages Aug 19, 2020 – Sep 18, 2020

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

v2 cover selftests: arm64: Add floating point selftests

This series imports a series of tests for FPSIMD and SVE originally written by Dave Martin to the tree. Since these extensions have some overlap in terms of register usage and must sometimes be tested together they're dropped into a single directory. I've adapted some of the tests to run within the kselftest framework but there are also some stress tests here that are intended to be run as soak tests so aren't suitable for running by default and are mostly just integrated with the build system. There doesn't seem to be a more suitable home for those stress tests and they are very useful for work on these areas of the code so it seems useful to have them somewhere in tree.

v2: Rebased onto v5.9-rc1

Mark Brown (6):
selftests: arm64: Test case for enumeration of SVE vector lengths
selftests: arm64: Add test for the SVE ptrace interface
selftests: arm64: Add stress tests for FPSMID and SVE context
switching
selftests: arm64: Add utility to set SVE vector lengths
selftests: arm64: Add wrapper scripts for stress tests
selftests: arm64: Add build and documentation for FP tests

 tools/testing/selftests/arm64/Makefile        |   2 +-
 tools/testing/selftests/arm64/fp/.gitignore   |   5 +
 tools/testing/selftests/arm64/fp/Makefile     |  17 +
 tools/testing/selftests/arm64/fp/README       | 100 +++
 .../testing/selftests/arm64/fp/asm-offsets.h  |  11 +
 tools/testing/selftests/arm64/fp/assembler.h  |  57 ++
 .../testing/selftests/arm64/fp/fpsimd-stress  |  60 ++
 .../testing/selftests/arm64/fp/fpsimd-test.S  | 482 +++++++++++++
 .../selftests/arm64/fp/sve-probe-vls.c        |  58 ++
 .../selftests/arm64/fp/sve-ptrace-asm.S       |  33 +
 tools/testing/selftests/arm64/fp/sve-ptrace.c | 336 +++++++++
 tools/testing/selftests/arm64/fp/sve-stress   |  59 ++
 tools/testing/selftests/arm64/fp/sve-test.S   | 672 ++++++++++++++++++
 tools/testing/selftests/arm64/fp/vlset.c      | 155 ++++
 14 files changed, 2046 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/arm64/fp/.gitignore
 create mode 100644 tools/testing/selftests/arm64/fp/Makefile
 create mode 100644 tools/testing/selftests/arm64/fp/README
 create mode 100644 tools/testing/selftests/arm64/fp/asm-offsets.h
 create mode 100644 tools/testing/selftests/arm64/fp/assembler.h
 create mode 100755 tools/testing/selftests/arm64/fp/fpsimd-stress
 create mode 100644 tools/testing/selftests/arm64/fp/fpsimd-test.S
 create mode 100644 tools/testing/selftests/arm64/fp/sve-probe-vls.c
 create mode 100644 tools/testing/selftests/arm64/fp/sve-ptrace-asm.S
 create mode 100644 tools/testing/selftests/arm64/fp/sve-ptrace.c
 create mode 100755 tools/testing/selftests/arm64/fp/sve-stress
 create mode 100644 tools/testing/selftests/arm64/fp/sve-test.S
 create mode 100644 tools/testing/selftests/arm64/fp/vlset.c
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH v2 1/6 selftests: arm64: Test case for enumeration of SVE vector lengths

Add a test case that verifies that we can enumerate the SVE vector lengths on systems where we detect SVE, and that those SVE vector lengths are valid. This program was written by Dave Martin and adapted to kselftest by me.

---
 .../selftests/arm64/fp/sve-probe-vls.c        | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 tools/testing/selftests/arm64/fp/sve-probe-vls.c
tools/testing/selftests/arm64/fp/sve-probe-vls.c new file +58 -0
new file mode 100644
index 000000000000..b29cbc642c57
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2015-2020 ARM Limited.
+ * Original author: Dave Martin <[email protected]>
+ */
+#include <assert.h>
+#include <errno.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/auxv.h>
+#include <sys/prctl.h>
+#include <asm/sigcontext.h>
+
+#include "../../kselftest.h"
+
+int main(int argc, char **argv)
+{
+	unsigned int vq;
+	int vl;
+	static unsigned int vqs[SVE_VQ_MAX];
+	unsigned int nvqs = 0;
+
+	ksft_print_header();
+	ksft_set_plan(2);
+
+	if (!(getauxval(AT_HWCAP) & HWCAP_SVE))
+		ksft_exit_skip("SVE not available");
+
+	/*
+	 * Enumerate up to SVE_VQ_MAX vector lengths
+	 */
+	for (vq = SVE_VQ_MAX; vq > 0; --vq) {
+		vl = prctl(PR_SVE_SET_VL, vq * 16);
+		if (vl == -1)
+			ksft_exit_fail_msg("PR_SVE_SET_VL failed: %s (%d)\n",
+					   strerror(errno), errno);
+
+		vl &= PR_SVE_VL_LEN_MASK;
+
+		if (!sve_vl_valid(vl))
+			ksft_exit_fail_msg("VL %d invalid\n", vl);
+		vq = sve_vq_from_vl(vl);
+
+		if (!(nvqs < SVE_VQ_MAX))
+			ksft_exit_fail_msg("Too many VLs %u >= SVE_VQ_MAX\n",
+					   nvqs);
+		vqs[nvqs++] = vq;
+	}
+	ksft_test_result_pass("Enumerated %d vector lengths\n", nvqs);
+	ksft_test_result_pass("All vector lengths valid\n");
+
+	/* Print out the vector lengths in ascending order: */
+	while (nvqs--)
+		ksft_print_msg("%u\n", 16 * vqs[nvqs]);
+
+	ksft_exit_pass();
+}
Signature · 1 line
2.20.1
author
#2 lore raw

PATCH v2 2/6 selftests: arm64: Add test for the SVE ptrace interface

In reply to Mark Brown

Add a test case that does some basic verification of the SVE ptrace interface, forking off a child with known values in the registers and then using ptrace to inspect and manipulate the SVE registers of the child, including in FPSIMD mode to account for sharing between the SVE and FPSIMD registers.

This program was written by Dave Martin and modified for kselftest by me.

---
 .../selftests/arm64/fp/sve-ptrace-asm.S       |  33 ++
 tools/testing/selftests/arm64/fp/sve-ptrace.c | 336 ++++++++++++++++++
 2 files changed, 369 insertions(+)
 create mode 100644 tools/testing/selftests/arm64/fp/sve-ptrace-asm.S
 create mode 100644 tools/testing/selftests/arm64/fp/sve-ptrace.c
tools/testing/selftests/arm64/fp/sve-ptrace-asm.S new file +33 -0
new file mode 100644
index 000000000000..3e81f9fab574
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (C) 2015-2019 ARM Limited.
+// Original author: Dave Martin <[email protected]>
+#include <asm/unistd.h>
+
+.arch_extension sve
+
+.globl sve_store_patterns
+
+sve_store_patterns:
+	mov	x1, x0
+
+	index	z0.b, #0, #1
+	str	q0, [x1]
+
+	mov	w8, #__NR_getpid
+	svc	#0
+	str	q0, [x1, #0x10]
+
+	mov	z1.d, z0.d
+	str	q0, [x1, #0x20]
+
+	mov	w8, #__NR_getpid
+	svc	#0
+	str	q0, [x1, #0x30]
+
+	mov	z1.d, z0.d
+	str	q0, [x1, #0x40]
+
+	ret
+
+.size	sve_store_patterns, . - sve_store_patterns
+.type	sve_store_patterns, @function
tools/testing/selftests/arm64/fp/sve-ptrace.c new file +336 -0

336 lines not on this page · raw message

Signature · 1 line
2.20.1
author
#3 lore raw

PATCH v2 3/6 selftests: arm64: Add stress tests for FPSMID and SVE context switching

In reply to Mark Brown

Add programs sve-test and fpsimd-test which spin reading and writing to the SVE and FPSIMD registers, verifying the operations they perform. The intended use is to leave them running to stress the context switch code's handling of these registers which isn't compatible with what kselftest does so they're not integrated into the framework but there's no other obvious testsuite where they fit so let's store them here.

These tests were written by Dave Martin and lightly adapted by me.

---
 .../testing/selftests/arm64/fp/asm-offsets.h  |  11 +
 tools/testing/selftests/arm64/fp/assembler.h  |  57 ++
 .../testing/selftests/arm64/fp/fpsimd-test.S  | 482 +++++++++++++
 tools/testing/selftests/arm64/fp/sve-test.S   | 672 ++++++++++++++++++
 4 files changed, 1222 insertions(+)
 create mode 100644 tools/testing/selftests/arm64/fp/asm-offsets.h
 create mode 100644 tools/testing/selftests/arm64/fp/assembler.h
 create mode 100644 tools/testing/selftests/arm64/fp/fpsimd-test.S
 create mode 100644 tools/testing/selftests/arm64/fp/sve-test.S
tools/testing/selftests/arm64/fp/asm-offsets.h new file +11 -0
new file mode 100644
index 000000000000..a180851496ec
@@ -0,0 +1,11 @@
+#define sa_sz 32
+#define sa_flags 8
+#define sa_handler 0
+#define sa_mask_sz 8
+#define SIGUSR1 10
+#define SIGTERM 15
+#define SIGINT 2
+#define SIGABRT 6
+#define SA_NODEFER 1073741824
+#define SA_SIGINFO 4
+#define ucontext_regs 184
tools/testing/selftests/arm64/fp/assembler.h new file +57 -0

57 lines not on this page · raw message

tools/testing/selftests/arm64/fp/fpsimd-test.S new file +482 -0

482 lines not on this page · raw message

tools/testing/selftests/arm64/fp/sve-test.S new file +672 -0

672 lines not on this page · raw message

Signature · 1 line
2.20.1
author
#4 lore raw

PATCH v2 4/6 selftests: arm64: Add utility to set SVE vector lengths

In reply to Mark Brown

vlset is a small utility for use in conjunction with tests like the sve-test stress test which allows another executable to be invoked with a configured SVE vector length.

---
 tools/testing/selftests/arm64/fp/vlset.c | 155 +++++++++++++++++++++++
 1 file changed, 155 insertions(+)
 create mode 100644 tools/testing/selftests/arm64/fp/vlset.c
tools/testing/selftests/arm64/fp/vlset.c new file +155 -0
new file mode 100644
index 000000000000..308d27a68226
@@ -0,0 +1,155 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2015-2019 ARM Limited.
+ * Original author: Dave Martin <[email protected]>
+ */
+#define _GNU_SOURCE
+#include <assert.h>
+#include <errno.h>
+#include <limits.h>
+#include <stddef.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <getopt.h>
+#include <unistd.h>
+#include <sys/auxv.h>
+#include <sys/prctl.h>
+#include <asm/hwcap.h>
+#include <asm/sigcontext.h>
+
+static int inherit = 0;
+static int no_inherit = 0;
+static int force = 0;
+static unsigned long vl;
+
+static const struct option options[] = {
+	{ "force",	no_argument, NULL, 'f' },
+	{ "inherit",	no_argument, NULL, 'i' },
+	{ "max",	no_argument, NULL, 'M' },
+	{ "no-inherit",	no_argument, &no_inherit, 1 },
+	{ "help",	no_argument, NULL, '?' },
+	{}
+};
+
+static char const *program_name;
+
+static int parse_options(int argc, char **argv)
+{
+	int c;
+	char *rest;
+
+	program_name = strrchr(argv[0], '/');
+	if (program_name)
+		++program_name;
+	else
+		program_name = argv[0];
+
+	while ((c = getopt_long(argc, argv, "Mfhi", options, NULL)) != -1)
+		switch (c) {
+		case 'M':	vl = SVE_VL_MAX; break;
+		case 'f':	force = 1; break;
+		case 'i':	inherit = 1; break;
+		case 0:		break;
+		default:	goto error;
+		}
+
+	if (inherit && no_inherit)
+		goto error;
+
+	if (!vl) {
+		/* vector length */
+		if (optind >= argc)
+			goto error;
+
+		errno = 0;
+		vl = strtoul(argv[optind], &rest, 0);
+		if (*rest) {
+			vl = ULONG_MAX;
+			errno = EINVAL;
+		}
+		if (vl == ULONG_MAX && errno) {
+			fprintf(stderr, "%s: %s: %s\n",
+				program_name, argv[optind], strerror(errno));
+			goto error;
+		}
+
+		++optind;
+	}
+
+	/* command */
+	if (optind >= argc)
+		goto error;
+
+	return 0;
+
+error:
+	fprintf(stderr,
+		"Usage: %s [-f | --force] "
+		"[-i | --inherit | --no-inherit] "
+		"{-M | --max | <vector length>} "
+		"<command> [<arguments> ...]\n",
+		program_name);
+	return -1;
+}
+
+int main(int argc, char **argv)
+{
+	int ret = 126;	/* same as sh(1) command-not-executable error */
+	long flags;
+	char *path;
+	int t, e;
+
+	if (parse_options(argc, argv))
+		return 2;	/* same as sh(1) builtin incorrect-usage */
+
+	if (vl & ~(vl & PR_SVE_VL_LEN_MASK)) {
+		fprintf(stderr, "%s: Invalid vector length %lu\n",
+			program_name, vl);
+		return 2;	/* same as sh(1) builtin incorrect-usage */
+	}
+
+	if (!(getauxval(AT_HWCAP) & HWCAP_SVE)) {
+		fprintf(stderr, "%s: Scalable Vector Extension not present\n",
+			program_name);
+
+		if (!force)
+			goto error;
+
+		fputs("Going ahead anyway (--force):  "
+		      "This is a debug option.  Don't rely on it.\n",
+		      stderr);
+	}
+
+	flags = PR_SVE_SET_VL_ONEXEC;
+	if (inherit)
+		flags |= PR_SVE_VL_INHERIT;
+
+	t = prctl(PR_SVE_SET_VL, vl | flags);
+	if (t < 0) {
+		fprintf(stderr, "%s: PR_SVE_SET_VL: %s\n",
+			program_name, strerror(errno));
+		goto error;
+	}
+
+	t = prctl(PR_SVE_GET_VL);
+	if (t == -1) {
+		fprintf(stderr, "%s: PR_SVE_GET_VL: %s\n",
+			program_name, strerror(errno));
+		goto error;
+	}
+	flags = PR_SVE_VL_LEN_MASK;
+	flags = t & ~flags;
+
+	assert(optind < argc);
+	path = argv[optind];
+
+	execvp(path, &argv[optind]);
+	e = errno;
+	if (errno == ENOENT)
+		ret = 127;	/* same as sh(1) not-found error */
+	fprintf(stderr, "%s: %s: %s\n", program_name, path, strerror(e));
+
+error:
+	return ret;		/* same as sh(1) not-executable error */
+}
Signature · 1 line
2.20.1
author
#5 lore raw

PATCH v2 5/6 selftests: arm64: Add wrapper scripts for stress tests

In reply to Mark Brown

Add wrapper scripts which invoke fpsimd-test and sve-test with several copies per CPU such that the context switch code will be appropriately exercised.

---
 .../testing/selftests/arm64/fp/fpsimd-stress  | 60 +++++++++++++++++++
 tools/testing/selftests/arm64/fp/sve-stress   | 59 ++++++++++++++++++
 2 files changed, 119 insertions(+)
 create mode 100755 tools/testing/selftests/arm64/fp/fpsimd-stress
 create mode 100755 tools/testing/selftests/arm64/fp/sve-stress
tools/testing/selftests/arm64/fp/fpsimd-stress new file +60 -0
new file mode 100755
index 000000000000..781b5b022eaf
@@ -0,0 +1,60 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0-only
+# Copyright (C) 2015-2019 ARM Limited.
+# Original author: Dave Martin <[email protected]>
+
+set -ue
+
+NR_CPUS=`nproc`
+
+pids=
+logs=
+
+cleanup () {
+	trap - INT TERM CHLD
+	set +e
+
+	if [ -n "$pids" ]; then
+		kill $pids
+		wait $pids
+		pids=
+	fi
+
+	if [ -n "$logs" ]; then
+		cat $logs
+		rm $logs
+		logs=
+	fi
+}
+
+interrupt () {
+	cleanup
+	exit 0
+}
+
+child_died () {
+	cleanup
+	exit 1
+}
+
+trap interrupt INT TERM EXIT
+trap child_died CHLD
+
+for x in `seq 0 $((NR_CPUS * 4))`; do
+	log=`mktemp`
+	logs=$logs\ $log
+	./fpsimd-test >$log &
+	pids=$pids\ $!
+done
+
+# Wait for all child processes to be created:
+sleep 10
+
+while :; do
+	kill -USR1 $pids
+done &
+pids=$pids\ $!
+
+wait
+
+exit 1
tools/testing/selftests/arm64/fp/sve-stress new file +59 -0

59 lines not on this page · raw message

Signature · 1 line
2.20.1
author
#6 lore raw

PATCH v2 6/6 selftests: arm64: Add build and documentation for FP tests

In reply to Mark Brown

Integrate the FP tests with the build system and add some documentation for the ones run outside the kselftest infrastructure. The content in the README was largely written by Dave Martin with edits by me.

---
 tools/testing/selftests/arm64/Makefile      |   2 +-
 tools/testing/selftests/arm64/fp/.gitignore |   5 +
 tools/testing/selftests/arm64/fp/Makefile   |  17 ++++
 tools/testing/selftests/arm64/fp/README     | 100 ++++++++++++++++++++
 4 files changed, 123 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/arm64/fp/.gitignore
 create mode 100644 tools/testing/selftests/arm64/fp/Makefile
 create mode 100644 tools/testing/selftests/arm64/fp/README
tools/testing/selftests/arm64/Makefile +1 -1
index 93b567d23c8b..a28d4e7c9948 100644
@@ -4,7 +4,7 @@
 ARCH ?= $(shell uname -m 2>/dev/null || echo not)
 
 ifneq (,$(filter $(ARCH),aarch64 arm64))
-ARM64_SUBTARGETS ?= tags signal
+ARM64_SUBTARGETS ?= tags signal fp
 else
 ARM64_SUBTARGETS :=
 endif
tools/testing/selftests/arm64/fp/.gitignore new file +5 -0
new file mode 100644
index 000000000000..d66f76d2a650
@@ -0,0 +1,5 @@
+fpsimd-test
+sve-probe-vls
+sve-ptrace
+sve-test
+vlset
tools/testing/selftests/arm64/fp/Makefile new file +17 -0
new file mode 100644
index 000000000000..a57009d3a0dc
@@ -0,0 +1,17 @@
+# SPDX-License-Identifier: GPL-2.0
+
+CFLAGS += -I../../../../../usr/include/
+TEST_GEN_PROGS := sve-ptrace sve-probe-vls
+TEST_PROGS_EXTENDED := fpsimd-test fpsimd-stress sve-test sve-stress vlset
+
+all: $(TEST_GEN_PROGS) $(TEST_PROGS_EXTENDED)
+
+fpsimd-test: fpsimd-test.o
+	$(CC) -nostdlib $^ -o $@
+sve-ptrace: sve-ptrace.o sve-ptrace-asm.o
+sve-probe-vls: sve-probe-vls.o
+sve-test: sve-test.o
+	$(CC) -nostdlib $^ -o $@
+vlset: vlset.o
+
+include ../../lib.mk
tools/testing/selftests/arm64/fp/README new file +100 -0

100 lines not on this page · raw message

Signature · 1 line
2.20.1
#7 lore raw

Re: [PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests

Quoted 3 lines · Mark Brown

Integrate the FP tests with the build system and add some documentation for the ones run outside the kselftest infrastructure. The content in the README was largely written by Dave Martin with edits by me.

Apologies, I never got around to looking at all this, though it seems reasonable.

I don't know whether this is worth following up with a TODO?

Some things I was aware of:

* The sve-test/fpsimd-test programs contain a lot of common boilerplate and could probably be merged together.

* A fair amount of the asm in sve-test/fpsimd-test could be converted to C, with -fgeneral-regs-only. This would be helpful since the code is highly unmaintainable in its current form (I know, I've tried). Calling library functions would still be a problem, but we might be able to lift a printf implementation and some basic syscall wrappers from elsewhere rather than reimplementing everything from scratch.

* The sve-stress/fpsimd-stress scripts could likewise be merged. Also, doing the required process management from the shell seems a doomed enterprise and it never really worked 100% right. Eventually it might be worth rewriting a common test driver for these in a real language.

* While the tests confirm that basic aspects of the SVE support don't explode, there is not a lot of checking that the kernel does the _correct_ thing -- so there's scope for improvement here if somebody gets around to it.

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#8 lore raw

Re: [PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests

Quoted 3 lines · Dave Martin

I don't know whether this is worth following up with a TODO?

Some things I was aware of:

Well volunteered :P

Quoted 10 lines

* The sve-test/fpsimd-test programs contain a lot of common boilerplate and could probably be merged together.

* A fair amount of the asm in sve-test/fpsimd-test could be converted to C, with -fgeneral-regs-only. This would be helpful since the code is highly unmaintainable in its current form (I know, I've tried). Calling library functions would still be a problem, but we might be able to lift a printf implementation and some basic syscall wrappers from elsewhere rather than reimplementing everything from scratch.

Or just keep the existing asm for the syscall/print wrappers.

Quoted 10 lines

* The sve-stress/fpsimd-stress scripts could likewise be merged. Also, doing the required process management from the shell seems a doomed enterprise and it never really worked 100% right. Eventually it might be worth rewriting a common test driver for these in a real language.

* While the tests confirm that basic aspects of the SVE support don't explode, there is not a lot of checking that the kernel does the _correct_ thing -- so there's scope for improvement here if somebody gets around to it.

Yeah, more errors get trapped by the kernel's own internal checking than by the tests themselves.

#9 lore raw

Re: [PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests

Quoted 27 lines · Mark Brown
Quoted 3 lines · Dave Martin

I don't know whether this is worth following up with a TODO?

Some things I was aware of:

Well volunteered :P

Quoted 10 lines

* The sve-test/fpsimd-test programs contain a lot of common boilerplate and could probably be merged together.

* A fair amount of the asm in sve-test/fpsimd-test could be converted to C, with -fgeneral-regs-only. This would be helpful since the code is highly unmaintainable in its current form (I know, I've tried). Calling library functions would still be a problem, but we might be able to lift a printf implementation and some basic syscall wrappers from elsewhere rather than reimplementing everything from scratch.

Or just keep the existing asm for the syscall/print wrappers.

Quoted 5 lines

* The sve-stress/fpsimd-stress scripts could likewise be merged. Also, doing the required process management from the shell seems a doomed enterprise and it never really worked 100% right. Eventually it might be worth rewriting a common test driver for these in a real language.

Quoted 7 lines
Quoted 4 lines

* While the tests confirm that basic aspects of the SVE support don't explode, there is not a lot of checking that the kernel does the _correct_ thing -- so there's scope for improvement here if somebody gets around to it.

Yeah, more errors get trapped by the kernel's own internal checking than by the tests themselves.

OK, I can follow up with a patch so long as these points sounds reasonable to you. Either way, it's not urgent.

Cheers
---Dave

maintainer Acked-by on the v2 series
#10 lore raw
In reply to Mark Brown
Quoted 37 lines · Mark Brown

This series imports a series of tests for FPSIMD and SVE originally written by Dave Martin to the tree. Since these extensions have some overlap in terms of register usage and must sometimes be tested together they're dropped into a single directory. I've adapted some of the tests to run within the kselftest framework but there are also some stress tests here that are intended to be run as soak tests so aren't suitable for running by default and are mostly just integrated with the build system. There doesn't seem to be a more suitable home for those stress tests and they are very useful for work on these areas of the code so it seems useful to have them somewhere in tree.

v2: Rebased onto v5.9-rc1

Mark Brown (6):
selftests: arm64: Test case for enumeration of SVE vector lengths
selftests: arm64: Add test for the SVE ptrace interface
selftests: arm64: Add stress tests for FPSMID and SVE context
switching
selftests: arm64: Add utility to set SVE vector lengths
selftests: arm64: Add wrapper scripts for stress tests
selftests: arm64: Add build and documentation for FP tests

  tools/testing/selftests/arm64/Makefile        |   2 +-
  tools/testing/selftests/arm64/fp/.gitignore   |   5 +
  tools/testing/selftests/arm64/fp/Makefile     |  17 +
  tools/testing/selftests/arm64/fp/README       | 100 +++
  .../testing/selftests/arm64/fp/asm-offsets.h  |  11 +
  tools/testing/selftests/arm64/fp/assembler.h  |  57 ++
  .../testing/selftests/arm64/fp/fpsimd-stress  |  60 ++
  .../testing/selftests/arm64/fp/fpsimd-test.S  | 482 +++++++++++++
  .../selftests/arm64/fp/sve-probe-vls.c        |  58 ++
  .../selftests/arm64/fp/sve-ptrace-asm.S       |  33 +
  tools/testing/selftests/arm64/fp/sve-ptrace.c | 336 +++++++++
  tools/testing/selftests/arm64/fp/sve-stress   |  59 ++
  tools/testing/selftests/arm64/fp/sve-test.S   | 672 ++++++++++++++++++
  tools/testing/selftests/arm64/fp/vlset.c      | 155 ++++
  14 files changed, 2046 insertions(+), 1 deletion(-)
Quoted 14 lines

create mode 100644 tools/testing/selftests/arm64/fp/.gitignore create mode 100644 tools/testing/selftests/arm64/fp/Makefile create mode 100644 tools/testing/selftests/arm64/fp/README create mode 100644 tools/testing/selftests/arm64/fp/asm-offsets.h create mode 100644 tools/testing/selftests/arm64/fp/assembler.h create mode 100755 tools/testing/selftests/arm64/fp/fpsimd-stress create mode 100644 tools/testing/selftests/arm64/fp/fpsimd-test.S create mode 100644 tools/testing/selftests/arm64/fp/sve-probe-vls.c create mode 100644 tools/testing/selftests/arm64/fp/sve-ptrace-asm.S create mode 100644 tools/testing/selftests/arm64/fp/sve-ptrace.c create mode 100755 tools/testing/selftests/arm64/fp/sve-stress create mode 100644 tools/testing/selftests/arm64/fp/sve-test.S create mode 100644 tools/testing/selftests/arm64/fp/vlset.c

Will,

Patches look good to me from selftests perspective. My acked by for these patches to go through arm64.

If you would like me to take these through kselftest tree, give me your Acks. I can queue these up for 5.10-rc1

thanks,
-- Shuah

maintainer
#11 lore raw
Quoted 23 lines · Shuah Khan
Quoted 13 lines · Mark Brown

This series imports a series of tests for FPSIMD and SVE originally written by Dave Martin to the tree. Since these extensions have some overlap in terms of register usage and must sometimes be tested together they're dropped into a single directory. I've adapted some of the tests to run within the kselftest framework but there are also some stress tests here that are intended to be run as soak tests so aren't suitable for running by default and are mostly just integrated with the build system. There doesn't seem to be a more suitable home for those stress tests and they are very useful for work on these areas of the code so it seems useful to have them somewhere in tree.

v2: Rebased onto v5.9-rc1

Quoted 8 lines

Mark Brown (6):
selftests: arm64: Test case for enumeration of SVE vector lengths
selftests: arm64: Add test for the SVE ptrace interface
selftests: arm64: Add stress tests for FPSMID and SVE context
switching
selftests: arm64: Add utility to set SVE vector lengths
selftests: arm64: Add wrapper scripts for stress tests
selftests: arm64: Add build and documentation for FP tests

Quoted 4 lines

Patches look good to me from selftests perspective. My acked by for these patches to go through arm64.

Thanks, Shuah.

Quoted 2 lines

If you would like me to take these through kselftest tree, give me your Acks. I can queue these up for 5.10-rc1

Given there are a few arm64 kselftests series pending at the moment, I'll queue them in the arm64 tree, but on their own branch in case you end up needing to pull it in as well. I'll drop you a note once I've done that (I'm just starting to queue stuff this week).

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Acked-by
#12 lore raw
Quoted 34 lines · Will Deacon
Quoted 23 lines · Shuah Khan
Quoted 13 lines · Mark Brown

This series imports a series of tests for FPSIMD and SVE originally written by Dave Martin to the tree. Since these extensions have some overlap in terms of register usage and must sometimes be tested together they're dropped into a single directory. I've adapted some of the tests to run within the kselftest framework but there are also some stress tests here that are intended to be run as soak tests so aren't suitable for running by default and are mostly just integrated with the build system. There doesn't seem to be a more suitable home for those stress tests and they are very useful for work on these areas of the code so it seems useful to have them somewhere in tree.

v2: Rebased onto v5.9-rc1

Quoted 8 lines

Mark Brown (6):
selftests: arm64: Test case for enumeration of SVE vector lengths
selftests: arm64: Add test for the SVE ptrace interface
selftests: arm64: Add stress tests for FPSMID and SVE context
switching
selftests: arm64: Add utility to set SVE vector lengths
selftests: arm64: Add wrapper scripts for stress tests
selftests: arm64: Add build and documentation for FP tests

Quoted 4 lines

Patches look good to me from selftests perspective. My acked by for these patches to go through arm64.

Thanks, Shuah.

Quoted 2 lines

If you would like me to take these through kselftest tree, give me your Acks. I can queue these up for 5.10-rc1

Quoted 6 lines

Given there are a few arm64 kselftests series pending at the moment, I'll queue them in the arm64 tree, but on their own branch in case you end up needing to pull it in as well. I'll drop you a note once I've done that (I'm just starting to queue stuff this week).

Will

FWIW,

I haven't gone through the integration in detail, but nothing leaps out as disastrously wrong.

I'm not sure how useful these tests are to people in general, but they've been valuable for maintaining the FP context switch code on arm64. I think it makes sense to keep them alongside the kernel so that they don't get get lost.

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#13 lore raw
In reply to Mark Brown
Quoted 11 lines · Mark Brown

This series imports a series of tests for FPSIMD and SVE originally written by Dave Martin to the tree. Since these extensions have some overlap in terms of register usage and must sometimes be tested together they're dropped into a single directory. I've adapted some of the tests to run within the kselftest framework but there are also some stress tests here that are intended to be run as soak tests so aren't suitable for running by default and are mostly just integrated with the build system. There doesn't seem to be a more suitable home for those stress tests and they are very useful for work on these areas of the code so it seems useful to have them somewhere in tree.

Quoted 1 line

[...]

Applied to arm64 (for-next/selftests), thanks!

[1/6] selftests: arm64: Test case for enumeration of SVE vector lengths

      https://git.kernel.org/arm64/c/ca765153eb90
[2/6] selftests: arm64: Add test for the SVE ptrace interface
      https://git.kernel.org/arm64/c/0dca276ac4d2
[3/6] selftests: arm64: Add stress tests for FPSMID and SVE context switching
      https://git.kernel.org/arm64/c/5e992c638ea5
[4/6] selftests: arm64: Add utility to set SVE vector lengths
      https://git.kernel.org/arm64/c/fc7e611f9f38
[5/6] selftests: arm64: Add wrapper scripts for stress tests
      https://git.kernel.org/arm64/c/25f47e3eb66e
[6/6] selftests: arm64: Add build and documentation for FP tests
      https://git.kernel.org/arm64/c/e093256d14fb

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev