Skip to contentSkip to conversation

insane: improve gnu-hash-style warning

PATCH New Ross Burton 1 participant 2 messages Sep 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 insane: improve gnu-hash-style warning

Instead of showing a filename under packages-split, show the package name and filename inside the package.

---
 meta/classes/insane.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +2 -1
index c32bf25124..d7f8f919c3 100644
@@ -443,7 +443,8 @@ def package_qa_hash_style(path, name, d, elf, messages):
         if ("[mips32]" in line or "[mips64]" in line) and d.getVar('TCLIBC') == "musl":
             sane = True
     if has_syms and not sane:
-        package_qa_add_message(messages, "ldflags", "No GNU_HASH in the ELF binary %s, didn't pass LDFLAGS?" % path)
+        path = package_qa_clean_path(path, d, name)
+        package_qa_add_message(messages, "ldflags", "File %s in package %s doesn't have GNU_HASH (didn't pass LDFLAGS?)" % (path, name))
 
 
 QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 elfutils: silence a new QA warning

The fix to the gnu-hash-style check (oe-core 70d932f21) causes elfutils-ptest to emit a new warning. This binary is explicitly compiled with a curated minimal set of compiler flags, so to avoid breaking the test simply skip the ldflags check for elfutils-ptest.

---
 meta/recipes-devtools/elfutils/elfutils_0.180.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/elfutils/elfutils_0.180.bb +2 -0
index d3ee750725..ada4ddd179 100644
@@ -115,6 +115,8 @@ FILES_libdw  = "${libdir}/libdw-${PV}.so ${libdir}/libdw.so.* ${libdir}/elfutils
 
 # The package contains symlinks that trip up insane
 INSANE_SKIP_${MLPREFIX}libdw = "dev-so"
+# The nlist binary in the tests uses explicitly minimal compiler flags
+INSANE_SKIP_${PN}-ptest += "ldflags"
 
 # avoid stripping some generated binaries otherwise some of the tests such as test-nlist,
 # run-strip-reloc.sh, run-strip-strmerge.sh and so on will fail
Signature · 1 line
2.25.1