usb: serial: option: Fix the lackage for Quectel EG95 LTE modem support
Subsystems (2)
PATCH v2 1/1 usb: serial: option: Fix the lackage for Quectel EG95 LTE modem support
* Add reset-resume callback for resetting USB devices after MCU exits from suspend/sleep mode.
* Add zero packet support
Fixes da6902e5b6db ("USB: serial: option: add Quectel EG95 LTE modem"
Signed-off-by William Sung <[email protected]>
---
v2: * Add ZLP support
* Remove redundant code for reserving interface number 4
drivers/usb/serial/option.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +2 -1
@@ -1099,7 +1099,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25), .driver_info = RSVD(4) }, { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG95), - .driver_info = RSVD(4) }, + .driver_info = RSVD(4) | ZLP }, { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96), .driver_info = RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06, 0xff, 0xff, 0xff),
@@ -2069,6 +2069,7 @@ static struct usb_serial_driver option_1port_device = {#ifdef CONFIG_PM .suspend = usb_wwan_suspend, .resume = usb_wwan_resume, + .reset_resume = usb_wwan_resume,#endif };
Signature · 1 line
2.17.1
Johan Hovold
maintainerQuoted 2 lines · William Sung
* Add reset-resume callback for resetting USB devices after MCU exits from suspend/sleep mode.
Looks like both your patches try to do this. Again, one logical change per patch, please.
Quoted 27 lines
* Add zero packet support
Fixes da6902e5b6db ("USB: serial: option: add Quectel EG95 LTE modem"Signed-off-by William Sung <[email protected]>---
v2: * Add ZLP support
* Remove redundant code for reserving interface number 4drivers/usb/serial/option.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/usb/serial/option.c +1
-1@@ -1099,7 +1099,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25), .driver_info = RSVD(4) }, { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG95), - .driver_info = RSVD(4) }, + .driver_info = RSVD(4) | ZLP }, { USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_BG96), .driver_info = RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EP06, 0xff, 0xff, 0xff),
drivers/usb/serial/option.c static struct usb_serial_driver option_1port_device = { · line 2074
Quoted 6 lines
drivers/usb/serial/option.c +1
-0@@ -2069,6 +2069,7 @@ static struct usb_serial_driver option_1port_device = {#ifdef CONFIG_PM .suspend = usb_wwan_suspend, .resume = usb_wwan_resume, + .reset_resume = usb_wwan_resume,#endif };
Johan