Patches to make multicast proccesing on CDC NCM drivers
Hi,
Miguel Rodríguez sent this set of patches two years ago to fix the lack of multicast processing on CDC NCM driver:
https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.html
I've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000 docking station. IPv6 connectivity is broken without them.
Is there any chance to consider those patches (or what would be needed to make it happen)?
It would be great to have them upstream!
See also: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1779173
Best regards,
-- Santiago
Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano Rincón:
Quoted 10 lines
Hi,
Miguel Rodríguez sent this set of patches two years ago to fix the lack of multicast processing on CDC NCM driver:
https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.html
Quoted 8 lines
I've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000 docking station. IPv6 connectivity is broken without them.Is there any chance to consider those patches (or what would be needed to make it happen)?
It would be great to have them upstream!
Hi,
they have been merged on Wednesday.
HTH
Oliver
Quoted 17 lines · Oliver Neukum
Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano Rincón:
Quoted 15 lines
Hi,
Miguel Rodríguez sent this set of patches two years ago to fix the lack of multicast processing on CDC NCM driver:
https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.htmlI've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000 docking station. IPv6 connectivity is broken without them.
Quoted 7 lines
Quoted 3 lines
Is there any chance to consider those patches (or what would be needed to make it happen)?
It would be great to have them upstream!Hi,
they have been merged on Wednesday.
…
Great, thanks!
It would be possible to apply/backport Miguel's patches (along with 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
FWIW, in the context of Debian, I'm personally interested in 4.19.y.
Best regards,
-- Santiago
Greg KH
maintainerQuoted 24 lines · Santiago Ruano Rincón
Quoted 23 lines · Oliver Neukum
Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano Rincón:
Quoted 10 lines
Hi,
Miguel Rodríguez sent this set of patches two years ago to fix the lack of multicast processing on CDC NCM driver:
https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.htmlQuoted 8 lines
I've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000 docking station. IPv6 connectivity is broken without them.Is there any chance to consider those patches (or what would be needed to make it happen)?
It would be great to have them upstream!Hi,
Quoted 7 lines
Quoted 1 line
they have been merged on Wednesday.
…
Great, thanks!
It would be possible to apply/backport Miguel's patches (along with
5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
I don't see that git commit id in Linus's tree, are you sure it is correct?
Quoted 1 line
FWIW, in the context of Debian, I'm personally interested in 4.19.y.
What specific list of commits are you wanting to see backported?
thanks,
greg k-h
Quoted 28 lines · Greg KH
Quoted 27 lines · Santiago Ruano Rincón
Quoted 24 lines · Oliver Neukum
Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano Rincón:
Quoted 10 lines
Hi,
Miguel Rodríguez sent this set of patches two years ago to fix the lack of multicast processing on CDC NCM driver:
https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.htmlQuoted 8 lines
I've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000 docking station. IPv6 connectivity is broken without them.Is there any chance to consider those patches (or what would be needed to make it happen)?
It would be great to have them upstream!Hi,
they have been merged on Wednesday.
…
Quoted 7 lines
Quoted 4 lines
Great, thanks!
It would be possible to apply/backport Miguel's patches (along with
5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?I don't see that git commit id in Linus's tree, are you sure it is correct?
I should had mention it is found in linux-next, sorry. Please see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10
Quoted 3 lines
Quoted 1 line
FWIW, in the context of Debian, I'm personally interested in 4.19.y.
What specific list of commits are you wanting to see backported?
This:
37a2ebdd9e597ae1a0270ac747883ea8f6f767b6e10dcb1b6ba714243ad5a35a11b91cc14103a9a9e506addeff844237d60545ef4f6141de21471caf0226009ce0f6089f9b31211f7a2703cf9a327a01
Thanks,
-- santiago
Greg KH
maintainerQuoted 31 lines · Santiago Ruano Rincón
Quoted 30 lines · Greg KH
Quoted 29 lines · Santiago Ruano Rincón
Quoted 17 lines · Oliver Neukum
Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano Rincón:
Quoted 15 lines
Hi,
Miguel Rodríguez sent this set of patches two years ago to fix the lack of multicast processing on CDC NCM driver:
https://www.spinics.net/lists/linux-usb/msg170611.html
https://www.spinics.net/lists/linux-usb/msg170603.html
https://www.spinics.net/lists/linux-usb/msg170567.html
https://www.spinics.net/lists/linux-usb/msg170568.htmlI've using a DKMS version of them, available in
https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
since more than a year ago, and they are working fine with my Dell D6000 docking station. IPv6 connectivity is broken without them.Quoted 7 lines
Quoted 3 lines
Is there any chance to consider those patches (or what would be needed to make it happen)?
It would be great to have them upstream!Hi,
they have been merged on Wednesday.
…
Great, thanks!
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
It would be possible to apply/backport Miguel's patches (along with
5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?I don't see that git commit id in Linus's tree, are you sure it is correct?
I should had mention it is found in linux-next, sorry. Please see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10
Ah, nothing I can do with patches that are not yet in Linus's tree.
Quoted 10 lines
Quoted 3 lines
Quoted 1 line
FWIW, in the context of Debian, I'm personally interested in 4.19.y.
What specific list of commits are you wanting to see backported?
This:
37a2ebdd9e597ae1a0270ac747883ea8f6f767b6e10dcb1b6ba714243ad5a35a11b91cc14103a9a9e506addeff844237d60545ef4f6141de21471caf0226009ce0f6089f9b31211f7a2703cf9a327a01
These do not look like bugfixes, but a new feature being added for this driver. So why not just use a newer kernel version for this feature?
thanks,
greg k-h
Quoted 6 lines · Greg KH
Quoted 5 lines · Santiago Ruano Rincón
Quoted 4 lines · Greg KH
Quoted 3 lines · Santiago Ruano Rincón
Quoted 2 lines · Oliver Neukum
Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano Rincón:
…
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
It would be possible to apply/backport Miguel's patches (along with
5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I don't see that git commit id in Linus's tree, are you sure it is correct?
I should had mention it is found in linux-next, sorry. Please see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10Ah, nothing I can do with patches that are not yet in Linus's tree.
ACK.
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
FWIW, in the context of Debian, I'm personally interested in 4.19.y.
What specific list of commits are you wanting to see backported?
This:
Quoted 7 lines
Quoted 4 lines
37a2ebdd9e597ae1a0270ac747883ea8f6f767b6e10dcb1b6ba714243ad5a35a11b91cc14103a9a9e506addeff844237d60545ef4f6141de21471caf0226009ce0f6089f9b31211f7a2703cf9a327a01These do not look like bugfixes, but a new feature being added for this driver. So why not just use a newer kernel version for this feature?
From my point of view as user these are bugfixes, since IPv6 NDP or any other protocol relying on multicast do not work without them. In other words, my computer's networking is broken.
I want to have them in linux stable releases because that would make easier to include them in Debian stable release.
Thanks!
-- Santiago
A message that is not in the archive (sent off-list or not yet received): 159483131513.13666.11657009071338024929.reportbug@kirby
A message that is not in the archive (sent off-list or not yet received): 20200903075037.GD242939__2852.23647240258$1599119665$gmane$org@bartik
Re: Bug#965074: Patches to make multicast proccesing on CDC NCM drivers
Quoted 10 lines · Santiago Ruano Rincón
Quoted 9 lines · Greg KH
Quoted 6 lines · Santiago Ruano Rincón
This:
37a2ebdd9e597ae1a0270ac747883ea8f6f767b6e10dcb1b6ba714243ad5a35a11b91cc14103a9a9e506addeff844237d60545ef4f6141de21471caf0226009ce0f6089f9b31211f7a2703cf9a327a01
Quoted 6 lines
Quoted 2 lines
These do not look like bugfixes, but a new feature being added for this driver. So why not just use a newer kernel version for this feature?
From my point of view as user these are bugfixes, since IPv6 NDP or any other protocol relying on multicast do not work without them. In other words, my computer's networking is broken.
I was in doubt when I submitted these, but ended up specfying net-next instead of net+stable as the target for a reason. This is a new feature as Greg says. Even if the feature is essential for your use case, it is still new. "Has never been supported" isn't really a bug.
And I am still convinced that my decision was correct. The patches are a bit more intrusive than I'd be comfortable submitting to stable, as was demonstrated by the stupid build bug I added... Fixed by commit 5fd99b5d9950 ("net: cdc_ncm: Fix build error") BTW.
Quoted 2 lines
I want to have them in linux stable releases because that would make easier to include them in Debian stable release.
This has not been an absolute requirement in the past. Distros tend to have a more relaxed stable policy.
Using a newer kernel until Debian moves on is obviously also an option.
Bjørn