memory: tegra: Remove GPU from DRM IOMMU group
Subsystems (2)
PATCH 1/1 memory: tegra: Remove GPU from DRM IOMMU group
From: Thierry Reding <[email protected]>
Commit 63a613fdb16c ("memory: tegra: Add gr2d and gr3d to DRM IOMMU group") added the GPU to the DRM IOMMU group, which doesn't make any sense. This causes problems when Nouveau tries to attach to the SMMU and causes it to fall back to using the DMA API.
Remove the GPU from the DRM groups to restore the old behaviour. The GPU should always have its own IOMMU domain to make sure it can map buffers into contiguous chunks (for big page support) without getting in the way of mappings from the DRM group.
--- drivers/memory/tegra/tegra124.c | 1 - 1 file changed, 1 deletion(-)
drivers/memory/tegra/tegra124.c +0 -1
@@ -957,7 +957,6 @@ static const struct tegra_smmu_swgroup tegra124_swgroups[] = {static const unsigned int tegra124_group_drm[] = {TEGRA_SWGROUP_DC ,TEGRA_SWGROUP_DCB , -TEGRA_SWGROUP_GPU ,TEGRA_SWGROUP_VIC , };
Signature · 1 line
2.28.0
01.09.2020 18:32, Thierry Reding пишет:
Quoted 25 lines
From: Thierry Reding <[email protected]>
Commit
63a613fdb16c("memory: tegra: Add gr2d and gr3d to DRM IOMMU group") added the GPU to the DRM IOMMU group, which doesn't make any sense. This causes problems when Nouveau tries to attach to the SMMU and causes it to fall back to using the DMA API.Remove the GPU from the DRM groups to restore the old behaviour. The GPU should always have its own IOMMU domain to make sure it can map buffers into contiguous chunks (for big page support) without getting in the way of mappings from the DRM group.
Fixes 63a613fdb16c ("memory: tegra: Add gr2d and gr3d to DRM IOMMU group")Reported-by Matias Zuniga <[email protected]>Signed-off-by Thierry Reding <[email protected]>--- drivers/memory/tegra/tegra124.c | 1 - 1 file changed, 1 deletion(-)drivers/memory/tegra/tegra124.c +0
-0
drivers/memory/tegra/tegra124.c static const struct tegra_smmu_swgroup tegra124_swgroups[] = { · line 962
Quoted 7 lines
drivers/memory/tegra/tegra124.c +0
-1@@ -957,7 +957,6 @@ static const struct tegra_smmu_swgroup tegra124_swgroups[] = {static const unsigned int tegra124_group_drm[] = {TEGRA_SWGROUP_DC ,TEGRA_SWGROUP_DCB , -TEGRA_SWGROUP_GPU ,TEGRA_SWGROUP_VIC , };
Technically a stable tag is needed for this patch, but I guess the bot will recognize that this patch is useful for older kernels.
Otherwise looks good!
Quoted 12 lines · Thierry Reding
From: Thierry Reding <[email protected]>
Commit
63a613fdb16c("memory: tegra: Add gr2d and gr3d to DRM IOMMU group") added the GPU to the DRM IOMMU group, which doesn't make any sense. This causes problems when Nouveau tries to attach to the SMMU and causes it to fall back to using the DMA API.Remove the GPU from the DRM groups to restore the old behaviour. The GPU should always have its own IOMMU domain to make sure it can map buffers into contiguous chunks (for big page support) without getting in the way of mappings from the DRM group.
Quoted 5 lines
Fixes 63a613fdb16c ("memory: tegra: Add gr2d and gr3d to DRM IOMMU group")Reported-by Matias Zuniga <[email protected]>Signed-off-by Thierry Reding <[email protected]>--- drivers/memory/tegra/tegra124.c | 1 -
Thanks, applied.
Best regards,
Krzysztof