ARM: dts: exynos: Remove I2C9 samsung,i2c-slave-addr from Exynos5250 boards
Subsystems (2)
Krzysztof Kozlowski
maintainerPATCH v2 1/2 ARM: dts: exynos: Remove I2C9 samsung,i2c-slave-addr from Exynos5250 boards
The property samsung,i2c-slave-addr in I2C9 controller on Exynos5250 Arndale and SMDK5250 boards, is not actually needed. There is only one master on this bus. It's not clear why this property was added at first place.
---
Changes since v1:
1. New patch, Marek already tested the removal so I am adding his tag.
--- arch/arm/boot/dts/exynos5250-arndale.dts | 1 - arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 - 2 files changed, 2 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +0 -1
@@ -542,7 +542,6 @@ status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <40000>; - samsung,i2c-slave-addr = <0x38>; sata_phy_i2c: sata-phy@38 { compatible = "samsung,exynos-sataphy-i2c";
arch/arm/boot/dts/exynos5250-smdk5250.dts +0 -1
@@ -326,7 +326,6 @@ status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <40000>; - samsung,i2c-slave-addr = <0x38>; sata_phy_i2c: sata-phy@38 { compatible = "samsung,exynos-sataphy-i2c";
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH v2 2/2 ARM: dts: exynos: Silence SATA PHY warning in Exynos5250
The SATA PHY in Exynos5250 SoCs has two interfaces and two device nodes:
1. sata-phy@12170000
2. i2c-9/i2c@38
The first node represents the actual SATA PHY device with phy-cells.
The second represents an additional I2C interface, needed by the driver to communicate with the SATA PHY device. It is not a PHY-provider in the terms of dtschema so rename it to silence dtbs_check warning:
arch/arm/boot/dts/exynos5250-arndale.dt.yaml: sata-phy@38: '#phy-cells' is a required property
From schema: lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml
This second device node is also a property of SoC, not a board so move it there.
---
Changes since v1:
1. Move to Exynos5250
--- arch/arm/boot/dts/exynos5250-arndale.dts | 9 ++++----- arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 ++++----- arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ 3 files changed, 14 insertions(+), 10 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +4 -5
@@ -542,11 +542,6 @@ status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <40000>; - - sata_phy_i2c: sata-phy@38 { - compatible = "samsung,exynos-sataphy-i2c"; - reg = <0x38>; - }; }; &i2s0 {
@@ -618,6 +613,10 @@ samsung,exynos-sataphy-i2c-phandle = <&sata_phy_i2c>; }; +&sata_phy_i2c { + status = "okay"; +}; + &soc { /* * For unknown reasons HDMI-DDC does not work with Exynos I2C
arch/arm/boot/dts/exynos5250-smdk5250.dts +4 -5
@@ -326,11 +326,6 @@ status = "okay"; samsung,i2c-sda-delay = <100>; samsung,i2c-max-bus-freq = <40000>; - - sata_phy_i2c: sata-phy@38 { - compatible = "samsung,exynos-sataphy-i2c"; - reg = <0x38>; - }; }; &i2s0 {
@@ -382,6 +377,10 @@ samsung,exynos-sataphy-i2c-phandle = <&sata_phy_i2c>; }; +&sata_phy_i2c { + status = "okay"; +}; + &spi_1 { status = "okay"; cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>;
arch/arm/boot/dts/exynos5250.dtsi +6 -0
@@ -473,6 +473,12 @@ clocks = <&clock CLK_SATA_PHYI2C>; clock-names = "i2c"; status = "disabled"; + + sata_phy_i2c: sata-phy-i2c@38 { + compatible = "samsung,exynos-sataphy-i2c"; + reg = <0x38>; + status = "disabled"; + }; }; spi_0: spi@12d20000 {
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerQuoted 8 lines · Krzysztof Kozlowski
The property samsung,i2c-slave-addr in I2C9 controller on Exynos5250 Arndale and SMDK5250 boards, is not actually needed. There is only one master on this bus. It's not clear why this property was added at first place.
Tested-by Marek Szyprowski <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 6 lines
---
Changes since v1:
1. New patch, Marek already tested the removal so I am adding his tag.--- arch/arm/boot/dts/exynos5250-arndale.dts | 1 -
Applied both.
Best regards,
Krzysztof