Skip to contentSkip to conversation

usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

PATCH In review cy_huang 5 participants 25 messages Sep 2, 2020 – Oct 12, 2020

Subsystems (3)
lore
Share & tools
lore

cy_huang

author
#0 lore raw

PATCH 1/1 usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +1 -2
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
 		port->tcpc->set_bist_data(port->tcpc, false);
 	}
 
-	if (tcpm_port_is_disconnected(port))
-		port->hard_reset_count = 0;
+	port->hard_reset_count = 0;
 
 	tcpm_reset_port(port);
 }
Signature · 1 line
2.7.4
#1 lore raw
Quoted 32 lines · cy_huang

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 7 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
 		port->tcpc->set_bist_data(port->tcpc, false);
 	}
 
-	if (tcpm_port_is_disconnected(port))
-		port->hard_reset_count = 0;
+	port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

Guenter

Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +0 -0
 	tcpm_reset_port(port);
 }
Signature · 1 line
2.7.4
#2 lore raw

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

From my below case, it's A to C cable only. There is no USBPD contract will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 7 lines

Guenter

Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +0 -1
      tcpm_reset_port(port);
 }
--

2.7.4

#3 lore raw
Quoted 66 lines · ChiYuan Huang

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Guenter

Quoted 7 lines
Quoted 7 lines

Guenter

Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +0 -1
      tcpm_reset_port(port);
 }
--

2.7.4

#4 lore raw

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

This case you specified means locally error occurred. It intended to re-run the state machine from typec to USBPD. From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

Quoted 11 lines

Guenter

Quoted 7 lines
Quoted 7 lines

Guenter

Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +0 -1
      tcpm_reset_port(port);
 }
--

2.7.4

#5 lore raw
Quoted 86 lines · ChiYuan Huang

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Quoted 1 line

This case you specified means locally error occurred.

It could be a local error (with the local hardware), or with the remote partner not accepting the reset. We only know that an error occurred.

Quoted 7 lines

It intended to re-run the state machine from typec to USBPD.

Quoted 1 line

From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

The operational word is "normal". Error recovery is expected to handle situations which are not normal.

I don't question the need to reset the counter. The only question is where and when to reset it.

Guenter

#6 lore raw

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 下午11:51寫道:

Quoted 95 lines · ChiYuan Huang
Quoted 86 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Quoted 1 line

This case you specified means locally error occurred.

It could be a local error (with the local hardware), or with the remote partner not accepting the reset. We only know that an error occurred.

Quoted 1 line

It intended to re-run the state machine from typec to USBPD.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

The operational word is "normal". Error recovery is expected to handle situations which are not normal.

Following by the USBPD 3.0 revision 1.2, section 8.3.3.24.1 The ErrorRecovery state is used to electronically disconnect Port Partner using the USB Type-C connector.
And there's one sentence to be said "The ErrorRecovery staste shall map to USB Type-C Error Recovery state operations".
I also read ErrorRecovery state in USB TYPE-C 1.3 spec.
Section 4.5.2.2.2.1 ErrorRecovery state requirement listed the below text.
The port shall not drive VBUS or VCONN, and shall present a high-impedance to ground (above
zOPEN) on its CC1 and CC2 pins.
Section 4.5.2.2.2.2 Exiting from the error recovery state I read the description. The roughly meaning is to change the state to Unattached(Src or Snk) after tErrorRecovery.

Summary the above text.
Reset HardResetCounter is ok in tcpm_detach.
My patch is just to relax the counter reset conditions during tcpm_detach(). If not, it will check tcpm_port_is_disconnected().
And only two scenario, the hard reset count will be cleared to 0 at this case.
1) port not attached and cc1=open and cc2=open
2) port attached and either (polarity=cc1, cc1=open) or (polarity=cc2, cc2=open)

I think this judgement is narrow in tcpm_detach case.

Quoted 4 lines

I don't question the need to reset the counter. The only question is where and when to reset it.

I re-check all tcpm code for hard reset counter about the increment and reset. They all meets USBPD spec. Only the detach case, I'm wondering why it need to add the check for tcpm_port_is_disconnected().

Quoted 1 line

Guenter

#7 lore raw

Hi, Guenter:

ChiYuan Huang <[email protected]> 於 2020年9月6日 週日 下午11:22寫道:

Quoted 131 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 下午11:51寫道:

Quoted 95 lines · ChiYuan Huang
Quoted 86 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Quoted 1 line

This case you specified means locally error occurred.

It could be a local error (with the local hardware), or with the remote partner not accepting the reset. We only know that an error occurred.

Quoted 1 line

It intended to re-run the state machine from typec to USBPD.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

The operational word is "normal". Error recovery is expected to handle situations which are not normal.

Following by the USBPD 3.0 revision 1.2, section 8.3.3.24.1 The ErrorRecovery state is used to electronically disconnect Port Partner using the USB Type-C connector.
And there's one sentence to be said "The ErrorRecovery staste shall map to USB Type-C Error Recovery state operations".
I also read ErrorRecovery state in USB TYPE-C 1.3 spec.
Section 4.5.2.2.2.1 ErrorRecovery state requirement listed the below text.
The port shall not drive VBUS or VCONN, and shall present a high-impedance to ground (above
zOPEN) on its CC1 and CC2 pins.
Section 4.5.2.2.2.2 Exiting from the error recovery state I read the description. The roughly meaning is to change the state to Unattached(Src or Snk) after tErrorRecovery.

Summary the above text.
Reset HardResetCounter is ok in tcpm_detach.
My patch is just to relax the counter reset conditions during tcpm_detach(). If not, it will check tcpm_port_is_disconnected().
And only two scenario, the hard reset count will be cleared to 0 at this case.
1) port not attached and cc1=open and cc2=open
2) port attached and either (polarity=cc1, cc1=open) or (polarity=cc2, cc2=open)

I think this judgement is narrow in tcpm_detach case.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

I don't question the need to reset the counter. The only question is where and when to reset it.

I re-check all tcpm code for hard reset counter about the increment and reset. They all meets USBPD spec. Only the detach case, I'm wondering why it need to add the check for tcpm_port_is_disconnected().

Below's the real case log.

[ 4848.046358] VBUS off
[ 4848.046384] state change SNK_READY -> SNK_UNATTACHED
[ 4848.050908] Setting voltage/current limit 0 mV 0 mA
[ 4848.050936] polarity 0
[ 4848.052593] Requesting mux state 0, usb-role 0, orientation 0
[ 4848.053222] Start toggling
[ 4848.086500] state change SNK_UNATTACHED -> TOGGLING
[ 4848.089983] CC1: 0 -> 0, CC2: 3 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.089993] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.090031] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.141162] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.141170] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.141184] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.163156] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.163162] Start toggling
[ 4848.216918] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.216954] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.217080] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.231771] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.231800] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.231857] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.256022] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.256049] Start toggling
[ 4848.871148] VBUS on
[ 4848.885324] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.885372] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.885548] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4849.088240] state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED [delayed 200 ms]
[ 4849.088284] state change SNK_DEBOUNCED -> SNK_ATTACHED
[ 4849.088291] polarity 1
[ 4849.088769] Requesting mux state 1, usb-role 2, orientation 2
[ 4849.088895] state change SNK_ATTACHED -> SNK_STARTUP
[ 4849.088907] state change SNK_STARTUP -> SNK_DISCOVERY
[ 4849.088915] Setting voltage/current limit 5000 mV 0 mA
[ 4849.088927] vbus=0 charge:=1
[ 4849.090505] state change SNK_DISCOVERY -> SNK_WAIT_CAPABILITIES
[ 4849.090828] pending state change SNK_WAIT_CAPABILITIES -> SNK_READY @ 240 ms
[ 4849.335878] state change SNK_WAIT_CAPABILITIES -> SNK_READY [delayed 240 ms]

You can see the next type c attach log.
It directly change state from SNK_WAIT_CAPABILITIES to SNK_READY due to not reset hard_reset_count.

It's easy to reproduce if you plugout USB Adapater w/i AtoC cable connected.

Quoted 1 line
Quoted 1 line

Guenter

maintainer
#8 lore raw
Quoted 183 lines · ChiYuan Huang

Hi, Guenter:

ChiYuan Huang <[email protected]> 於 2020年9月6日 週日 下午11:22寫道:

Quoted 131 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 下午11:51寫道:

Quoted 95 lines · ChiYuan Huang
Quoted 86 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Quoted 1 line

This case you specified means locally error occurred.

It could be a local error (with the local hardware), or with the remote partner not accepting the reset. We only know that an error occurred.

Quoted 1 line

It intended to re-run the state machine from typec to USBPD.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

The operational word is "normal". Error recovery is expected to handle situations which are not normal.

Following by the USBPD 3.0 revision 1.2, section 8.3.3.24.1 The ErrorRecovery state is used to electronically disconnect Port Partner using the USB Type-C connector.
And there's one sentence to be said "The ErrorRecovery staste shall map to USB Type-C Error Recovery state operations".
I also read ErrorRecovery state in USB TYPE-C 1.3 spec.
Section 4.5.2.2.2.1 ErrorRecovery state requirement listed the below text.
The port shall not drive VBUS or VCONN, and shall present a high-impedance to ground (above
zOPEN) on its CC1 and CC2 pins.
Section 4.5.2.2.2.2 Exiting from the error recovery state I read the description. The roughly meaning is to change the state to Unattached(Src or Snk) after tErrorRecovery.

Summary the above text.
Reset HardResetCounter is ok in tcpm_detach.
My patch is just to relax the counter reset conditions during tcpm_detach(). If not, it will check tcpm_port_is_disconnected().
And only two scenario, the hard reset count will be cleared to 0 at this case.
1) port not attached and cc1=open and cc2=open
2) port attached and either (polarity=cc1, cc1=open) or (polarity=cc2, cc2=open)

I think this judgement is narrow in tcpm_detach case.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

I don't question the need to reset the counter. The only question is where and when to reset it.

I re-check all tcpm code for hard reset counter about the increment and reset. They all meets USBPD spec. Only the detach case, I'm wondering why it need to add the check for tcpm_port_is_disconnected().

Below's the real case log.

[ 4848.046358] VBUS off
[ 4848.046384] state change SNK_READY -> SNK_UNATTACHED
[ 4848.050908] Setting voltage/current limit 0 mV 0 mA
[ 4848.050936] polarity 0
[ 4848.052593] Requesting mux state 0, usb-role 0, orientation 0
[ 4848.053222] Start toggling
[ 4848.086500] state change SNK_UNATTACHED -> TOGGLING
[ 4848.089983] CC1: 0 -> 0, CC2: 3 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.089993] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.090031] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.141162] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.141170] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.141184] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.163156] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.163162] Start toggling
[ 4848.216918] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.216954] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.217080] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.231771] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.231800] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.231857] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.256022] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.256049] Start toggling
[ 4848.871148] VBUS on
[ 4848.885324] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.885372] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.885548] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4849.088240] state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED [delayed 200 ms]
[ 4849.088284] state change SNK_DEBOUNCED -> SNK_ATTACHED
[ 4849.088291] polarity 1
[ 4849.088769] Requesting mux state 1, usb-role 2, orientation 2
[ 4849.088895] state change SNK_ATTACHED -> SNK_STARTUP
[ 4849.088907] state change SNK_STARTUP -> SNK_DISCOVERY
[ 4849.088915] Setting voltage/current limit 5000 mV 0 mA
[ 4849.088927] vbus=0 charge:=1
[ 4849.090505] state change SNK_DISCOVERY -> SNK_WAIT_CAPABILITIES
[ 4849.090828] pending state change SNK_WAIT_CAPABILITIES -> SNK_READY @ 240 ms
[ 4849.335878] state change SNK_WAIT_CAPABILITIES -> SNK_READY [delayed 240 ms]
Quoted 5 lines

You can see the next type c attach log.
It directly change state from SNK_WAIT_CAPABILITIES to SNK_READY due to not reset hard_reset_count.

It's easy to reproduce if you plugout USB Adapater w/i AtoC cable connected.

What ever happened with this patch, is there still disagreement?

thanks,

greg k-h

#9 lore raw
Quoted 184 lines · Greg KH
Quoted 183 lines · ChiYuan Huang

Hi, Guenter:

ChiYuan Huang <[email protected]> 於 2020年9月6日 週日 下午11:22寫道:

Quoted 131 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 下午11:51寫道:

Quoted 95 lines · ChiYuan Huang
Quoted 86 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Quoted 1 line

This case you specified means locally error occurred.

It could be a local error (with the local hardware), or with the remote partner not accepting the reset. We only know that an error occurred.

Quoted 1 line

It intended to re-run the state machine from typec to USBPD.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

The operational word is "normal". Error recovery is expected to handle situations which are not normal.

Following by the USBPD 3.0 revision 1.2, section 8.3.3.24.1 The ErrorRecovery state is used to electronically disconnect Port Partner using the USB Type-C connector.
And there's one sentence to be said "The ErrorRecovery staste shall map to USB Type-C Error Recovery state operations".
I also read ErrorRecovery state in USB TYPE-C 1.3 spec.
Section 4.5.2.2.2.1 ErrorRecovery state requirement listed the below text.
The port shall not drive VBUS or VCONN, and shall present a high-impedance to ground (above
zOPEN) on its CC1 and CC2 pins.
Section 4.5.2.2.2.2 Exiting from the error recovery state I read the description. The roughly meaning is to change the state to Unattached(Src or Snk) after tErrorRecovery.

Summary the above text.
Reset HardResetCounter is ok in tcpm_detach.
My patch is just to relax the counter reset conditions during tcpm_detach(). If not, it will check tcpm_port_is_disconnected().
And only two scenario, the hard reset count will be cleared to 0 at this case.
1) port not attached and cc1=open and cc2=open
2) port attached and either (polarity=cc1, cc1=open) or (polarity=cc2, cc2=open)

I think this judgement is narrow in tcpm_detach case.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

I don't question the need to reset the counter. The only question is where and when to reset it.

I re-check all tcpm code for hard reset counter about the increment and reset. They all meets USBPD spec. Only the detach case, I'm wondering why it need to add the check for tcpm_port_is_disconnected().

Below's the real case log.

[ 4848.046358] VBUS off
[ 4848.046384] state change SNK_READY -> SNK_UNATTACHED
[ 4848.050908] Setting voltage/current limit 0 mV 0 mA
[ 4848.050936] polarity 0
[ 4848.052593] Requesting mux state 0, usb-role 0, orientation 0
[ 4848.053222] Start toggling
[ 4848.086500] state change SNK_UNATTACHED -> TOGGLING
[ 4848.089983] CC1: 0 -> 0, CC2: 3 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.089993] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.090031] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.141162] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.141170] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.141184] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.163156] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.163162] Start toggling
[ 4848.216918] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.216954] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.217080] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.231771] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.231800] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.231857] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.256022] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.256049] Start toggling
[ 4848.871148] VBUS on
[ 4848.885324] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.885372] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.885548] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4849.088240] state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED [delayed 200 ms]
[ 4849.088284] state change SNK_DEBOUNCED -> SNK_ATTACHED
[ 4849.088291] polarity 1
[ 4849.088769] Requesting mux state 1, usb-role 2, orientation 2
[ 4849.088895] state change SNK_ATTACHED -> SNK_STARTUP
[ 4849.088907] state change SNK_STARTUP -> SNK_DISCOVERY
[ 4849.088915] Setting voltage/current limit 5000 mV 0 mA
[ 4849.088927] vbus=0 charge:=1
[ 4849.090505] state change SNK_DISCOVERY -> SNK_WAIT_CAPABILITIES
[ 4849.090828] pending state change SNK_WAIT_CAPABILITIES -> SNK_READY @ 240 ms
[ 4849.335878] state change SNK_WAIT_CAPABILITIES -> SNK_READY [delayed 240 ms]
Quoted 8 lines
Quoted 5 lines

You can see the next type c attach log.
It directly change state from SNK_WAIT_CAPABILITIES to SNK_READY due to not reset hard_reset_count.

It's easy to reproduce if you plugout USB Adapater w/i AtoC cable connected.

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Guenter

maintainer
#10 lore raw
Quoted 191 lines · Guenter Roeck
Quoted 190 lines · Greg KH
Quoted 188 lines · ChiYuan Huang

Hi, Guenter:

ChiYuan Huang <[email protected]> 於 2020年9月6日 週日 下午11:22寫道:

Quoted 131 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 下午11:51寫道:

Quoted 95 lines · ChiYuan Huang
Quoted 86 lines

Guenter Roeck <[email protected]> 於 2020年9月5日 週六 上午3:41寫道:

Quoted 75 lines · ChiYuan Huang
Quoted 66 lines

Guenter Roeck <[email protected]> 於 2020年9月3日 週四 上午12:57寫道:

Quoted 37 lines · cy_huang
Quoted 35 lines

From: ChiYuan Huang <[email protected]>

Fix: If vbus event is before cc_event trigger, hard_reset_count won't bt reset for some case.

---
Below's the flow.

_tcpm_pd_vbus_off() -> run_state_machine to change state to SNK_UNATTACHED call tcpm_snk_detach() -> tcpm_snk_detach() -> tcpm_detach() tcpm_port_is_disconnected() will be called.
But port->attached is still true and port->cc1=open and port->cc2=open

It cause tcpm_port_is_disconnected return false, then hard_reset_count won't be reset. After that, tcpm_reset_port() is called.
port->attached become false.

After that, cc now trigger cc_change event, the hard_reset_count will be kept. Even tcpm_detach will be called, due to port->attached is false, tcpm_detach() will directly return.

CC_EVENT will only trigger drp toggling again.

---
 drivers/usb/typec/tcpm/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +0 -0
index a48e3f90..5c73e1d 100644
@@ -2797,8 +2797,7 @@ static void tcpm_detach(struct tcpm_port *port)
              port->tcpc->set_bist_data(port->tcpc, false);
      }
 
Quoted 8 lines

drivers/usb/typec/tcpm/tcpm.c static void tcpm_detach(struct tcpm_port *port) · line 2801

Quoted 4 lines
drivers/usb/typec/tcpm/tcpm.c +1 -2
-     if (tcpm_port_is_disconnected(port))
-             port->hard_reset_count = 0;
+     port->hard_reset_count = 0;
 

Doesn't that mean that the state machine will never enter error recovery ?

I think it does't affect the error recovery. All error recovery seems to check pd_capable flag.

Quoted 1 line

From my below case, it's A to C cable only. There is no USBPD contract

will be estabilished.

This case occurred following by the below test condition Cable -> A to C (default Rp bind to vbus) connected to PC.
1. first time plugged in the cable with PC
It will make HARD_RESET_COUNT to be equal 2
2. And then plug out. At that time HARD_RESET_COUNT is till 2.
3. next time plugged in again.
Due to hard_reset_count is still 2 , after wait_cap_timeout, the state eventually changed to SNK_READY.
But during the state transition, no hard_reset be sent.

Defined in the USBPD policy engine, typec transition to USBPD, all variables must be reset included hard_reset_count.
So it expected SNK must send hard_reset again.

Quoted 6 lines

The original code defined hard_reset_count must be reset only when tcpm_port_is_disconnected.

It doesn't make sense that it only occurred in some scenario. If tcpm_detach is called, hard_reset count must be reset also.

Quoted 9 lines

If a hard reset fails, the state machine may cycle through states HARD_RESET_SEND, HARD_RESET_START, SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON back to SRC_UNATTACHED. In this state, tcpm_src_detach() and with it tcpm_detach() is called. The hard reset counter is incremented in HARD_RESET_SEND. If tcpm_detach() resets the counter, the state machine will keep cycling through hard resets without ever entering the error recovery state. I am not entirely sure where the counter should be reset, but tcpm_detach() seems to be the wrong place.

Quoted 1 line

This case you specified means locally error occurred.

It could be a local error (with the local hardware), or with the remote partner not accepting the reset. We only know that an error occurred.

Quoted 1 line

It intended to re-run the state machine from typec to USBPD.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

From my understanding, hard_reset_count to be reset is reasonable.

The normal stare from the state transition you specified is HARD_RESET_SEND, HARD_RESET_START -> SRC_HARD_RESET_VBUS_OFF, SRC_HARD_RESET_VBUS_ON -> received VBUS_EVENT then go to SRC_STARTUP.

The operational word is "normal". Error recovery is expected to handle situations which are not normal.

Following by the USBPD 3.0 revision 1.2, section 8.3.3.24.1 The ErrorRecovery state is used to electronically disconnect Port Partner using the USB Type-C connector.
And there's one sentence to be said "The ErrorRecovery staste shall map to USB Type-C Error Recovery state operations".
I also read ErrorRecovery state in USB TYPE-C 1.3 spec.
Section 4.5.2.2.2.1 ErrorRecovery state requirement listed the below text.
The port shall not drive VBUS or VCONN, and shall present a high-impedance to ground (above
zOPEN) on its CC1 and CC2 pins.
Section 4.5.2.2.2.2 Exiting from the error recovery state I read the description. The roughly meaning is to change the state to Unattached(Src or Snk) after tErrorRecovery.

Summary the above text.
Reset HardResetCounter is ok in tcpm_detach.
My patch is just to relax the counter reset conditions during tcpm_detach(). If not, it will check tcpm_port_is_disconnected().
And only two scenario, the hard reset count will be cleared to 0 at this case.
1) port not attached and cc1=open and cc2=open
2) port attached and either (polarity=cc1, cc1=open) or (polarity=cc2, cc2=open)

I think this judgement is narrow in tcpm_detach case.

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

I don't question the need to reset the counter. The only question is where and when to reset it.

I re-check all tcpm code for hard reset counter about the increment and reset. They all meets USBPD spec. Only the detach case, I'm wondering why it need to add the check for tcpm_port_is_disconnected().

Below's the real case log.

[ 4848.046358] VBUS off
[ 4848.046384] state change SNK_READY -> SNK_UNATTACHED
[ 4848.050908] Setting voltage/current limit 0 mV 0 mA
[ 4848.050936] polarity 0
[ 4848.052593] Requesting mux state 0, usb-role 0, orientation 0
[ 4848.053222] Start toggling
[ 4848.086500] state change SNK_UNATTACHED -> TOGGLING
[ 4848.089983] CC1: 0 -> 0, CC2: 3 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.089993] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.090031] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.141162] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.141170] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.141184] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.163156] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.163162] Start toggling
[ 4848.216918] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.216954] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.217080] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4848.231771] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_ATTACH_WAIT,
polarity 0, disconnected]
[ 4848.231800] state change SNK_ATTACH_WAIT -> SNK_ATTACH_WAIT
[ 4848.231857] pending state change SNK_ATTACH_WAIT -> SNK_UNATTACHED @ 20 ms
[ 4848.256022] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [delayed 20 ms]
[ 4848.256049] Start toggling
[ 4848.871148] VBUS on
[ 4848.885324] CC1: 0 -> 0, CC2: 0 -> 3 [state TOGGLING, polarity 0, connected]
[ 4848.885372] state change TOGGLING -> SNK_ATTACH_WAIT
[ 4848.885548] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 200 ms
[ 4849.088240] state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED [delayed 200 ms]
[ 4849.088284] state change SNK_DEBOUNCED -> SNK_ATTACHED
[ 4849.088291] polarity 1
[ 4849.088769] Requesting mux state 1, usb-role 2, orientation 2
[ 4849.088895] state change SNK_ATTACHED -> SNK_STARTUP
[ 4849.088907] state change SNK_STARTUP -> SNK_DISCOVERY
[ 4849.088915] Setting voltage/current limit 5000 mV 0 mA
[ 4849.088927] vbus=0 charge:=1
[ 4849.090505] state change SNK_DISCOVERY -> SNK_WAIT_CAPABILITIES
[ 4849.090828] pending state change SNK_WAIT_CAPABILITIES -> SNK_READY @ 240 ms
[ 4849.335878] state change SNK_WAIT_CAPABILITIES -> SNK_READY [delayed 240 ms]

You can see the next type c attach log.
It directly change state from SNK_WAIT_CAPABILITIES to SNK_READY due to not reset hard_reset_count.

It's easy to reproduce if you plugout USB Adapater w/i AtoC cable connected.

Quoted 7 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

thanks,

greg k-h

#11 lore raw

On 10/5/20 4:08 AM, Greg KH wrote:
[ ... ]

Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something like:

- if (tcpm_port_is_disconnected(port))
+ if (tcpm_port_is_disconnected(port) ||
+ (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

Guenter

#12 lore raw

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30寫道:

Quoted 21 lines · Greg KH

[ ... ]

Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something like:

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))
Quoted 1 line

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

- if (tcpm_port_is_disconnected(port))
+ if (tcpm_port_is_disconnected(port) || !port->vbus_present)

The hard_reset_count not reset issue is following by the below order
1. VBUS off ( at the same time, cc is still detected as attached) port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

And that's why hard_reset_count is not reset to 0.

Quoted 2 lines

Guenter

#13 lore raw
Quoted 31 lines · ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38写道:

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30寫道:

Quoted 21 lines · Greg KH

[ ... ]

Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something like:

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))
Quoted 1 line

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +1 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) || !port->vbus_present)
Quoted 5 lines

The hard_reset_count not reset issue is following by the below order
1. VBUS off ( at the same time, cc is still detected as attached) port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

I am seeing the same issue on my platform, the proposed change:
- if (tcpm_port_is_disconnected(port))
- port->hard_reset_count = 0;
+ port->hard_reset_count = 0;
can't resolve it on my platform.

How about reset hard_reset_count in SNK_READY?
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct tcpm_port *port)

        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

Li Jun

Quoted 4 lines

And that's why hard_reset_count is not reset to 0.

Quoted 2 lines

Guenter

#14 lore raw

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫道:

Quoted 33 lines
Quoted 31 lines · ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38写道:

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30寫道:

Quoted 21 lines · Greg KH

[ ... ]

Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something like:

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))
Quoted 1 line

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +1 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) || !port->vbus_present)
Quoted 9 lines
Quoted 5 lines

The hard_reset_count not reset issue is following by the below order
1. VBUS off ( at the same time, cc is still detected as attached) port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Quoted 11 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +1 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct tcpm_port *port)
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when
1. At src state, pe_src_send_cap and receive GoodCRC
2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

Quoted 6 lines

Li Jun

Quoted 4 lines

And that's why hard_reset_count is not reset to 0.

Quoted 2 lines

Guenter

#15 lore raw

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39寫道:

Quoted 67 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫道:

Quoted 33 lines
Quoted 31 lines · ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38写道:

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30寫道:

Quoted 21 lines · Greg KH

[ ... ]

Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another problem. Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it is.

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something like:

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))
Quoted 1 line

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +1 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) || !port->vbus_present)
Quoted 9 lines
Quoted 5 lines

The hard_reset_count not reset issue is following by the below order
1. VBUS off ( at the same time, cc is still detected as attached) port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Quoted 10 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +1 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct tcpm_port *port)
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);
Quoted 9 lines
Quoted 1 line

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when
1. At src state, pe_src_send_cap and receive GoodCRC
2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below. 200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario. From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

This case is hard to reproduce. But actually it's possible.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter

#16 lore raw
Quoted 78 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 6:13 PM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39寫道:

Quoted 4 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫道:

Quoted 2 lines

ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38写

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30

寫道:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Greg KH

[ ... ]

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open

another problem.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if

it is.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 36 lines
Quoted 22 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+ !port->vbus_present)
Quoted 6 lines

The hard_reset_count not reset issue is following by the below order 1. VBUS off ( at the same time, cc is still detected as attached)
port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

Quoted 18 lines
Quoted 4 lines

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Review static void run_state_machine(struct tcpm_port

Quoted 2 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct tcpm_port

*port)

Quoted 13 lines
Quoted 9 lines
(quoted diff) +1 -0
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when
1. At src state, pe_src_send_cap and receive GoodCRC 2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

3.
8.3.3.3.8 PE_SNK_Hard_Reset state
"Note: The HardResetCounter is reset on a power cycle or Detach."

Quoted 18 lines
Quoted 4 lines
Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below.
200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario.
From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

Quoted 1 line

This case is hard to reproduce. But actually it's possible.

Make sense.

Then I propose doing this at SNK_UNATTACHED
@@ -3156,6 +3156,7 @@ static void run_state_machine(struct tcpm_port *port)

                if (!port->non_pd_role_swap)
                        tcpm_swap_complete(port, -ENOTCONN);
                tcpm_pps_complete(port, -ENOTCONN);
+               port->hard_reset_count = 0;
                tcpm_snk_detach(port);
                if (tcpm_start_toggling(port, TYPEC_CC_RD)) {
                        tcpm_set_state(port, TOGGLING, 0);

Li Jun

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Guenter

#17 lore raw

Jun Li <[email protected]> 於 2020年10月9日 週五 下午2:12寫道:

Quoted 133 lines
Quoted 79 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 6:13 PM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39寫道:

Quoted 4 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫道:

Quoted 2 lines

ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38写

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30

寫道:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Greg KH

[ ... ]

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open

another problem.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if

it is.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 36 lines
Quoted 22 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+ !port->vbus_present)
Quoted 6 lines

The hard_reset_count not reset issue is following by the below order 1. VBUS off ( at the same time, cc is still detected as attached)
port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

Quoted 18 lines
Quoted 4 lines

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Review static void run_state_machine(struct tcpm_port

Quoted 2 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct tcpm_port

*port)

Quoted 13 lines
Quoted 9 lines
(quoted diff) +1 -0
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when
1. At src state, pe_src_send_cap and receive GoodCRC 2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

3.
8.3.3.3.8 PE_SNK_Hard_Reset state
"Note: The HardResetCounter is reset on a power cycle or Detach."

Quoted 18 lines
Quoted 4 lines
Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below.
200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario.
From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

Quoted 1 line

This case is hard to reproduce. But actually it's possible.

Make sense.

Then I propose doing this at SNK_UNATTACHED

(quoted diff) +1 -0
@@ -3156,6 +3156,7 @@ static void run_state_machine(struct tcpm_port *port)
                if (!port->non_pd_role_swap)
                        tcpm_swap_complete(port, -ENOTCONN);
                tcpm_pps_complete(port, -ENOTCONN);
+               port->hard_reset_count = 0;
                tcpm_snk_detach(port);
                if (tcpm_start_toggling(port, TYPEC_CC_RD)) {
                        tcpm_set_state(port, TOGGLING, 0);
Quoted 1 line

Li Jun

For the current power role is snk, I think it may work. How about the src role? src role only reset the hard_reset_count in tcpm_detach and src_ready state?

I check the flow that you mentioned in the previous mail. It's really a special case from any state to port_reset.
If the case is considered, how about to reset the hard_reset_count and don't care the port is attached or not in tcpm_detach function like as below.

@@ -2789,6 +2789,8 @@ static void tcpm_reset_port(struct tcpm_port *port)

static void tcpm_detach(struct tcpm_port *port)
{
+ port->hard_reset_count = 0;
+

        if (!port->attached)
                return;

@@ -2797,9 +2799,6 @@ static void tcpm_detach(struct tcpm_port *port)

                port->tcpc->set_bist_data(port->tcpc, false);
        }

- if (tcpm_port_is_disconnected(port))
- port->hard_reset_count = 0;
-

        tcpm_reset_port(port);

}

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the reset
line below port attached is false and also make some judgement. I think there may be ome condition that we don't considered.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Guenter

#18 lore raw

On Sat, Oct 10, 2020 at 12:06:13AM +0800, ChiYuan Huang wrote:
[ ... ]

Quoted 7 lines

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

Quoted 7 lines

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the reset
line below port attached is false and also make some judgement. I think there may be ome condition that we don't considered.

As I am sure I have mentioned before, it was to handle misbehaving partners, to enforce that the system goes into error recovery state and (hopefully) recover the partner enough to be able to reconnect. This is the same reason why resetting the counter is commented out in SRC_SEND_CAPABILITIES and reset in SRC_READY instead. The typical sequence was that the state machine would process from SRC_UNATTACHED to some point and then stall / time out, but never be in disconnected state.

Always resetting the hard reset counter in tcpm_detach() would disable error recovery in that situation, and affected partners would never recover. Effectively it would disable error recovery in any state machine cycle which involves an unattached state, which makes me really question if it is indeed mandated by the specification to reset the hard reset counter at that point.

Guenter

#19 lore raw
In reply to ChiYuan Huang
Quoted 157 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Saturday, October 10, 2020 12:06 AM
To: Jun Li <[email protected]>
Cc: Jun Li <[email protected]>; Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Jun Li <[email protected]> 於 2020年10月9日 週五 下午2:12寫道:

Quoted 15 lines
Quoted 15 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 6:13 PM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Quoted 1 line
Quoted 1 line

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39寫

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38

写

Quoted 3 lines
Quoted 3 lines

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午

11:30

Quoted 107 lines
Quoted 59 lines

寫道:

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines · Greg KH

[ ... ]

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open

another problem.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if

it is.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 36 lines
Quoted 22 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+ !port->vbus_present)
Quoted 6 lines

The hard_reset_count not reset issue is following by the below order 1. VBUS off ( at the same time, cc is still detected as attached)
port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

Quoted 19 lines
Quoted 5 lines

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Quoted 3 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct

tcpm_port

*port)

Quoted 13 lines
Quoted 9 lines
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when 1. At src state, pe_src_send_cap and receive GoodCRC 2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

3.
8.3.3.3.8 PE_SNK_Hard_Reset state
"Note: The HardResetCounter is reset on a power cycle or Detach."

Quoted 18 lines
Quoted 4 lines
Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below. 200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario. From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

Quoted 1 line

This case is hard to reproduce. But actually it's possible.

Make sense.

Then I propose doing this at SNK_UNATTACHED @@ -3156,6 +3156,7 @@ static void run_state_machine(struct tcpm_port *port)

Quoted 7 lines
                if (!port->non_pd_role_swap)
                        tcpm_swap_complete(port, -ENOTCONN);
                tcpm_pps_complete(port, -ENOTCONN);
+               port->hard_reset_count = 0;
                tcpm_snk_detach(port);
                if (tcpm_start_toggling(port, TYPEC_CC_RD)) {
                        tcpm_set_state(port, TOGGLING, 0); Li Jun
Quoted 3 lines

For the current power role is snk, I think it may work. How about the src role? src role only reset the hard_reset_count in tcpm_detach and src_ready state?

Sorry, after gave more check on PD sped, this isn't a right solution. See below

Quoted 24 lines

I check the flow that you mentioned in the previous mail. It's really a special case from any state to port_reset.
If the case is considered, how about to reset the hard_reset_count and don't care the port is attached or not in tcpm_detach function like as below.

(quoted diff) +2 -3
@@ -2789,6 +2789,8 @@ static void tcpm_reset_port(struct tcpm_port *port)
 
 static void tcpm_detach(struct tcpm_port *port)  {
+       port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2797,9 +2799,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 
Quoted 2 lines

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

This may not be so correct as you said, I think Guenter's concern is valid.

tcpm_detach() is not *only* be called in cases of *physical* detach like the function name suggests.

The current proposals may *wrongly* reset this counter.

Let me give an example:

HARD_RESET_SEND -> HARD_RESET_START -> SNK_HARD_RESET_SINK_OFF -> SNK_HARD_RESET_WAIT_VBUS -> SNK_UNATTACHED(in case of VBUS doesn't come back in expected duration) -> call to tcpm_detach()

In this sequence, does the sink need keep the counter? From the PD spec, I think the answer is yes, sink need this counter to judge if need do hard reset again or error recovery on later try, see:

Figure 8-67 Sink Port State Diagram

The difference between your case and my example, is your case never turn off vbus, so will not go to SNK_UNATTACHED, so will not call to tcpm_detach() after first hard reset.

So

	if (tcpm_port_is_disconnected(port))
		port->hard_reset_count = 0;

should keep as it is, the counter can only be cleared if there is really physical disconnect by *partner*.

But current tcpm code may have some problem on keeping local CC state if there is hard reset on-going(port->hard_reset_count > 0), because the current handling of SNK_UNATTACHED may cause disconnection generated by *local*(partner actually keeps its CC), e.g. reset polarity and do drp_toggling, this should be fixed, but this is another patch, I can try to do this later.

Back to your problem, I think the issue is, at the first tcpm_detach() the cc disconnect event hasn't happen, so the reset counter is left there but the port->attached is cleared, then the following(real disconnect) tcpm_detach() will just return directly due to port->attached is false.

So I guess this will resolve your problem:

@@ -2885,6 +2885,9 @@ static void tcpm_reset_port(struct tcpm_port *port)

static void tcpm_detach(struct tcpm_port *port)
{
+ if (tcpm_port_is_disconnected(port))
+ port->hard_reset_count = 0;
+

        if (!port->attached)
                return;

@@ -2893,9 +2896,6 @@ static void tcpm_detach(struct tcpm_port *port)

                port->tcpc->set_bist_data(port->tcpc, false);
        }

- if (tcpm_port_is_disconnected(port))
- port->hard_reset_count = 0;
-

        tcpm_reset_port(port);

}

Compared with current code's condition:
3 static bool tcpm_port_is_disconnected(struct tcpm_port *port) 4 {
5 return (!port->attached && port->cc1 == TYPEC_CC_OPEN &&
6 port->cc2 == TYPEC_CC_OPEN) ||
7 (port->attached && ((port->polarity == TYPEC_POLARITY_CC1 &&
8 port->cc1 == TYPEC_CC_OPEN) ||
9 (port->polarity == TYPEC_POLARITY_CC2 &&
10 port->cc2 == TYPEC_CC_OPEN)));
11 }

My above change is only adding another condition to clear the reset counter:
(!port->attached && port->cc1 == TYPEC_CC_OPEN && port->cc2 == TYPEC_CC_OPEN)

This condition is close to Guenter's suggestion in this thread:

- if (tcpm_port_is_disconnected(port))
+ if (tcpm_port_is_disconnected(port) ||
+ (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))

Hi Guenter, any comments on this?

Thanks
Li Jun

Quoted 10 lines

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the reset line
below port attached is false and also make some judgement.
I think there may be ome condition that we don't considered.

This condition was added at first place, I think my above

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Guenter

#20 lore raw
Quoted 277 lines · Jun Li
Quoted 157 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Saturday, October 10, 2020 12:06 AM
To: Jun Li <[email protected]>
Cc: Jun Li <[email protected]>; Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Jun Li <[email protected]> 於 2020年10月9日 週五 下午2:12寫道:

Quoted 15 lines
Quoted 15 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 6:13 PM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Quoted 1 line
Quoted 1 line

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39寫

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38

写

Quoted 3 lines
Quoted 3 lines

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午

11:30

Quoted 107 lines
Quoted 59 lines

寫道:

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines · Greg KH

[ ... ]

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open

another problem.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if

it is.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 36 lines
Quoted 22 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+ !port->vbus_present)
Quoted 6 lines

The hard_reset_count not reset issue is following by the below order 1. VBUS off ( at the same time, cc is still detected as attached)
port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

Quoted 19 lines
Quoted 5 lines

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Quoted 3 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct

tcpm_port

*port)

Quoted 13 lines
Quoted 9 lines
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when 1. At src state, pe_src_send_cap and receive GoodCRC 2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

3.
8.3.3.3.8 PE_SNK_Hard_Reset state
"Note: The HardResetCounter is reset on a power cycle or Detach."

Quoted 18 lines
Quoted 4 lines
Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below. 200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario. From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

Quoted 1 line

This case is hard to reproduce. But actually it's possible.

Make sense.

Then I propose doing this at SNK_UNATTACHED @@ -3156,6 +3156,7 @@ static void run_state_machine(struct tcpm_port *port)

Quoted 7 lines
                if (!port->non_pd_role_swap)
                        tcpm_swap_complete(port, -ENOTCONN);
                tcpm_pps_complete(port, -ENOTCONN);
+               port->hard_reset_count = 0;
                tcpm_snk_detach(port);
                if (tcpm_start_toggling(port, TYPEC_CC_RD)) {
                        tcpm_set_state(port, TOGGLING, 0); Li Jun
Quoted 3 lines

For the current power role is snk, I think it may work. How about the src role? src role only reset the hard_reset_count in tcpm_detach and src_ready state?

Sorry, after gave more check on PD sped, this isn't a right solution. See below

Quoted 24 lines

I check the flow that you mentioned in the previous mail. It's really a special case from any state to port_reset.
If the case is considered, how about to reset the hard_reset_count and don't care the port is attached or not in tcpm_detach function like as below.

(quoted diff) +2 -3
@@ -2789,6 +2789,8 @@ static void tcpm_reset_port(struct tcpm_port *port)
 
 static void tcpm_detach(struct tcpm_port *port)  {
+       port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2797,9 +2799,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 
Quoted 2 lines

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

This may not be so correct as you said, I think Guenter's concern is valid.

tcpm_detach() is not *only* be called in cases of *physical* detach like the function name suggests.

The current proposals may *wrongly* reset this counter.

Let me give an example:

HARD_RESET_SEND -> HARD_RESET_START -> SNK_HARD_RESET_SINK_OFF -> SNK_HARD_RESET_WAIT_VBUS -> SNK_UNATTACHED(in case of VBUS doesn't come back in expected duration) -> call to tcpm_detach()

In this sequence, does the sink need keep the counter? From the PD spec, I think the answer is yes, sink need this counter to judge if need do hard reset again or error recovery on later try, see:

Figure 8-67 Sink Port State Diagram

The difference between your case and my example, is your case never turn off vbus, so will not go to SNK_UNATTACHED, so will not call to tcpm_detach() after first hard reset.

So

	if (tcpm_port_is_disconnected(port))
		port->hard_reset_count = 0;

should keep as it is, the counter can only be cleared if there is really physical disconnect by *partner*.

But current tcpm code may have some problem on keeping local CC state if there is hard reset on-going(port->hard_reset_count > 0), because the current handling of SNK_UNATTACHED may cause disconnection generated by *local*(partner actually keeps its CC), e.g. reset polarity and do drp_toggling, this should be fixed, but this is another patch, I can try to do this later.

Back to your problem, I think the issue is, at the first tcpm_detach() the cc disconnect event hasn't happen, so the reset counter is left there but the port->attached is cleared, then the following(real disconnect) tcpm_detach() will just return directly due to port->attached is false.

So I guess this will resolve your problem:

(quoted diff) +3 -3
@@ -2885,6 +2885,9 @@ static void tcpm_reset_port(struct tcpm_port *port)
 
 static void tcpm_detach(struct tcpm_port *port)
 {
+       if (tcpm_port_is_disconnected(port))
+               port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2893,9 +2896,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 

Compared with current code's condition:

   3 static bool tcpm_port_is_disconnected(struct tcpm_port *port)
   4 {
   5         return (!port->attached && port->cc1 == TYPEC_CC_OPEN &&
   6                 port->cc2 == TYPEC_CC_OPEN) ||
   7                (port->attached && ((port->polarity == TYPEC_POLARITY_CC1 &&
   8                                     port->cc1 == TYPEC_CC_OPEN) ||
   9                                    (port->polarity == TYPEC_POLARITY_CC2 &&

10 port->cc2 == TYPEC_CC_OPEN)));
11 }

My above change is only adding another condition to clear the reset counter:
(!port->attached && port->cc1 == TYPEC_CC_OPEN && port->cc2 == TYPEC_CC_OPEN)

This condition is close to Guenter's suggestion in this thread:

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))
Quoted 2 lines

Hi Guenter, any comments on this?

That makes sense, and I would agree to the change you suggest above.

Guenter

Quoted 20 lines

Thanks
Li Jun

Quoted 10 lines

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the reset line
below port attached is false and also make some judgement.
I think there may be ome condition that we don't considered.

This condition was added at first place, I think my above

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Guenter

#21 lore raw

Guenter Roeck <[email protected]> 於 2020年10月11日 週日 上午3:31寫道:

Quoted 252 lines · Jun Li
Quoted 250 lines
Quoted 157 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Saturday, October 10, 2020 12:06 AM
To: Jun Li <[email protected]>
Cc: Jun Li <[email protected]>; Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Jun Li <[email protected]> 於 2020年10月9日 週五 下午2:12寫道:

Quoted 15 lines
Quoted 15 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 6:13 PM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Quoted 1 line
Quoted 1 line

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39寫

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38

写

Quoted 3 lines
Quoted 3 lines

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午

11:30

Quoted 107 lines
Quoted 59 lines

寫道:

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines · Greg KH

[ ... ]

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open

another problem.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if

it is.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 36 lines
Quoted 22 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+ !port->vbus_present)
Quoted 6 lines

The hard_reset_count not reset issue is following by the below order 1. VBUS off ( at the same time, cc is still detected as attached)
port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

Quoted 19 lines
Quoted 5 lines

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Quoted 3 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct

tcpm_port

*port)

Quoted 13 lines
Quoted 9 lines
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when 1. At src state, pe_src_send_cap and receive GoodCRC 2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

3.
8.3.3.3.8 PE_SNK_Hard_Reset state
"Note: The HardResetCounter is reset on a power cycle or Detach."

Quoted 18 lines
Quoted 4 lines
Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below. 200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario. From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

Quoted 1 line

This case is hard to reproduce. But actually it's possible.

Make sense.

Then I propose doing this at SNK_UNATTACHED @@ -3156,6 +3156,7 @@ static void run_state_machine(struct tcpm_port *port)

Quoted 7 lines
                if (!port->non_pd_role_swap)
                        tcpm_swap_complete(port, -ENOTCONN);
                tcpm_pps_complete(port, -ENOTCONN);
+               port->hard_reset_count = 0;
                tcpm_snk_detach(port);
                if (tcpm_start_toggling(port, TYPEC_CC_RD)) {
                        tcpm_set_state(port, TOGGLING, 0); Li Jun
Quoted 3 lines

For the current power role is snk, I think it may work. How about the src role? src role only reset the hard_reset_count in tcpm_detach and src_ready state?

Sorry, after gave more check on PD sped, this isn't a right solution. See below

Quoted 24 lines

I check the flow that you mentioned in the previous mail. It's really a special case from any state to port_reset.
If the case is considered, how about to reset the hard_reset_count and don't care the port is attached or not in tcpm_detach function like as below.

(quoted diff) +2 -3
@@ -2789,6 +2789,8 @@ static void tcpm_reset_port(struct tcpm_port *port)
 
 static void tcpm_detach(struct tcpm_port *port)  {
+       port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2797,9 +2799,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 
Quoted 2 lines

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

This may not be so correct as you said, I think Guenter's concern is valid.

tcpm_detach() is not *only* be called in cases of *physical* detach like the function name suggests.

The current proposals may *wrongly* reset this counter.

Let me give an example:

HARD_RESET_SEND -> HARD_RESET_START -> SNK_HARD_RESET_SINK_OFF -> SNK_HARD_RESET_WAIT_VBUS -> SNK_UNATTACHED(in case of VBUS doesn't come back in expected duration) -> call to tcpm_detach()

In this sequence, does the sink need keep the counter? From the PD spec, I think the answer is yes, sink need this counter to judge if need do hard reset again or error recovery on later try, see:

Figure 8-67 Sink Port State Diagram

The difference between your case and my example, is your case never turn off vbus, so will not go to SNK_UNATTACHED, so will not call to tcpm_detach() after first hard reset.

So

      if (tcpm_port_is_disconnected(port))
              port->hard_reset_count = 0;

should keep as it is, the counter can only be cleared if there is really physical disconnect by *partner*.

But current tcpm code may have some problem on keeping local CC state if there is hard reset on-going(port->hard_reset_count > 0), because the current handling of SNK_UNATTACHED may cause disconnection generated by *local*(partner actually keeps its CC), e.g. reset polarity and do drp_toggling, this should be fixed, but this is another patch, I can try to do this later.

Back to your problem, I think the issue is, at the first tcpm_detach() the cc disconnect event hasn't happen, so the reset counter is left there but the port->attached is cleared, then the following(real disconnect) tcpm_detach() will just return directly due to port->attached is false.

So I guess this will resolve your problem:

(quoted diff) +3 -0
@@ -2885,6 +2885,9 @@ static void tcpm_reset_port(struct tcpm_port *port)
 
 static void tcpm_detach(struct tcpm_port *port)
 {
+       if (tcpm_port_is_disconnected(port))
+               port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2893,9 +2896,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
Quoted 7 lines

Review static void tcpm_detach(struct tcpm_port *port) · line 2901

Quoted 7 lines
(quoted diff) +0 -3
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 

I have checked this patch. It can solve the problem.

Quoted 16 lines
Quoted 16 lines

Compared with current code's condition:

   3 static bool tcpm_port_is_disconnected(struct tcpm_port *port)
   4 {
   5         return (!port->attached && port->cc1 == TYPEC_CC_OPEN &&
   6                 port->cc2 == TYPEC_CC_OPEN) ||
   7                (port->attached && ((port->polarity == TYPEC_POLARITY_CC1 &&
   8                                     port->cc1 == TYPEC_CC_OPEN) ||
   9                                    (port->polarity == TYPEC_POLARITY_CC2 &&

10 port->cc2 == TYPEC_CC_OPEN)));
11 }

My above change is only adding another condition to clear the reset counter:
(!port->attached && port->cc1 == TYPEC_CC_OPEN && port->cc2 == TYPEC_CC_OPEN)

This condition is close to Guenter's suggestion in this thread:

Quoted 8 lines
Quoted 6 lines
(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))

Hi Guenter, any comments on this?

That makes sense, and I would agree to the change you suggest above.

Jun:
will you send the patch following the final discussion? Or I also can help.
Thx.

Quoted 24 lines

Guenter

Quoted 20 lines

Thanks
Li Jun

Quoted 10 lines

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the reset line
below port attached is false and also make some judgement.
I think there may be ome condition that we don't considered.

This condition was added at first place, I think my above

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Guenter

#22 lore raw
Quoted 275 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Monday, October 12, 2020 2:23 PM
To: Guenter Roeck <[email protected]>
Cc: Jun Li <[email protected]>; Jun Li <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Guenter Roeck <[email protected]> 於 2020年10月11日 週日 上午3:31寫道:

Quoted 32 lines · Jun Li
Quoted 30 lines
Quoted 30 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Saturday, October 10, 2020 12:06 AM
To: Jun Li <[email protected]>
Cc: Jun Li <[email protected]>; Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Jun Li <[email protected]> 於 2020年10月9日 週五 下午2:12寫道:

Quoted 15 lines
Quoted 15 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 6:13 PM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

ChiYuan Huang <[email protected]> 於 2020年10月7日 週三 上午1:39

寫

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52

寫

Quoted 129 lines
Quoted 129 lines
Quoted 128 lines

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38

写

Quoted 3 lines
Quoted 3 lines

道:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午

11:30

Quoted 109 lines
Quoted 59 lines

寫道:

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines · Greg KH

[ ... ]

Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open

another problem.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if

it is.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 36 lines
Quoted 22 lines
Quoted 15 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +2 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+ !port->vbus_present)
Quoted 6 lines

The hard_reset_count not reset issue is following by the below order 1. VBUS off ( at the same time, cc is still detected as attached)
port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Quoted 6 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

Quoted 21 lines
Quoted 5 lines

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

Quoted 3 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct

tcpm_port

*port)

Quoted 15 lines
Quoted 10 lines
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,

TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when 1. At src state, pe_src_send_cap and receive GoodCRC
2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

3.
8.3.3.3.8 PE_SNK_Hard_Reset state
"Note: The HardResetCounter is reset on a power cycle or Detach."

Quoted 18 lines
Quoted 4 lines
Quoted 4 lines

Li Jun

Quoted 2 lines

And that's why hard_reset_count is not reset to 0.

I tried in snk_ready to reset hard_reset_count.
At normal case, it works.
But it seems still the possible fail case like as below. 200ms -> cc debounce max time
240ms -> snk_waitcap max time
If the plugin/out period is between (200+240) and (200+ 2* 240)ms , and the src side plug out like as the described scenario. From this case, hard_reset_count may still 1.
And we expect the next plugin hard_reset_count is 0. But not, actually it never reset.
So at next plugin, only one hard_reset will be sent and reach hard_reset_count max (2).

Quoted 1 line

This case is hard to reproduce. But actually it's possible.

Make sense.

Then I propose doing this at SNK_UNATTACHED @@ -3156,6 +3156,7 @@ static void run_state_machine(struct tcpm_port *port)

Quoted 7 lines
                if (!port->non_pd_role_swap)
                        tcpm_swap_complete(port, -ENOTCONN);
                tcpm_pps_complete(port, -ENOTCONN);
+               port->hard_reset_count = 0;
                tcpm_snk_detach(port);
                if (tcpm_start_toggling(port, TYPEC_CC_RD)) {
                        tcpm_set_state(port, TOGGLING, 0); Li Jun

For the current power role is snk, I think it may work. How about the src role? src role only reset the hard_reset_count in tcpm_detach and src_ready state?

Quoted 8 lines
Quoted 8 lines

Sorry, after gave more check on PD sped, this isn't a right solution. See below

Quoted 5 lines

I check the flow that you mentioned in the previous mail. It's really a special case from any state to port_reset.
If the case is considered, how about to reset the hard_reset_count and don't care the port is attached or not in tcpm_detach function like

as below.

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
(quoted diff) +2 -3
@@ -2789,6 +2789,8 @@ static void tcpm_reset_port(struct tcpm_port
 *port)
 
 static void tcpm_detach(struct tcpm_port *port)  {
+       port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2797,9 +2799,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

This may not be so correct as you said, I think Guenter's concern is

valid.

Quoted 59 lines
Quoted 59 lines

tcpm_detach() is not *only* be called in cases of *physical* detach like the function name suggests.

The current proposals may *wrongly* reset this counter.

Let me give an example:

HARD_RESET_SEND -> HARD_RESET_START -> SNK_HARD_RESET_SINK_OFF -> SNK_HARD_RESET_WAIT_VBUS -> SNK_UNATTACHED(in case of VBUS doesn't come back in expected duration)
-> call to tcpm_detach()

In this sequence, does the sink need keep the counter? From the PD spec, I think the answer is yes, sink need this counter to judge if need do hard reset again or error recovery on later try, see:

Figure 8-67 Sink Port State Diagram

The difference between your case and my example, is your case never turn off vbus, so will not go to SNK_UNATTACHED, so will not call to tcpm_detach() after first hard reset.

So

      if (tcpm_port_is_disconnected(port))
              port->hard_reset_count = 0;

should keep as it is, the counter can only be cleared if there is really physical disconnect by *partner*.

But current tcpm code may have some problem on keeping local CC state if there is hard reset on-going(port->hard_reset_count > 0), because the current handling of SNK_UNATTACHED may cause disconnection generated by *local*(partner actually keeps its CC), e.g. reset polarity and do drp_toggling, this should be fixed, but this is another patch, I can try to do this later.

Back to your problem, I think the issue is, at the first tcpm_detach() the cc disconnect event hasn't happen, so the reset counter is left there but the port->attached is cleared, then the following(real disconnect)
tcpm_detach() will just return directly due to port->attached is false.

So I guess this will resolve your problem:

(quoted diff) +3 -0
@@ -2885,6 +2885,9 @@ static void tcpm_reset_port(struct tcpm_port
 *port)
 
 static void tcpm_detach(struct tcpm_port *port)  {
+       if (tcpm_port_is_disconnected(port))
+               port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2893,9 +2896,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
Quoted 8 lines
Quoted 7 lines

Review static void tcpm_detach(struct tcpm_port *port) · line 2901

Quoted 7 lines
(quoted diff) +0 -3
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 

I have checked this patch. It can solve the problem.

Good, so this can resolve both your and my problems.

Quoted 25 lines
Quoted 7 lines
Quoted 7 lines

Compared with current code's condition:

   3 static bool tcpm_port_is_disconnected(struct tcpm_port *port)
   4 {
   5         return (!port->attached && port->cc1 == TYPEC_CC_OPEN &&
   6                 port->cc2 == TYPEC_CC_OPEN) ||
   7                (port->attached && ((port->polarity ==

TYPEC_POLARITY_CC1 &&

Quoted 2 lines
Quoted 2 lines
   8                                     port->cc1 == TYPEC_CC_OPEN) ||
   9                                    (port->polarity ==

TYPEC_POLARITY_CC2 &&

Quoted 14 lines
Quoted 14 lines
  10                                     port->cc2 == TYPEC_CC_OPEN)));
  11 }

My above change is only adding another condition to clear the reset counter:
(!port->attached && port->cc1 == TYPEC_CC_OPEN && port->cc2 == TYPEC_CC_OPEN)

This condition is close to Guenter's suggestion in this thread:

(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Hi Guenter, any comments on this?

That makes sense, and I would agree to the change you suggest above.

Jun:
will you send the patch following the final discussion? Or I also can
help.
Thx.

Ok, I will send a formal patch for this.

thanks
Li Jun

Quoted 24 lines
Quoted 24 lines

Guenter

Quoted 20 lines

Thanks
Li Jun

Quoted 10 lines

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the
reset line below port attached is false and also make some judgement. I think there may be ome condition that we don't considered.

This condition was added at first place, I think my above

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Guenter

#23 lore raw
In reply to Guenter Roeck
Quoted 14 lines

-----Original Message-----
From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
Sent: Sunday, October 11, 2020 3:32 AM
To: Jun Li <[email protected]>; ChiYuan Huang <[email protected]>
Cc: Jun Li <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

On 10/10/20 4:21 AM, Jun Li wrote:

...

Quoted 95 lines
Quoted 71 lines
Quoted 3 lines

Like I mentioned before, whatever the condition is, hard_reset_count must be reset to zero during tcpm_detach.

This may not be so correct as you said, I think Guenter's concern is valid.

tcpm_detach() is not *only* be called in cases of *physical* detach like the function name suggests.

The current proposals may *wrongly* reset this counter.

Let me give an example:

HARD_RESET_SEND -> HARD_RESET_START -> SNK_HARD_RESET_SINK_OFF -> SNK_HARD_RESET_WAIT_VBUS -> SNK_UNATTACHED(in case of VBUS doesn't come back in expected duration)
-> call to tcpm_detach()

In this sequence, does the sink need keep the counter? From the PD spec, I think the answer is yes, sink need this counter to judge if need do hard reset again or error recovery on later try, see:

Figure 8-67 Sink Port State Diagram

The difference between your case and my example, is your case never turn off vbus, so will not go to SNK_UNATTACHED, so will not call to tcpm_detach() after first hard reset.

So

	if (tcpm_port_is_disconnected(port))
		port->hard_reset_count = 0;

should keep as it is, the counter can only be cleared if there is really physical disconnect by *partner*.

But current tcpm code may have some problem on keeping local CC state if there is hard reset on-going(port->hard_reset_count > 0), because the current handling of SNK_UNATTACHED may cause disconnection generated by *local*(partner actually keeps its CC), e.g. reset polarity and do drp_toggling, this should be fixed, but this is another patch, I can try to do this later.

Back to your problem, I think the issue is, at the first tcpm_detach() the cc disconnect event hasn't happen, so the reset counter is left there but the port->attached is cleared, then the following(real disconnect)
tcpm_detach() will just return directly due to port->attached is false.

So I guess this will resolve your problem:

(quoted diff) +3 -3
@@ -2885,6 +2885,9 @@ static void tcpm_reset_port(struct tcpm_port
 *port)
 
 static void tcpm_detach(struct tcpm_port *port)  {
+       if (tcpm_port_is_disconnected(port))
+               port->hard_reset_count = 0;
+
        if (!port->attached)
                return;
 
@@ -2893,9 +2896,6 @@ static void tcpm_detach(struct tcpm_port *port)
                port->tcpc->set_bist_data(port->tcpc, false);
        }
 
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
-
        tcpm_reset_port(port);
 }
 
Quoted 6 lines

Compared with current code's condition:

   3 static bool tcpm_port_is_disconnected(struct tcpm_port *port)
   4 {
   5         return (!port->attached && port->cc1 == TYPEC_CC_OPEN &&
   6                 port->cc2 == TYPEC_CC_OPEN) ||
   7                (port->attached && ((port->polarity ==

TYPEC_POLARITY_CC1 &&

Quoted 2 lines
   8                                     port->cc1 == TYPEC_CC_OPEN) ||
   9                                    (port->polarity ==

TYPEC_POLARITY_CC2 &&

Quoted 14 lines
  10                                     port->cc2 == TYPEC_CC_OPEN)));
  11 }

My above change is only adding another condition to clear the reset counter:
(!port->attached && port->cc1 == TYPEC_CC_OPEN && port->cc2 == TYPEC_CC_OPEN)

This condition is close to Guenter's suggestion in this thread:

(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))
Quoted 4 lines
Quoted 2 lines

Hi Guenter, any comments on this?

That makes sense, and I would agree to the change you suggest above.

Thanks.

Li Jun

Quoted 23 lines

Guenter

Quoted 20 lines

Thanks
Li Jun

Quoted 10 lines

But refer to Guenter's mail, he prefer to narrow down the condition to reset this counter.

I think the original thought is important why to put this line there.

Hi, Guenter:
From the discussion, we really need to know why you put the reset
line below port attached is false and also make some judgement. I think there may be ome condition that we don't considered.

This condition was added at first place, I think my above

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Guenter

#24 lore raw
In reply to ChiYuan Huang
Quoted 59 lines

-----Original Message-----
From: ChiYuan Huang <[email protected]>
Sent: Wednesday, October 7, 2020 1:39 AM
To: Jun Li <[email protected]>
Cc: Guenter Roeck <[email protected]>; Greg KH <[email protected]>; Heikki Krogerus <[email protected]>; Linux USB List <[email protected]>; lkml <[email protected]>; cy_huang <[email protected]>; Jun Li <[email protected]>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

Jun Li <[email protected]> 於 2020年10月7日 週三 上午12:52寫道:

Quoted 4 lines
Quoted 2 lines · ChiYuan Huang <[email protected]> 于2020年10月6日周二 下午12:38写道:

Guenter Roeck <[email protected]> 於 2020年10月5日 週一 下午11:30寫

道:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Greg KH

[ ... ]

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

What ever happened with this patch, is there still disagreement?

Yes, there is. I wouldn't have added the conditional without reason, and I am concerned that removing it entirely will open another

problem.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Feel free to apply, though - I can't prove that my concern is valid, and after all we'll get reports from the field later if it

is.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Ok, can I get an ack so I know who to come back to in the future if there are issues? :)

Not from me, for the reasons I stated. I would be ok with something

like:

Quoted 20 lines
Quoted 19 lines
Quoted 7 lines
(quoted diff) +3 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) ||
+           (tcpm_cc_is_open(port->cc1) &&
+ tcpm_cc_is_open(port->cc2)))

to narrow down the condition.

I have tried the above comment and It doesn't work. How about to change the judgement like as below

(quoted diff) +1 -1
-       if (tcpm_port_is_disconnected(port))
+       if (tcpm_port_is_disconnected(port) || !port->vbus_present)

The hard_reset_count not reset issue is following by the below order
1. VBUS off ( at the same time, cc is still detected as attached) port->attached become false and cc is not open
2. After that, cc detached.
due to port->attached is false, tcpm_detach() directly return.

Quoted 7 lines
Quoted 3 lines

If tcpm_detach() return directly, then how your patch can reset hard_reset_count?

Yes, it can. We know vbus_present change from true to false and cc detach both trigger tcpm_detach.
My change is whenever tcpm_detach to be called, hard_reset_count will be reset to zero.

Your patch is based on the assumption that tcpm_detach() is called with port->attached is true, but tcpm_reset_port() may happen before that, in that case, tcpm_reset_port() clear port->attached flag so tcpm_detach will return directly.

Quoted 9 lines
Quoted 7 lines

I am seeing the same issue on my platform, the proposed change:

(quoted diff) +1 -2
-       if (tcpm_port_is_disconnected(port))
-               port->hard_reset_count = 0;
+       port->hard_reset_count = 0;

can't resolve it on my platform.

I'm not sure what's your condition. Could you directly paste the tcpm log for the check?

[   47.127729] Setting voltage/current limit 0 mV 0 mA
[   47.127739] polarity 0
[   47.129333] Requesting mux state 0, usb-role 0, orientation 0
[   47.130516] state change SNK_READY -> SNK_UNATTACHED
[   47.131181] CC1: 0 -> 0, CC2: 3 -> 0 [state SNK_UNATTACHED, polarity 0, disconnected]
[   47.131194] state change SNK_UNATTACHED -> PORT_RESET
[   47.134701] Setting voltage/current limit 0 mV 0 mA
[   47.134709] polarity 0
[   47.136291] Requesting mux state 0, usb-role 0, orientation 0
[   47.136873] cc:=0
[   47.137446] pending state change PORT_RESET -> PORT_RESET_WAIT_OFF @ 100 ms
[   47.138084] CC1: 0 -> 0, CC2: 0 -> 0 [state PORT_RESET, polarity 0, disconnected]
[   47.239143] state change PORT_RESET -> PORT_RESET_WAIT_OFF [delayed 100 ms]
[   47.239151] state change PORT_RESET_WAIT_OFF -> SNK_UNATTACHED
[   47.239154] Entering tcpm_detach directly return here <------------
[   47.239157] Start toggling
[   47.240150] state change SNK_UNATTACHED -> TOGGLING

Li Jun

Quoted 22 lines

Review static void run_state_machine(struct tcpm_port

Quoted 2 lines

How about reset hard_reset_count in SNK_READY?

(quoted diff) +0 -0
@@ -3325,6 +3329,7 @@ static void run_state_machine(struct tcpm_port

*port)

Quoted 9 lines
(quoted diff) +1 -0
        case SNK_READY:
                port->try_snk_count = 0;
                port->update_sink_caps = false;
+               port->hard_reset_count = 0;
                if (port->explicit_contract) {
                        typec_set_pwr_opmode(port->typec_port,
                                             TYPEC_PWR_MODE_PD);

can this resolve your problem?

I'm not sure. It need to have a try, then I can answer you. But from USBPD spec, the hard_reset_count need to reset zero only when 1. At src state, pe_src_send_cap and receive GoodCRC 2. At snk state, pe_snk_evaluate_cap need to reset hard_reset_count

Quoted 6 lines

Li Jun

Quoted 4 lines

And that's why hard_reset_count is not reset to 0.

Quoted 2 lines

Guenter