interconnect: core: Simplify with dev_err_probe()
Subsystems (2)
PATCH 1/2 interconnect: core: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.
Signed-off-by Krzysztof Kozlowski <[email protected]>
--- drivers/interconnect/core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/interconnect/core.c +2 -6
@@ -444,18 +444,14 @@ struct icc_path *of_icc_get_by_index(struct device *dev, int idx) src_node =of_icc_get_from_provider (&src_args);if (IS_ERR (src_node)) { -if (PTR_ERR (src_node) != -EPROBE_DEFER ) -dev_err (dev,"error finding src node: %ld\n" , -PTR_ERR (src_node)); +dev_err_probe (dev,PTR_ERR (src_node),"error finding src node\n" );return ERR_CAST (src_node); } dst_node =of_icc_get_from_provider (&dst_args);if (IS_ERR (dst_node)) { -if (PTR_ERR (dst_node) != -EPROBE_DEFER ) -dev_err (dev,"error finding dst node: %ld\n" , -PTR_ERR (dst_node)); +dev_err_probe (dev,PTR_ERR (dst_node),"error finding dst node\n" );return ERR_CAST (dst_node); }
Signature · 1 line
2.17.1
PATCH 2/2 interconnect: imx: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.
Signed-off-by Krzysztof Kozlowski <[email protected]>
--- drivers/interconnect/imx/imx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/interconnect/imx/imx.c +2 -4
@@ -184,10 +184,8 @@ static int imx_icc_register_nodes(struct icc_provider *provider, node =imx_icc_node_add (provider, node_desc);if (IS_ERR (node)) { - ret =PTR_ERR (node); -if (ret != -EPROBE_DEFER ) -dev_err (provider->dev,"failed to add %s: %d\n" , - node_desc->name, ret); + ret =dev_err_probe (provider->dev,PTR_ERR (node), +"failed to add %s\n" , node_desc->name); goto err; } provider_data->nodes[node->id] = node;
Signature · 1 line
2.17.1