Skip to contentSkip to conversation

net/i40e: i40evf exposes LSC flag to application.

PATCH Superseded SteveX Yang 2 participants 4 messages Aug 11, 2020 – Sep 3, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: i40evf exposes LSC flag to application.

When PF event VIRTCHNL_EVENT_LINK_CHANGE received, i40evf need update the link status and issue RTE_ETH_EVENT_INTR_LSC via _rte_eth_dev_callback_process().

---
 drivers/net/i40e/i40e_ethdev_vf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/i40e/i40e_ethdev_vf.c +5 -2
index 69cab8e73..a0a9268e5 100644
@@ -1381,13 +1381,16 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg,
 	switch (pf_msg->event) {
 	case VIRTCHNL_EVENT_RESET_IMPENDING:
 		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event");
-		_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET,
-					      NULL);
+		_rte_eth_dev_callback_process(dev,
+				RTE_ETH_EVENT_INTR_RESET, NULL);
 		break;
 	case VIRTCHNL_EVENT_LINK_CHANGE:
 		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event");
 		vf->link_up = pf_msg->event_data.link_event.link_status;
 		vf->link_speed = pf_msg->event_data.link_event.link_speed;
+		i40evf_dev_link_update(dev, 0);
+		_rte_eth_dev_callback_process(dev,
+				RTE_ETH_EVENT_INTR_LSC, NULL);
 		break;
 	case VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
 		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_PF_DRIVER_CLOSE event");
Signature · 1 line
2.17.1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of SteveX Yang
Sent: Tuesday, August 11, 2020 5:11 PM
To: Yang, Qiming <[email protected]>; Xing, Beilei <[email protected]>; Guo, Jia <[email protected]>; [email protected]
Cc: Yang, SteveX <[email protected]>
Subject: [dpdk-dev] [PATCH] net/i40e: i40evf exposes LSC flag to application.

Quoted 3 lines

When PF event VIRTCHNL_EVENT_LINK_CHANGE received, i40evf need update the link status and issue RTE_ETH_EVENT_INTR_LSC via _rte_eth_dev_callback_process().

The implementation is incomplete,

To support LSC in i40evf, please
1. add RTE_PCI_DRV_INTR_LSC in drv_flags
2. make sure dev_conf.intr_conf.lsc can be configure with 1 3.update i40e_vf.ini.

#2 lore raw

PATCH v2 1/1 net/i40e: i40evf exposes LSC flag to application

In reply to SteveX Yang

When PF event VIRTCHNL_EVENT_LINK_CHANGE received, i40evf need update the link status and issue RTE_ETH_EVENT_INTR_LSC via rte ether device callback function.

---
v2:
- add RTE_PCI_DRV_INTR_LSC in drv_flags
- configure the intr_conf.lsc according to RTE_ETH_EVENT_INTR_LSC
- update i40e_vf.ini

---
 doc/guides/nics/features/i40e_vf.ini |  1 +
 drivers/net/i40e/i40e_ethdev_vf.c    | 12 +++++++++---
 2 files changed, 10 insertions(+), 3 deletions(-)
doc/guides/nics/features/i40e_vf.ini +1 -0
index 9f95063d2..4984a6177 100644
@@ -6,6 +6,7 @@
 [Features]
 Rx interrupt         = Y
 Link status          = Y
+Link status event    = Y
 Fast mbuf free       = P
 Queue start/stop     = Y
 Jumbo frame          = Y
drivers/net/i40e/i40e_ethdev_vf.c +9 -3
index 69cab8e73..b4e42939e 100644
@@ -1381,13 +1381,16 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg,
 	switch (pf_msg->event) {
 	case VIRTCHNL_EVENT_RESET_IMPENDING:
 		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event");
-		_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET,
-					      NULL);
+		_rte_eth_dev_callback_process(dev,
+				RTE_ETH_EVENT_INTR_RESET, NULL);
 		break;
 	case VIRTCHNL_EVENT_LINK_CHANGE:
 		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event");
 		vf->link_up = pf_msg->event_data.link_event.link_status;
 		vf->link_speed = pf_msg->event_data.link_event.link_speed;
+		i40evf_dev_link_update(dev, 0);
+		_rte_eth_dev_callback_process(dev,
+				RTE_ETH_EVENT_INTR_LSC, NULL);
 		break;
 	case VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
 		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_PF_DRIVER_CLOSE event");
@@ -1609,7 +1612,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
  */
 static struct rte_pci_driver rte_i40evf_pmd = {
 	.id_table = pci_id_i40evf_map,
-	.drv_flags = RTE_PCI_DRV_NEED_MAPPING,
+	.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
 	.probe = eth_i40evf_pci_probe,
 	.remove = eth_i40evf_pci_remove,
 };
@@ -1635,6 +1638,9 @@ i40evf_dev_configure(struct rte_eth_dev *dev)
 	ad->tx_simple_allowed = true;
 	ad->tx_vec_allowed = true;
 
+	dev->data->dev_conf.intr_conf.lsc =
+		!!(dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC);
+
 	if (num_queue_pairs > vf->vsi_res->num_queue_pairs) {
 		struct i40e_hw *hw;
 		int ret;
Signature · 1 line
2.17.1
Acked-by on v2 1/1 Applied
#3 lore raw

Re: [dpdk-dev] [PATCH v2] net/i40e: i40evf exposes LSC flag to application

Quoted 11 lines

-----Original Message-----
From: Yang, SteveX <[email protected]>
Sent: Thursday, September 3, 2020 3:19 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>; Guo, Jia <[email protected]>; Yang, Qiming <[email protected]>; Yang, SteveX <[email protected]>
Subject: [PATCH v2] net/i40e: i40evf exposes LSC flag to application

Quoted 5 lines

When PF event VIRTCHNL_EVENT_LINK_CHANGE received, i40evf need update the link status and issue RTE_ETH_EVENT_INTR_LSC via rte ether device callback function.

Applied to dpdk-next-net-intel.

Thanks
Qi