configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
PATCH 1/1 configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
Setting CONFIG_ENV_ADDR to something other than 0 stops gd->env_addr from being allocated dynamically. When the environment is in SPI we need it to be allocated as we can't use a direct memory mapped address.
---
configs/T2080RDB_SPIFLASH_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/T2080RDB_SPIFLASH_defconfig +0 -1
@@ -50,7 +50,6 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9 CONFIG_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y CONFIG_ENV_IS_IN_SPI_FLASH=y -CONFIG_ENV_ADDR=0xFFFC9000 CONFIG_DM=y CONFIG_FSL_CAAM=y CONFIG_DM_I2C=y
Signature · 1 line
2.28.0
PATCH 1/1 configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
Quoted 15 lines · Chris Packham
Setting
CONFIG_ENV_ADDRto something other than 0 stopsgd->env_addrfrom being allocated dynamically. When the environment is in SPI we need it to be allocated as we can't use a direct memory mapped address.Signed-off-by Chris Packham <[email protected]>---
configs/T2080RDB_SPIFLASH_defconfig | 1 - 1 file changed, 1 deletion(-)configs/T2080RDB_SPIFLASH_defconfig +0
-0
configs/T2080RDB_SPIFLASH_defconfig CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9 · line 55
Quoted 7 lines
configs/T2080RDB_SPIFLASH_defconfig +0
-1@@ -50,7 +50,6 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9 CONFIG_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y CONFIG_ENV_IS_IN_SPI_FLASH=y -CONFIG_ENV_ADDR=0xFFFC9000 CONFIG_DM=y CONFIG_FSL_CAAM=y CONFIG_DM_I2C=y
Thanks for figuring that out. There's a handful of _SPIFLASH defconfigs that do the exact same thing, from the same conversion (I probably did it) to defconfig. It's likely that they're all wrong, yes?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200903/13608e79/attachment.sig>
PATCH 1/1 configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
Quoted 27 lines · Tom Rini,
Review
Quoted 11 lines · Chris Packham
Setting
CONFIG_ENV_ADDRto something other than 0 stopsgd->env_addrfrom being allocated dynamically. When the environment is in SPI we need it to be allocated as we can't use a direct memory mapped address.Signed-off-by Chris Packham <[email protected]>---
configs/T2080RDB_SPIFLASH_defconfig | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0b/configs/T2080RDB_SPIFLASH_defconfig
configs/T2080RDB_SPIFLASH_defconfig
Quoted 4 lines
index
62cbab1f0734..ba4ac1010502100644configs/T2080RDB_SPIFLASH_defconfig +0
-0@@ -50,7 +50,6 @@
CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9configs/T2080RDB_SPIFLASH_defconfig CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9 · line 55
Quoted 7 lines
configs/T2080RDB_SPIFLASH_defconfig +0
-1CONFIG_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y CONFIG_ENV_IS_IN_SPI_FLASH=y -CONFIG_ENV_ADDR=0xFFFC9000 CONFIG_DM=y CONFIG_FSL_CAAM=y CONFIG_DM_I2C=y
Quoted 4 lines
Thanks for figuring that out. There's a handful of
_SPIFLASHdefconfigs that do the exact same thing, from the same conversion (I probably did it) to defconfig. It's likely that they're all wrong, yes?
More than likely yes. I've only got a T2080RDB to test with but I can whip up a patch to make the same change to the other affected defconfigs.
PATCH 1/1 configs: powerpc: Don't set CONFIG_ENV_ADDR for T2080RDB_SPIFLASH
Quoted 29 lines · Chris Packham
Quoted 27 lines · Tom Rini,
Review
Quoted 11 lines · Chris Packham
Setting
CONFIG_ENV_ADDRto something other than 0 stopsgd->env_addrfrom being allocated dynamically. When the environment is in SPI we need it to be allocated as we can't use a direct memory mapped address.Signed-off-by Chris Packham <[email protected]>---
configs/T2080RDB_SPIFLASH_defconfig | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0b/configs/T2080RDB_SPIFLASH_defconfig
configs/T2080RDB_SPIFLASH_defconfig
Quoted 4 lines
index
62cbab1f0734..ba4ac1010502100644configs/T2080RDB_SPIFLASH_defconfig +0
-0@@ -50,7 +50,6 @@
CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kernel),128k(dtb),9Quoted 7 lines
configs/T2080RDB_SPIFLASH_defconfig +0
-1CONFIG_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y CONFIG_ENV_IS_IN_SPI_FLASH=y -CONFIG_ENV_ADDR=0xFFFC9000 CONFIG_DM=y CONFIG_FSL_CAAM=y CONFIG_DM_I2C=y
Quoted 7 lines
Quoted 4 lines
Thanks for figuring that out. There's a handful of
_SPIFLASHdefconfigs that do the exact same thing, from the same conversion (I probably did it) to defconfig. It's likely that they're all wrong, yes?More than likely yes. I've only got a T2080RDB to test with but I can whip up a patch to make the same change to the other affected defconfigs.
Please do, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200904/7a0f7fb4/attachment.sig>