Skip to contentSkip to conversation

meson: install ivshmem-client and ivshmem-server

PATCH In review Bruce Rogers 6 participants 13 messages Sep 3, 2020 – Sep 4, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meson: install ivshmem-client and ivshmem-server

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +1 -1
index 3a53942201..a1c39aa3b3 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
Signature · 1 line
2.28.0
#1 lore raw

Hi

Quoted 4 lines · Bruce Rogers

Turn on the meson install flag for these executables

I am not sure we want to install binaries that don't even have maintainers (or am I wrong?).

Quoted 28 lines
---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +1 -2
index 3a53942201..a1c39aa3b3 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
--

2.28.0

#2 lore raw
In reply to Bruce Rogers
Quoted 24 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644

contrib/ivshmem-server/meson.build line 4

Quoted 5 lines
contrib/ivshmem-server/meson.build +1 -1
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Paolo

#3 lore raw
Quoted 24 lines · Paolo Bonzini
Quoted 23 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644
@@ -1,4 +1,4 @@
Quoted 8 lines

contrib/ivshmem-server/meson.build line 4

Quoted 6 lines
contrib/ivshmem-server/meson.build +1 -1
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Unfortunately they were historically installed with --enable-tools.

IMHO nothing in contrib/ should be installed by default. If we consider something maintained and high enough quality for end users, it should migrate out of contrib/ into tools/.

vhost-user-gpu and elf2dmp are also both in contrib/ but installed by default :-(

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#4 lore raw
Quoted 38 lines · Daniel P. Berrangé
Quoted 28 lines · Paolo Bonzini
Quoted 27 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c',
 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c',
Quoted 8 lines

contrib/ivshmem-server/meson.build line 4

Quoted 6 lines
contrib/ivshmem-server/meson.build +1 -1
 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Quoted 2 lines

Unfortunately they were historically installed with --enable-tools.

Yeah, that's how I was getting them installed in what we are packaging up.

- Bruce

#5 lore raw
In reply to Daniel P. Berrangé
Quoted 34 lines · Daniel P. Berrangé
Quoted 24 lines · Paolo Bonzini
Quoted 23 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644
@@ -1,4 +1,4 @@
Quoted 8 lines

contrib/ivshmem-server/meson.build line 4

Quoted 6 lines
contrib/ivshmem-server/meson.build +1 -1
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Quoted 5 lines

Unfortunately they were historically installed with --enable-tools.

IMHO nothing in contrib/ should be installed by default. If we consider something maintained and high enough quality for end users, it should migrate out of contrib/ into tools/.

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Paolo

Quoted 7 lines

vhost-user-gpu and elf2dmp are also both in contrib/ but installed by default :-(

Regards,
Daniel

#6 lore raw
Quoted 35 lines · Paolo Bonzini
Quoted 34 lines · Daniel P. Berrangé
Quoted 32 lines · Paolo Bonzini
Quoted 24 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644

contrib/ivshmem-server/meson.build line 4

Quoted 5 lines
contrib/ivshmem-server/meson.build +1 -1
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Quoted 7 lines
Quoted 5 lines

Unfortunately they were historically installed with --enable-tools.

IMHO nothing in contrib/ should be installed by default. If we consider something maintained and high enough quality for end users, it should migrate out of contrib/ into tools/.

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem device works. They might even be useful for debugging. They are *not* to be used in production.

docs/specs/ivshmem-spec.txt:

Example server code is in contrib/ivshmem-server/. Not to be used in production. It assumes all clients use the same number of interrupt vectors.

A standalone client is in contrib/ivshmem-client/. It can be useful for debugging.

Installing example *source* might make sense (but I doubt it). Installing the binaries does not.

#7 lore raw
Quoted 6 lines · Markus Armbruster
Quoted 1 line

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem device works. They might even be useful for debugging. They are *not* to be used in production.

Oooookay. :) It needs to be documented in the changelog.

Paolo

Quoted 12 lines

docs/specs/ivshmem-spec.txt:

Example server code is in contrib/ivshmem-server/. Not to be used in production. It assumes all clients use the same number of interrupt vectors.

A standalone client is in contrib/ivshmem-client/. It can be useful for debugging.

Installing example *source* might make sense (but I doubt it). Installing the binaries does not.

#8 lore raw
Quoted 9 lines · Paolo Bonzini
Quoted 6 lines · Markus Armbruster
Quoted 1 line

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem device works. They might even be useful for debugging. They are *not* to be used in production.

Oooookay. :) It needs to be documented in the changelog.

I'll take care of updating <https://wiki.qemu.org/ChangeLog/5.2>.

#9 lore raw
Quoted 13 lines · Markus Armbruster
Quoted 11 lines · Paolo Bonzini
Quoted 9 lines · Markus Armbruster
Quoted 2 lines

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem
device works. They might even be useful for debugging. They are *not*
to be used in production.

Quoted 4 lines
Quoted 1 line

Oooookay. :) It needs to be documented in the changelog.

I'll take care of updating <https://wiki.qemu.org/ChangeLog/5.2>;.

Thanks all for the clarification on this one. It was packaged up simply because it got installed, and I never got to looking at the use case for these binaries.

I'll remove them from what we package in SUSE's SLE and openSUSE.

- Bruce

#10 lore raw
Quoted 16 lines · Bruce Rogers
Quoted 15 lines · Markus Armbruster
Quoted 12 lines · Paolo Bonzini
Quoted 9 lines · Markus Armbruster
Quoted 2 lines

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem
device works. They might even be useful for debugging. They are *not*
to be used in production.

Oooookay. :) It needs to be documented in the changelog.

Quoted 8 lines
Quoted 2 lines

I'll take care of updating <https://wiki.qemu.org/ChangeLog/5.2>;.

Thanks all for the clarification on this one. It was packaged up simply because it got installed, and I never got to looking at the use case for these binaries.

I'll remove them from what we package in SUSE's SLE and openSUSE.

Thanks!

#11 lore raw
In reply to Markus Armbruster
Quoted 51 lines · Markus Armbruster
Quoted 35 lines · Paolo Bonzini
Quoted 34 lines · Daniel P. Berrangé
Quoted 32 lines · Paolo Bonzini
Quoted 24 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644

contrib/ivshmem-server/meson.build line 4

Quoted 5 lines
contrib/ivshmem-server/meson.build +1 -1
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Quoted 7 lines
Quoted 5 lines

Unfortunately they were historically installed with --enable-tools.

IMHO nothing in contrib/ should be installed by default. If we consider something maintained and high enough quality for end users, it should migrate out of contrib/ into tools/.

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem device works. They might even be useful for debugging. They are *not* to be used in production.

Quoted 8 lines

docs/specs/ivshmem-spec.txt:

Example server code is in contrib/ivshmem-server/. Not to be used in production. It assumes all clients use the same number of interrupt vectors.

A standalone client is in contrib/ivshmem-client/. It can be useful for debugging.

Renaming the file names to contain "example" would make this clear.

Quoted 5 lines

Installing example *source* might make sense (but I doubt it). Installing the binaries does not.

#12 lore raw
Quoted 54 lines · Philippe Mathieu-Daudé
Quoted 53 lines · Markus Armbruster
Quoted 35 lines · Paolo Bonzini
Quoted 34 lines · Daniel P. Berrangé
Quoted 32 lines · Paolo Bonzini
Quoted 24 lines · Bruce Rogers

Turn on the meson install flag for these executables

---
 contrib/ivshmem-client/meson.build | 2 +-
 contrib/ivshmem-server/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
contrib/ivshmem-client/meson.build +1 -1
index 1b171efb4f..83a559117f 100644
@@ -1,4 +1,4 @@
 executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
            dependencies: glib,
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)
contrib/ivshmem-server/meson.build +0 -0
index 3a53942201..a1c39aa3b3 100644

contrib/ivshmem-server/meson.build line 4

Quoted 5 lines
contrib/ivshmem-server/meson.build +1 -1
@@ -1,4 +1,4 @@
 executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
            dependencies: [qemuutil, rt],
            build_by_default: targetos == 'linux',
-           install: false)
+           install: true)

They weren't installed before the conversion, were they?

Quoted 7 lines
Quoted 5 lines

Unfortunately they were historically installed with --enable-tools.

IMHO nothing in contrib/ should be installed by default. If we consider something maintained and high enough quality for end users, it should migrate out of contrib/ into tools/.

Ah, via the tools variable in configure. Nice maze. I've queued the patch.

Please don't.

These programs are examples to help people understand how the ivhsmem device works. They might even be useful for debugging. They are *not* to be used in production.

docs/specs/ivshmem-spec.txt:

Quoted 8 lines
Quoted 6 lines

Example server code is in contrib/ivshmem-server/. Not to be used in production. It assumes all clients use the same number of interrupt vectors.

A standalone client is in contrib/ivshmem-client/. It can be useful for debugging.

Renaming the file names to contain "example" would make this clear.

That's essentially what 'contrib' already means. We shold probablt add a contrib/README.rst file though to explicitly tell people what we consider the state of these things to be.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|