dt-bindings: crypto: slimsss: Correct a typo in compatible
Subsystems (4)
Krzysztof Kozlowski
maintainerPATCH 1/3 dt-bindings: crypto: slimsss: Correct a typo in compatible
Correct a typo in the compatible - missing trailing 's'.
--- Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml +1 -1
@@ -19,7 +19,7 @@ description: |+ properties: compatible: items: - - const: samsung,exynos5433-slim-ss + - const: samsung,exynos5433-slim-sss reg: maxItems: 1
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 2/3 crypto: s5p-sss - Add and fix kerneldoc
Add missing and fix existing kerneldoc to silence W=1 warnings:
drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev' drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx' drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx' drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs' drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
--- drivers/crypto/s5p-sss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/crypto/s5p-sss.c +4 -3
@@ -260,6 +260,7 @@ struct s5p_aes_ctx {* struct s5p_aes_dev - Crypto device state container * @dev: Associated device * @clk: Clock for accessing hardware +* @pclk: APB bus clock necessary to access the hardware * @ioaddr: Mapped IO memory region * @aes_ioaddr: Per-varian offset for AES block IO memory * @irq_fc: Feed control interrupt line
@@ -342,13 +343,13 @@ struct s5p_aes_dev {* @engine: Bits for selecting type of HASH in SSS block * @sg: sg for DMA transfer * @sg_len: Length of sg for DMA transfer -* @sgl[]: sg for joining buffer and req->src scatterlist +* @sgl: sg for joining buffer and req->src scatterlist * @skip: Skip offset in req->src for current op * @total: Total number of bytes for current request * @finup: Keep state for finup or final. * @error: Keep track of error. * @bufcnt: Number of bytes holded in buffer[] -* @buffer[]: For byte(s) from end of req->src in UPDATE op +* @buffer: For byte(s) from end of req->src in UPDATE op */ struct s5p_hash_reqctx {struct s5p_aes_dev *dd;
@@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,* s5p_hash_prepare_sgs() - prepare sg for processing * @ctx: request context * @sg: source scatterlist request -* @nbytes: number of bytes to process from sg +* @new_len: number of bytes to process from sg * @final: final flag * * Check two conditions: (1) if buffers in sg have len aligned data, and (2)
Signature · 1 line
2.17.1
Re: [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc
Quoted 43 lines · Krzysztof Kozlowski
Add missing and fix existing kerneldoc to silence W=1 warnings:
drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/crypto/s5p-sss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/crypto/s5p-sss.c +3
-2@@ -260,6 +260,7 @@ struct s5p_aes_ctx {* struct s5p_aes_dev - Crypto device state container * @dev: Associated device * @clk: Clock for accessing hardware +* @pclk: APB bus clock necessary to access the hardware * @ioaddr: Mapped IO memory region * @aes_ioaddr: Per-varian offset for AES block IO memory * @irq_fc: Feed control interrupt line @@ -342,13 +343,13 @@ struct s5p_aes_dev {* @engine: Bits for selecting type of HASH in SSS block * @sg: sg for DMA transfer * @sg_len: Length of sg for DMA transfer -* @sgl[]: sg for joining buffer and req->src scatterlist +* @sgl: sg for joining buffer and req->src scatterlist * @skip: Skip offset in req->src for current op * @total: Total number of bytes for current request * @finup: Keep state for finup or final. * @error: Keep track of error. * @bufcnt: Number of bytes holded in buffer[] -* @buffer[]: For byte(s) from end of req->src in UPDATE op +* @buffer: For byte(s) from end of req->src in UPDATE op */ struct s5p_hash_reqctx {struct s5p_aes_dev *dd;
drivers/crypto/s5p-sss.c static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx, · line 1132
Quoted 8 lines
drivers/crypto/s5p-sss.c +1
-1@@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,* s5p_hash_prepare_sgs() - prepare sg for processing * @ctx: request context * @sg: source scatterlist request -* @nbytes: number of bytes to process from sg +* @new_len: number of bytes to process from sg * @final: final flag * * Check two conditions: (1) if buffers in sg have len aligned data, and (2)
Herbert Xu
maintainerRe: [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc
In reply to Krzysztof KozlowskiQuoted 8 lines · Krzysztof Kozlowski
Add missing and fix existing kerneldoc to silence W=1 warnings:
drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
Quoted 4 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/crypto/s5p-sss.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Krzysztof Kozlowski
maintainerPATCH 3/3 crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
In reply to Krzysztof KozlowskiPass the error directly from devm_clk_get() to describe the real reason, instead of fixed ENOENT. Do not print error messages on deferred probe.
--- drivers/crypto/s5p-sss.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/crypto/s5p-sss.c +7 -8
@@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev) } pdata->clk =devm_clk_get (dev, variant->clk_names[0 ]); -if (IS_ERR (pdata->clk)) { -dev_err (dev,"failed to find secss clock %s\n" , - variant->clk_names[0 ]); -return -ENOENT ; - } +if (IS_ERR (pdata->clk)) +return dev_err_probe (dev,PTR_ERR (pdata->clk), +"failed to find secss clock %s\n" , + variant->clk_names[0 ]); err =clk_prepare_enable (pdata->clk);if (err <0 ) {
@@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)if (variant->clk_names[1 ]) { pdata->pclk =devm_clk_get (dev, variant->clk_names[1 ]);if (IS_ERR (pdata->pclk)) { -dev_err (dev,"failed to find clock %s\n" , - variant->clk_names[1 ]); - err = -ENOENT ; + err =dev_err_probe (dev,PTR_ERR (pdata->pclk), +"failed to find clock %s\n" , + variant->clk_names[1 ]); goto err_clk; }
Signature · 1 line
2.17.1
Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
Quoted 32 lines · Krzysztof Kozlowski
Pass the error directly from
devm_clk_get()to describe the real reason, instead of fixed ENOENT. Do not print error messages on deferred probe.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/crypto/s5p-sss.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)drivers/crypto/s5p-sss.c +4
-5@@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev) } pdata->clk =devm_clk_get (dev, variant->clk_names[0 ]); -if (IS_ERR (pdata->clk)) { -dev_err (dev,"failed to find secss clock %s\n" , - variant->clk_names[0 ]); -return -ENOENT ; - } +if (IS_ERR (pdata->clk)) +return dev_err_probe (dev,PTR_ERR (pdata->clk), +"failed to find secss clock %s\n" , + variant->clk_names[0 ]); err =clk_prepare_enable (pdata->clk);if (err <0 ) {@@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)if (variant->clk_names[1 ]) { pdata->pclk =devm_clk_get (dev, variant->clk_names[1 ]);
drivers/crypto/s5p-sss.c static int s5p_aes_probe(struct platform_device *pdev) · line 2224
Quoted 10 lines
drivers/crypto/s5p-sss.c +3
-3if (IS_ERR (pdata->pclk)) { -dev_err (dev,"failed to find clock %s\n" , - variant->clk_names[1 ]); - err = -ENOENT ; + err =dev_err_probe (dev,PTR_ERR (pdata->pclk), +"failed to find clock %s\n" , + variant->clk_names[1 ]); goto err_clk; }
Herbert Xu
maintainerRe: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
In reply to Krzysztof KozlowskiQuoted 7 lines · Krzysztof Kozlowski
Pass the error directly from
devm_clk_get()to describe the real reason, instead of fixed ENOENT. Do not print error messages on deferred probe.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/crypto/s5p-sss.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 13 lines · Krzysztof Kozlowski
Correct a typo in the compatible - missing trailing 's'.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml +0
-0
Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml description: |+ · line 25
Quoted 8 lines
Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml +1
-1@@ -19,7 +19,7 @@ description: |+ properties: compatible: items: - - const: samsung,exynos5433-slim-ss + - const: samsung,exynos5433-slim-sss reg: maxItems: 1
Krzysztof Kozlowski
maintainerQuoted 22 lines · Kamil Konieczny
Quoted 18 lines · Krzysztof Kozlowski
Correct a typo in the compatible - missing trailing 's'.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml +1
-1@@ -19,7 +19,7 @@ description: |+ properties: compatible: items: - - const: samsung,exynos5433-slim-ss + - const: samsung,exynos5433-slim-sss
Quoted 6 lines
Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml description: |+ · line 25
Quoted 3 lines
Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml +0
-0reg: maxItems: 1Reviewed-by Kamil Konieczny <[email protected]>Acked-by Kamil Konieczny <[email protected]>
Thanks. In this case "Reviewed" is enough, it includes the meaning of Ack.
Best regards,
Krzysztof
Quoted 7 lines · Krzysztof Kozlowski
Correct a typo in the compatible - missing trailing 's'.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!