Skip to contentSkip to conversation

package/wolfssl: disable examples and tests

PATCH New Fabrice Fontaine 3 participants 3 messages Sep 2, 2020 – Sep 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wolfssl: disable examples and tests

Examples and tests are not needed especially because of them fails on some architectures because it wrongly tries to use wc_Sha256FinalRaw:

CCLD tests/unit.test
/tmp/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-none-linux-gnu/9.2.1/../../../../aarch64-none-linux-gnu/bin/ld: tests/tests_unit_test-api.o: in function `test_wc_Sha256FinalRaw':
/tmp/instance-0/output-1/build/wolfssl-4.5.0-stable/tests/api.c:6504: undefined reference to `wc_Sha256FinalRaw'

Fixes:
- http://autobuild.buildroot.org/results/d5b6f97f7510874fe28c675e599be08cb8a78c7b

---
 package/wolfssl/wolfssl.mk | 2 ++
 1 file changed, 2 insertions(+)
package/wolfssl/wolfssl.mk +2 -0
index 5400b35fa5..e2833144fb 100644
@@ -17,6 +17,8 @@ WOLFSSL_DEPENDENCIES = host-pkgconf
 # script, so we need autoreconf
 WOLFSSL_AUTORECONF = YES
 
+WOLFSSL_CONF_OPTS = --disable-examples --disable-crypttests
+
 ifeq ($(BR2_PACKAGE_WOLFSSL_ALL),y)
 WOLFSSL_CONF_OPTS += --enable-all
 else
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/wolfssl: disable examples and tests

Quoted 7 lines · On Wed, 2 Sep 2020 22:43:10 +0200 Fabrice Fontaine…

Examples and tests are not needed especially because of them fails on some architectures because it wrongly tries to use wc_Sha256FinalRaw:

CCLD tests/unit.test
/tmp/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-none-linux-gnu/9.2.1/../../../../aarch64-none-linux-gnu/bin/ld: tests/tests_unit_test-api.o: in function `test_wc_Sha256FinalRaw':
/tmp/instance-0/output-1/build/wolfssl-4.5.0-stable/tests/api.c:6504: undefined reference to `wc_Sha256FinalRaw'

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/d5b6f97f7510874fe28c675e599be08cb8a78c7b

---
 package/wolfssl/wolfssl.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks. However, this sort of commit log still lacks one very fundamental information: since when this problem is happening. Without this information, we have no idea if this patch needs to be backported to our stable branches. Could you pay attention to this in your next submission of fixes ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/wolfssl: disable examples and tests

In reply to Fabrice Fontaine
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Examples and tests are not needed especially because of them fails on some architectures because it wrongly tries to use wc_Sha256FinalRaw:

Quoted 8 lines

CCLD tests/unit.test
/tmp/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-none-linux-gnu/9.2.1/../../../../aarch64-none-linux-gnu/bin/ld: tests/tests_unit_test-api.o: in function `test_wc_Sha256FinalRaw':
/tmp/instance-0/output-1/build/wolfssl-4.5.0-stable/tests/api.c:6504: undefined reference to `wc_Sha256FinalRaw'

Fixes:
- http://autobuild.buildroot.org/results/d5b6f97f7510874fe28c675e599be08cb8a78c7b

Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard