Skip to contentSkip to conversation

dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset

PATCH Superseded Corentin Labbe 2 participants 2 messages Sep 3, 2020 – Sep 4, 2020

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset

When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. Furthermore, there are no need to use items to list only one compatible in compatible list.

Fixes f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")

---
Change since v1:
- use an enum for adding allwinner,sun8i-a33-crypto to "reset list"

 .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml        | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml +4 -3
index fc823572bcff..279f4a2e1dd7 100644
@@ -23,8 +23,7 @@ properties:
       - items:
           - const: allwinner,sun7i-a20-crypto
           - const: allwinner,sun4i-a10-crypto
-      - items:
-          - const: allwinner,sun8i-a33-crypto
+      - const: allwinner,sun8i-a33-crypto
 
   reg:
     maxItems: 1
@@ -59,7 +58,9 @@ if:
   properties:
     compatible:
       contains:
-        const: allwinner,sun6i-a31-crypto
+        enum:
+          - const: allwinner,sun6i-a31-crypto
+          - const: allwinner,sun8i-a33-crypto
 
 then:
   required:
Signature · 1 line
2.26.2
#1 lore raw
Quoted 28 lines · Corentin Labbe

When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. Furthermore, there are no need to use items to list only one compatible in compatible list.

Fixes f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")

---
Change since v1:
- use an enum for adding allwinner,sun8i-a33-crypto to "reset list"

 .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml        | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml +1 -2
index fc823572bcff..279f4a2e1dd7 100644
@@ -23,8 +23,7 @@ properties:
       - items:
           - const: allwinner,sun7i-a20-crypto
           - const: allwinner,sun4i-a10-crypto
-      - items:
-          - const: allwinner,sun8i-a33-crypto
+      - const: allwinner,sun8i-a33-crypto
 
   reg:
     maxItems: 1

Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml if: · line 63

Quoted 7 lines
Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml +3 -1
@@ -59,7 +58,9 @@ if:
   properties:
     compatible:
       contains:
-        const: allwinner,sun6i-a31-crypto
+        enum:
+          - const: allwinner,sun6i-a31-crypto
+          - const: allwinner,sun8i-a33-crypto

That's not the proper syntax for an enum, this would be

Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml if: · line 66

Quoted 3 lines
Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml +3 -0
+        enum:
+          - allwinner,sun6i-a31-crypto
+          - allwinner,sun8i-a33-crypto

Maxime

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel