iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header
PATCH 1/1 iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header
Static analyzer is not happy about intel_iommu_gfx_mapped declaration:
.../drivers/iommu/intel/iommu.c:364:5: warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?
Move its declaration to Intel IOMMU header file.
--- include/drm/intel-gtt.h | 5 +---- include/linux/intel-iommu.h | 1 + 2 files changed, 2 insertions(+), 4 deletions(-)
include/drm/intel-gtt.h +1 -4
@@ -5,6 +5,7 @@#define _DRM_INTEL_GTT_H#include <linux/agp_backend.h> +#include <linux/intel-iommu.h> #include <linux/kernel.h> void intel_gtt_get(u64 *gtt_total,
@@ -33,8 +34,4 @@ void intel_gtt_clear_range(unsigned int first_entry, unsigned int num_entries);/* flag for GFDT type */ #define AGP_USER_CACHED_MEMORY_GFDT (1 << 3) -#ifdef CONFIG_INTEL_IOMMU -extern int intel_iommu_gfx_mapped; -#endif -#endif
include/linux/intel-iommu.h +1 -0
@@ -794,6 +794,7 @@ extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu);extern int dmar_disabled;extern int intel_iommu_enabled;extern int intel_iommu_tboot_noforce; +extern int intel_iommu_gfx_mapped;#else static inline int iommu_calculate_agaw (struct intel_iommu *iommu) {
Signature · 6 lines
2.28.0 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi Andy,
Quoted 39 lines · Andy Shevchenko
Static analyzer is not happy about
intel_iommu_gfx_mappeddeclaration:
.../drivers/iommu/intel/iommu.c:364:5: warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?Move its declaration to Intel IOMMU header file.
Signed-off-by Andy Shevchenko <[email protected]>--- include/drm/intel-gtt.h | 5 +---- include/linux/intel-iommu.h | 1 + 2 files changed, 2 insertions(+), 4 deletions(-)include/drm/intel-gtt.h +1
-4@@ -5,6 +5,7 @@#define _DRM_INTEL_GTT_H#include <linux/agp_backend.h> +#include <linux/intel-iommu.h> #include <linux/kernel.h> void intel_gtt_get(u64 *gtt_total,@@ -33,8 +34,4 @@ void intel_gtt_clear_range(unsigned int first_entry, unsigned int num_entries);/* flag for GFDT type */ #define AGP_USER_CACHED_MEMORY_GFDT (1 << 3) -#ifdef CONFIG_INTEL_IOMMU -extern int intel_iommu_gfx_mapped; -#endif -#endif include/linux/intel-iommu.h +0
-0
include/linux/intel-iommu.h extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu); · line 800
Quoted 7 lines
include/linux/intel-iommu.h +1
-0@@ -794,6 +794,7 @@ extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu);extern int dmar_disabled;extern int intel_iommu_enabled;extern int intel_iommu_tboot_noforce; +extern int intel_iommu_gfx_mapped;#else static inline int iommu_calculate_agaw (struct intel_iommu *iommu) {
Looks good to me.
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Joerg Roedel
AppliedQuoted 11 lines · Andy Shevchenko
Static analyzer is not happy about
intel_iommu_gfx_mappeddeclaration:
.../drivers/iommu/intel/iommu.c:364:5: warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?Move its declaration to Intel IOMMU header file.
Signed-off-by Andy Shevchenko <[email protected]>--- include/drm/intel-gtt.h | 5 +---- include/linux/intel-iommu.h | 1 + 2 files changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu