Skip to contentSkip to conversation

can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME

PATCH In review Wang Hai 2 participants 2 messages Sep 4, 2020 – Sep 15, 2020

Subsystems (3)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH 1/1 can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME

KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced. So better to remove it.

---
 drivers/net/can/kvaser_pciefd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/can/kvaser_pciefd.c +0 -1
index 6f766918211a..c0b18ff107c7 100644
@@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
 
 /* Kvaser KCAN definitions */
 #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
-#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
 
 #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
 /* Request status packet */
Signature · 1 line
2.17.1
#1 lore raw
Quoted 15 lines · Wang Hai

KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced. So better to remove it.

---
 drivers/net/can/kvaser_pciefd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/can/kvaser_pciefd.c +0 -0
index 6f766918211a..c0b18ff107c7 100644

drivers/net/can/kvaser_pciefd.c MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices"); · line 136

Quoted 7 lines
drivers/net/can/kvaser_pciefd.c +0 -1
@@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
 
 /* Kvaser KCAN definitions */
 #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
-#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
 
 #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
 /* Request status packet */

I'd like to keep this for documentation purpose, too.

Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |