Skip to contentSkip to conversation

watchdog: it87_wdt: add IT8772 ID

PATCH In review Hanspeter Portner 2 participants 4 messages Sep 4, 2020 – Sep 5, 2020 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 watchdog: it87_wdt: add IT8772 ID

IT8772 watchdog works as in IT872x

Tested on SHAREVDI K6-F12 board.

---
 drivers/watchdog/it87_wdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/watchdog/it87_wdt.c +3 -1
index f3bf3ea50e39..2dac0ba551ce 100644
@@ -15,7 +15,7 @@
  *	Support of the watchdog timers, which are available on
  *	IT8607, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665, IT8686,
  *	IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726, IT8728,
- *	and IT8783.
+ *	IT8772 and IT8783.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
@@ -66,6 +66,7 @@
 #define IT8721_ID	0x8721
 #define IT8726_ID	0x8726	/* the data sheet suggest wrongly 0x8716 */
 #define IT8728_ID	0x8728
+#define IT8772_ID	0x8772
 #define IT8783_ID	0x8783
 #define IT8786_ID	0x8786
 
@@ -294,6 +295,7 @@ static int __init it87_wdt_init(void)
 	case IT8720_ID:
 	case IT8721_ID:
 	case IT8728_ID:
+	case IT8772_ID:
 	case IT8783_ID:
 	case IT8786_ID:
 		max_units = 65535;
Signature · 1 line
2.28.0
#1 lore raw

PATCH 2/2 watchdog: it87_wdt: add IT8784 ID

IT8784 watchdog works as in IT878x

Tested on SHAREVDY K10 board.

---
 drivers/watchdog/it87_wdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/watchdog/it87_wdt.c +3 -1
index 2dac0ba551ce..2b4831842162 100644
@@ -15,7 +15,7 @@
  *	Support of the watchdog timers, which are available on
  *	IT8607, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665, IT8686,
  *	IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726, IT8728,
- *	IT8772 and IT8783.
+ *	IT8772, IT8783 and IT8784.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
@@ -68,6 +68,7 @@
 #define IT8728_ID	0x8728
 #define IT8772_ID	0x8772
 #define IT8783_ID	0x8783
+#define IT8784_ID	0x8784
 #define IT8786_ID	0x8786
 
 /* GPIO Configuration Registers LDN=0x07 */
@@ -297,6 +298,7 @@ static int __init it87_wdt_init(void)
 	case IT8728_ID:
 	case IT8772_ID:
 	case IT8783_ID:
+	case IT8784_ID:
 	case IT8786_ID:
 		max_units = 65535;
 		break;
Signature · 1 line
2.28.0
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] watchdog: it87_wdt: add IT8784 ID

Quoted 5 lines · Hanspeter Portner

IT8784 watchdog works as in IT878x

Tested on SHAREVDY K10 board.

Quoted 34 lines
---
 drivers/watchdog/it87_wdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/watchdog/it87_wdt.c +3 -1
index 2dac0ba551ce..2b4831842162 100644
@@ -15,7 +15,7 @@
  *	Support of the watchdog timers, which are available on
  *	IT8607, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665, IT8686,
  *	IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726, IT8728,
- *	IT8772 and IT8783.
+ *	IT8772, IT8783 and IT8784.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
@@ -68,6 +68,7 @@
 #define IT8728_ID	0x8728
 #define IT8772_ID	0x8772
 #define IT8783_ID	0x8783
+#define IT8784_ID	0x8784
 #define IT8786_ID	0x8786
 
 /* GPIO Configuration Registers LDN=0x07 */
@@ -297,6 +298,7 @@ static int __init it87_wdt_init(void)
 	case IT8728_ID:
 	case IT8772_ID:
 	case IT8783_ID:
+	case IT8784_ID:
 	case IT8786_ID:
 		max_units = 65535;
 		break;
maintainer
#3 lore raw
In reply to Hanspeter Portner
Quoted 6 lines · Hanspeter Portner

IT8772 watchdog works as in IT872x

Tested on SHAREVDI K6-F12 board.

Please do not resend patches without versioning.

Guenter

Quoted 34 lines
---
 drivers/watchdog/it87_wdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/watchdog/it87_wdt.c +3 -1
index f3bf3ea50e39..2dac0ba551ce 100644
@@ -15,7 +15,7 @@
  *	Support of the watchdog timers, which are available on
  *	IT8607, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665, IT8686,
  *	IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726, IT8728,
- *	and IT8783.
+ *	IT8772 and IT8783.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
@@ -66,6 +66,7 @@
 #define IT8721_ID	0x8721
 #define IT8726_ID	0x8726	/* the data sheet suggest wrongly 0x8716 */
 #define IT8728_ID	0x8728
+#define IT8772_ID	0x8772
 #define IT8783_ID	0x8783
 #define IT8786_ID	0x8786
 
@@ -294,6 +295,7 @@ static int __init it87_wdt_init(void)
 	case IT8720_ID:
 	case IT8721_ID:
 	case IT8728_ID:
+	case IT8772_ID:
 	case IT8783_ID:
 	case IT8786_ID:
 		max_units = 65535;