Skip to contentSkip to conversation

riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration

PATCH In review Pekka Enberg 2 participants 2 messages Sep 5, 2020 – Sep 9, 2020 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv/mm/fault: Fix inline placement in vmalloc_fault() declaration

The "inline" keyword is in the wrong place in vmalloc_fault() declaration:

Quoted 1 line
Quoted 1 line

arch/riscv/mm/fault.c:56:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

56 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
| ^~~~~~

Fix that up.

---
 arch/riscv/mm/fault.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/mm/fault.c +1 -1
index a23eaf5ce95c..a173432ccf82 100644
@@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
 	no_context(regs, addr);
 }
 
-static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
+static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
 {
 	pgd_t *pgd, *pgd_k;
 	pud_t *pud, *pud_k;
Signature · 7 lines
2.26.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
maintainer
#1 lore raw
Quoted 20 lines · On Fri, 04 Sep 2020 22:52:52 PDT (-0700), [email protected] wrote:

The "inline" keyword is in the wrong place in vmalloc_fault() declaration:

Quoted 1 line
Quoted 1 line

arch/riscv/mm/fault.c:56:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]

56 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
| ^~~~~~

Fix that up.

---
 arch/riscv/mm/fault.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/mm/fault.c +0 -0
index a23eaf5ce95c..a173432ccf82 100644

arch/riscv/mm/fault.c static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code · line 84

Quoted 8 lines
arch/riscv/mm/fault.c +1 -1
@@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
 	no_context(regs, addr);
 }
 
-static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
+static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
 {
 	pgd_t *pgd, *pgd_k;
 	pud_t *pud, *pud_k;

Thanks, this is on for-next.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv