package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
PATCH 1/1 package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
--- package/gnuplot/0002-without-history.patch | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 package/gnuplot/0002-without-history.patch
package/gnuplot/0002-without-history.patch new file +18 -0
@@ -0,0 +1,18 @@ +Patch to solve the 'undefined reference to gp_read_history' + +Signed-off-by: Michael Fischer <[email protected]> + + +diff -Naur a/src/history.c b/src/history.c +--- a/src/history.c 2020-09-03 14:48:47.875493026 +0200 ++++ b/src/history.c 2020-09-03 14:50:39.493972218 +0200 +@@ -91,7 +91,9 @@ + void + read_history(char *filename) + { ++#ifdef GNUPLOT_HISTORY + gp_read_history(filename); ++#endif + } + +
Signature · 1 line
2.28.0
PATCH 1/1 package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
Micheal, All,
On 2020-09-03 15:30 +0200, Michael Fischer spake thusly:
Quoted 1 line
Signed-off-by Michael Fischer <[email protected]>
Thanks for this patch.
This is fixing autobuilder failures, so a reference to at least one would have been good:
Fixes:
http://autobuild.buildroot.org/results/095/0956bc50b9823374254a2032d7897d48aff2d1fa/Quoted 11 lines
--- package/gnuplot/0002-without-history.patch | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 package/gnuplot/0002-without-history.patchpackage/gnuplot/0002-without-history.patch new file +0
-0
package/gnuplot/0002-without-history.patch line 3
Quoted 3 lines
package/gnuplot/0002-without-history.patch new file +3
-0@@ -0,0 +1,18 @@ +Patch to solve the 'undefined reference to gp_read_history' + +Signed-off-by: Michael Fischer <[email protected]>
Since gnuplot uses git, we need that patch to be git-formatted:
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
(Yes I know the existing patch does not conform to that requirement, but that is a old patch, from before we started enforcing any coding style.)
Also, did you send that patch upstream? If so, it would be super nice that you include the URL to the bug-report, or mailing post, so that we eventually bump gnuplot, we can get rid of that patch.
Care to rework and respin, please?
Regards,
Yann E. MORIN.
Quoted 20 lines
package/gnuplot/0002-without-history.patch new file +13
-0+diff -Naur a/src/history.c b/src/history.c +--- a/src/history.c 2020-09-03 14:48:47.875493026 +0200 ++++ b/src/history.c 2020-09-03 14:50:39.493972218 +0200 +@@ -91,7 +91,9 @@ + void + read_history(char *filename) + { ++#ifdef GNUPLOT_HISTORY + gp_read_history(filename); ++#endif + } + +Signature · 6 lines
2.28.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
I'm on vacation this week.
So it takes a while.
Regards
Michael.
-------- Urspr?ngliche Nachricht --------
Von: "Yann E. MORIN" <[email protected]>
Datum: 05.09.20 09:52 (GMT+01:00)
An: Michael Fischer <[email protected]>
Cc: buildroot at busybox.net
Betreff: Re: [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
Micheal, All,
On 2020-09-03 15:30 +0200, Michael Fischer spake thusly:
Quoted 1 line
Signed-off-by Michael Fischer <[email protected]>
Thanks for this patch.
This is fixing autobuilder failures, so a reference to at least one would have been good:
Fixes:
http://autobuild.buildroot.org/results/095/0956bc50b9823374254a2032d7897d48aff2d1fa/Quoted 11 lines
--- package/gnuplot/0002-without-history.patch | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 package/gnuplot/0002-without-history.patchpackage/gnuplot/0002-without-history.patch new file +0
-0
package/gnuplot/0002-without-history.patch line 3
Quoted 3 lines
package/gnuplot/0002-without-history.patch new file +3
-0@@ -0,0 +1,18 @@ +Patch to solve the 'undefined reference to gp_read_history' + +Signed-off-by: Michael Fischer <[email protected]>
Since gnuplot uses git, we need that patch to be git-formatted:
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
(Yes I know the existing patch does not conform to that requirement, but that is a old patch, from before we started enforcing any coding style.)
Also, did you send that patch upstream? If so, it would be super nice that you include the URL to the bug-report, or mailing post, so that we eventually bump gnuplot, we can get rid of that patch.
Care to rework and respin, please?
Regards,
Yann E. MORIN.
Quoted 16 lines
package/gnuplot/0002-without-history.patch new file +13
-1+diff -Naur a/src/history.c b/src/history.c +--- a/src/history.c 2020-09-03 14:48:47.875493026 +0200 ++++ b/src/history.c 2020-09-03 14:50:39.493972218 +0200 +@@ -91,7 +91,9 @@ + void + read_history(char *filename) + { ++#ifdef GNUPLOT_HISTORY + gp_read_history(filename); ++#endif + } + + --2.28.0
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200908/21c704d9/attachment.html>