package/mrp: new package
PATCH v2 1/1 package/mrp: new package
Signed-off-by Horatiu Vultur <[email protected]>
---
v1 -> v2:
- add missing dependencies
- update license
- add comment in case dependecies are missing
--- DEVELOPERS | 1 + package/Config.in | 1 + package/mrp/Config.in | 17 +++++++++++++++++ package/mrp/mrp.hash | 3 +++ package/mrp/mrp.mk | 13 +++++++++++++ 5 files changed, 35 insertions(+) create mode 100644 package/mrp/Config.in create mode 100644 package/mrp/mrp.hash create mode 100644 package/mrp/mrp.mk
DEVELOPERS +1 -0
@@ -1120,6 +1120,7 @@ F: package/squeezelite/ N: Horatiu Vultur <[email protected]> F: package/easyframes/ +F: package/mrp/ N: Ian Haylock <[email protected]> F: package/python-rpi-gpio/
package/Config.in +1 -0
@@ -2129,6 +2129,7 @@ menu "Networking applications" source "package/mosh/Config.in" source "package/mosquitto/Config.in" source "package/mrouted/Config.in" + source "package/mrp/Config.in" source "package/mtr/Config.in" source "package/nbd/Config.in" source "package/ncftp/Config.in"
package/mrp/Config.in new file +17 -0
@@ -0,0 +1,17 @@ +config BR2_PACKAGE_MRP + bool "mrp" + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0 + select BR2_PACKAGE_LIBEV + select BR2_PACKAGE_LIBMNL + select BR2_PACKAGE_LIBNL + help + This is the userspace application that configures the kernel + to run MRP protocol. The userspace application is made of 2 + applications, one deamon and a client. + + https://github.com/microchip-ung/mrp + +comment "mrp needs a toolchain /w threads, headers >= 5.0" + depends on !BR2_TOOLCHAIN_HAS_THREADS \ + || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0
package/mrp/mrp.hash new file +3 -0
@@ -0,0 +1,3 @@ +# locally calculated +sha256 1a6c76d058bb425a7ec8b69a65de797650961161ec016b51ac8a1965e1ac304f mrp-1.1.tar.gz +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 LICENSE
package/mrp/mrp.mk new file +13 -0
@@ -0,0 +1,13 @@ +################################################################################ +# +# mrp +# +################################################################################ + +MRP_VERSION = 1.1 +MRP_SITE = $(call github,microchip-ung,mrp,v$(MRP_VERSION)) +MRP_DEPENDENCIES = libev libmnl libnl +MRP_LICENSE = GPL-2.0+ +MRP_LICENSE_FILES = LICENSE + +$(eval $(cmake-package))
Signature · 1 line
2.27.0
PATCH v2 1/1 package/mrp: new package
Hello Horatiu,
Quoted 1 line · On Mon, 31 Aug 2020 20:25:40 +0200 Horatiu Vultur via buildroot…
Signed-off-by Horatiu Vultur <[email protected]>
I've applied to master. See below for a few comments.
Quoted 7 lines
package/mrp/Config.in new file +1
-0@@ -0,0 +1,17 @@ +config BR2_PACKAGE_MRP
package/mrp/Config.in line 11
Quoted 10 lines
package/mrp/Config.in new file +10
-0+ bool "mrp" + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0 + select BR2_PACKAGE_LIBEV + select BR2_PACKAGE_LIBMNL + select BR2_PACKAGE_LIBNL + help + This is the userspace application that configures the kernel + to run MRP protocol. The userspace application is made of 2 + applications, one deamon and a client.
Typo: deamon -> daemon.
Since there is a daemon, perhaps it makes sense to have an init script and/or systemd unit file for it ?
package/mrp/Config.in line 15
Quoted 3 lines
package/mrp/Config.in new file +3
-0+ https://github.com/microchip-ung/mrp + +comment "mrp needs a toolchain /w threads, headers >= 5.0"
/w should have been w/
package/mrp/Config.in
Quoted 4 lines
package/mrp/Config.in new file +4
-0+MRP_VERSION = 1.1 +MRP_SITE = $(call github,microchip-ung,mrp,v$(MRP_VERSION)) +MRP_DEPENDENCIES = libev libmnl libnl +MRP_LICENSE = GPL-2.0+
All the SPDX statements in the source code indicate GPL-2.0, except the bits of kernel headers that are imported, which are GPL-2.0+. So the overall license really is GPL-2.0. I fixed that when applying.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com