PCI: keystone: Enable compile-testing on !ARM
Subsystems (3)
PATCH 1/1 PCI: keystone: Enable compile-testing on !ARM
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Build-tested on x86 with allyesconfig.
--- drivers/pci/controller/dwc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/Kconfig +2 -2
@@ -107,7 +107,7 @@ config PCI_KEYSTONE config PCI_KEYSTONE_HOST bool "PCI Keystone Host Mode" - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST select PCI_KEYSTONE
@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST config PCI_KEYSTONE_EP bool "PCI Keystone Endpoint Mode" - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST depends on PCI_ENDPOINT select PCIE_DW_EP select PCI_KEYSTONE
Signature · 1 line
2.28.0
Quoted 6 lines · Alex Dewar
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Build-tested on x86 with allyesconfig.
You should at least build it on x86_64, powerpc and MIPS. These are widely available (e.g. in most of distros, or here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also riscv and sh (specially sh lacks certain headers/features).
Best regards,
Krzysztof
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Alex Dewar
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Quoted 6 lines
Quoted 1 line
Build-tested on x86 with allyesconfig.
You should at least build it on
x86_64, powerpc and MIPS. These are widely available (e.g. in most of distros, or here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also riscv and sh (specially sh lacks certain headers/features).
Good suggestion. I've built it on x86, ppc, mips and riscv. sh wouldn't build because of some kbuild dependency, rather than a compiler error. I'll send a v2 with an updated commit message.
Quoted 3 lines
Best regards,
Krzysztof
PATCH v2 1/1 PCI: keystone: Enable compile-testing on !ARM
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Build-tested with allyesconfig on x86, ppc, mips and riscv.
--- drivers/pci/controller/dwc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/controller/dwc/Kconfig +2 -2
@@ -107,7 +107,7 @@ config PCI_KEYSTONE config PCI_KEYSTONE_HOST bool "PCI Keystone Host Mode" - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST select PCI_KEYSTONE
@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST config PCI_KEYSTONE_EP bool "PCI Keystone Endpoint Mode" - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST depends on PCI_ENDPOINT select PCIE_DW_EP select PCI_KEYSTONE
Signature · 7 lines
2.28.0 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 3 lines · Alex Dewar
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Friendly ping?
Quoted 30 lines
Build-tested with allyesconfig on x86, ppc, mips and riscv.
Signed-off-by Alex Dewar <[email protected]>--- drivers/pci/controller/dwc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pci/controller/dwc/Kconfig +2
-2@@ -107,7 +107,7 @@ config PCI_KEYSTONE config PCI_KEYSTONE_HOST bool "PCI Keystone Host Mode" - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST select PCI_KEYSTONE@@ -119,7 +119,7 @@ config PCI_KEYSTONE_HOST config PCI_KEYSTONE_EP bool "PCI Keystone Endpoint Mode" - depends on ARCH_KEYSTONE || ARCH_K3 || ((ARM || ARM64) && COMPILE_TEST) + depends on ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST depends on PCI_ENDPOINT select PCIE_DW_EP select PCI_KEYSTONE
Quoted 11 lines · Alex Dewar
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Build-tested with allyesconfig on x86, ppc, mips and riscv.
Signed-off-by Alex Dewar <[email protected]>--- drivers/pci/controller/dwc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines · Rob Herring
Quoted 4 lines · Alex Dewar
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Quoted 8 lines
Quoted 7 lines
Build-tested with allyesconfig on x86, ppc, mips and riscv.
Signed-off-by Alex Dewar <[email protected]>--- drivers/pci/controller/dwc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Acked-by Rob Herring <[email protected]>
Ping ping? :-)
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Lorenzo Pieralisi
AppliedQuoted 5 lines · Alex Dewar
Currently the Keystone driver can only be compile-tested on ARM, but this restriction seems unnecessary. Get rid of it to increase test coverage.
Build-tested with allyesconfig on x86, ppc, mips and riscv.
Applied to pci/keystone, thanks!
[1/1] PCI: keystone: Enable compile-testing on !ARM
https://git.kernel.org/lpieralisi/pci/c/476b70b4d1
Thanks,
Lorenzo