Skip to contentSkip to conversation

tisdk-default-image: add opencv

PATCH NAK Subhajit Paul 2 participants 2 messages Sep 7, 2020 – Sep 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tisdk-default-image: add opencv

---
 .../images/tisdk-default-image.bb             | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +37 -0
index ce4287ae..3b3a61b5 100644
@@ -24,6 +24,43 @@ IMAGE_INSTALL += "\
     ${@bb.utils.contains('MACHINE_FEATURES','gpu','packagegroup-arago-tisdk-hmi','packagegroup-arago-base-tisdk-server-extra',d)} \
     ti-analytics \
     ti-demos \
+    python3-opencv \
+    libopencv-aruco-dev \
+    libopencv-bgsegm-dev \
+    libopencv-bioinspired-dev \
+    libopencv-calib3d-dev \
+    libopencv-ccalib-dev \
+    libopencv-core-dev \
+    libopencv-face-dev \
+    libopencv-features2d-dev \
+    libopencv-flann-dev \
+    libopencv-fuzzy-dev \
+    libopencv-hfs-dev \
+    libopencv-highgui-dev \
+    libopencv-img-hash-dev \
+    libopencv-imgcodecs-dev \
+    libopencv-imgproc-dev \
+    libopencv-line-descriptor-dev \
+    libopencv-ml-dev \
+    libopencv-objdetect-dev \
+    libopencv-optflow-dev \
+    libopencv-photo-dev \
+    libopencv-plot-dev \
+    libopencv-quality-dev \
+    libopencv-reg-dev \
+    libopencv-rgbd-dev \
+    libopencv-saliency-dev \
+    libopencv-sfm-dev \
+    libopencv-shape-dev \
+    libopencv-stitching-dev \
+    libopencv-structured-light-dev \
+    libopencv-surface-matching-dev \
+    libopencv-tracking-dev \
+    libopencv-video-dev \
+    libopencv-videoio-dev \
+    libopencv-xfeatures2d-dev \
+    libopencv-ximgproc-dev \
+    libopencv-xphoto-dev \
 "
 
 export IMAGE_BASENAME = "tisdk-default-image"
Signature · 1 line
2.17.1
#1 lore raw

NAK!

This is wrong on so many levels...
It adds individual packages directly to the image, not a packagegroup. It adds those packages to all platforms, regardless of the support. It adds development packages to the rootfs, which would bring tons of dependencies, especially to low-level platforms with limited resources. If this is needed for a specific Product Line, please add it there, not to CoreSDK.

Signature · 1 line
Denys
Quoted 56 lines · Subhajit Paul
---
 .../images/tisdk-default-image.bb             | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +37 -0
index ce4287ae..3b3a61b5 100644
@@ -24,6 +24,43 @@ IMAGE_INSTALL += "\
     ${@bb.utils.contains('MACHINE_FEATURES','gpu','packagegroup-arago-tisdk-hmi','packagegroup-arago-base-tisdk-server-extra',d)} \
     ti-analytics \
     ti-demos \
+    python3-opencv \
+    libopencv-aruco-dev \
+    libopencv-bgsegm-dev \
+    libopencv-bioinspired-dev \
+    libopencv-calib3d-dev \
+    libopencv-ccalib-dev \
+    libopencv-core-dev \
+    libopencv-face-dev \
+    libopencv-features2d-dev \
+    libopencv-flann-dev \
+    libopencv-fuzzy-dev \
+    libopencv-hfs-dev \
+    libopencv-highgui-dev \
+    libopencv-img-hash-dev \
+    libopencv-imgcodecs-dev \
+    libopencv-imgproc-dev \
+    libopencv-line-descriptor-dev \
+    libopencv-ml-dev \
+    libopencv-objdetect-dev \
+    libopencv-optflow-dev \
+    libopencv-photo-dev \
+    libopencv-plot-dev \
+    libopencv-quality-dev \
+    libopencv-reg-dev \
+    libopencv-rgbd-dev \
+    libopencv-saliency-dev \
+    libopencv-sfm-dev \
+    libopencv-shape-dev \
+    libopencv-stitching-dev \
+    libopencv-structured-light-dev \
+    libopencv-surface-matching-dev \
+    libopencv-tracking-dev \
+    libopencv-video-dev \
+    libopencv-videoio-dev \
+    libopencv-xfeatures2d-dev \
+    libopencv-ximgproc-dev \
+    libopencv-xphoto-dev \
 "
 
 export IMAGE_BASENAME = "tisdk-default-image"
Signature · 1 line
2.17.1