powerpc/papr_scm: Limit the readability of 'perf_stats' sysfs attribute
Subsystems (2)
PATCH v2 1/1 powerpc/papr_scm: Limit the readability of 'perf_stats' sysfs attribute
The newly introduced 'perf_stats' attribute uses the default access mode of 0444 letting non-root users access performance stats of an nvdimm and potentially force the kernel into issuing large number of expensive HCALLs. Since the information exposed by this attribute cannot be cached hence its better to ward of access to this attribute from users who don't need to access these performance statistics.
Hence this patch updates access mode of 'perf_stats' attribute to be only readable by root users.
---
Change-log:
v2:
* Instead of checking for perfmon_capable() inside show_perf_stats() set the attribute as DEVICE_ATTR_ADMIN_RO [ Aneesh ]
* Update patch description
--- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/platforms/pseries/papr_scm.c +1 -1
@@ -822,7 +822,7 @@ static ssize_t perf_stats_show(struct device *dev,kfree (stats);return rc ? rc :seq_buf_used (&s); } -DEVICE_ATTR_RO (perf_stats); +DEVICE_ATTR_ADMIN_RO (perf_stats);static ssize_t flags_show (struct device *dev,struct device_attribute *attr,char *buf)
Signature · 4 lines
2.26.2 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Quoted 5 lines · Vaibhav Jain
The newly introduced '
perf_stats' attribute uses the default access mode of 0444 letting non-root users access performance stats of an nvdimm and potentially force the kernel into issuing large number of expensive HCALLs. Since the information exposed by this attribute cannot be cached hence its better to ward of access to this attribute
^^^
off?Quoted 4 lines
from users who don't need to access these performance statistics.
Hence this patch updates access mode of '
perf_stats' attribute to be only readable by root users.
Generally it is bad form to say "this patch". See 4c here:
-- https://www.ozlabs.org/~akpm/stuff/tpp.txt
But I'm not picky... :-D
With the s/of/off/ change:
Quoted 31 lines
Fixes 2d02bf835e573 ('powerpc/papr_scm: Fetch nvdimm performance stats from PHYP')Reported-by Aneesh Kumar K.V <[email protected]>Signed-off-by Vaibhav Jain <[email protected]>---
Change-log:v2:
* Instead of checking forperfmon_capable()insideshow_perf_stats()set the attribute asDEVICE_ATTR_ADMIN_RO[ Aneesh ]
* Update patch description--- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/platforms/pseries/papr_scm.c +1
-1@@ -822,7 +822,7 @@ static ssize_t perf_stats_show(struct device *dev,kfree (stats);return rc ? rc :seq_buf_used (&s); } -DEVICE_ATTR_RO (perf_stats); +DEVICE_ATTR_ADMIN_RO (perf_stats);static ssize_t flags_show (struct device *dev,struct device_attribute *attr,char *buf)Signature · 1 line
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Michael Ellerman
AppliedQuoted 8 lines · Vaibhav Jain
The newly introduced '
perf_stats' attribute uses the default access mode of 0444 letting non-root users access performance stats of an nvdimm and potentially force the kernel into issuing large number of expensive HCALLs. Since the information exposed by this attribute cannot be cached hence its better to ward of access to this attribute from users who don't need to access these performance statistics.[...]
Applied to powerpc/fixes.
[1/1] powerpc/papr_scm: Limit the readability of 'perf_stats' sysfs attribute
https://git.kernel.org/powerpc/c/0460534b532e5518c657c7d6492b9337d975eaa3
cheers
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]