net: ethernet: dnet: Remove set but unused variable 'len'
Subsystems (2)
PATCH 1/1 net: ethernet: dnet: Remove set but unused variable 'len'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/dnet.c: In function dnet_start_xmit drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)") involved this unused variable, remove it.
--- drivers/net/ethernet/dnet.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/dnet.c +1 -4
@@ -508,7 +508,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev)struct dnet *bp =netdev_priv (dev);u32 tx_status, irq_enable; -unsigned int len, i, tx_cmd, wrsz; +unsigned int i, tx_cmd, wrsz;unsigned long flags;unsigned int *bufp;
@@ -518,9 +518,6 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) skb->len, skb->head, skb->data);dnet_print_skb (skb); -/* frame size (words) */ - len = (skb->len +3 ) >>2 ; -spin_lock_irqsave (&bp->lock, flags); tx_status =dnet_readl (bp,TX_STATUS );
Signature · 1 line
2.17.1
Jakub Kicinski
maintainerQuoted 10 lines · On Mon, 7 Sep 2020 22:12:07 +0800 Wang Hai wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/dnet.c: In functiondnet_start_xmitdrivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]commit
4796417417a6("dnet: Dave DNET ethernet controller driver (updated)") involved this unused variable, remove it.Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>
tx_status is also not used. But I guess one change per commit, so applied. Thanks!