Skip to contentSkip to conversation

package/easyframes: fix missing dependency

PATCH New Horatiu Vultur 2 participants 2 messages Sep 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/easyframes: fix missing dependency

Easyframes uses fork when capturing frames in a pcap file, therefore add the dependency BR2_USE_MMU.

---
 package/easyframes/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/easyframes/Config.in +4 -0
index b2c45496b4..b2307fbf59 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_EASYFRAMES
 	bool "easyframes"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_LIBPCAP
 	help
 	  This is a small and simple command-line tool for network
@@ -8,3 +9,6 @@ config BR2_PACKAGE_EASYFRAMES
 	  received.
 
 	  https://github.com/microchip-ung/easyframes
+
+comment "easyframe needs a toolchain w/ MMU"
+	depends on !BR2_USE_MMU
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/easyframes: fix missing dependency

Quoted 20 lines · On Mon, 7 Sep 2020 22:27:55 +0200 Horatiu Vultur via buildroot…

Easyframes uses fork when capturing frames in a pcap file, therefore add the dependency BR2_USE_MMU.

---
 package/easyframes/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/easyframes/Config.in +1 -0
index b2c45496b4..b2307fbf59 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_EASYFRAMES
 	bool "easyframes"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_LIBPCAP
 	help
 	  This is a small and simple command-line tool for network

package/easyframes/Config.in config BR2_PACKAGE_EASYFRAMES · line 14

Quoted 6 lines
package/easyframes/Config.in +3 -0
@@ -8,3 +9,6 @@ config BR2_PACKAGE_EASYFRAMES
 	  received.
 
 	  https://github.com/microchip-ung/easyframes
+
+comment "easyframe needs a toolchain w/ MMU"
+	depends on !BR2_USE_MMU

We don't add Config.in comments for the MMU dependency. Indeed, you cannot change a toolchain to have MMU support: it's a characteristic of the CPU architecture. If you CPU architecture has no MMU, there's nothing you can do about it.

So I've dropped the Config.in comment, and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com