Skip to contentSkip to conversation

ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages Sep 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC Brian Kim <[email protected]>

---

I received some other warnings about this file, but with no details:

Quoted 1 line
Quoted 1 line

drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but

dereferenced.
--

Quoted 1 line
Quoted 1 line

drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by

free on line 229

tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access

:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)
drivers/char/exynos-gpiomem.c +0 -1
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,
#1 lore raw
Quoted 8 lines · Julia Lawall

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC Brian Kim <[email protected]>

Hi,

This is a downstream tree with certain non-upstreamable patches, so nothing to do here for me.

Best regards,
Krzysztof

Quoted 17 lines

---

I received some other warnings about this file, but with no details:

Quoted 1 line
Quoted 1 line

drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but

dereferenced.
--

Quoted 1 line
Quoted 1 line

drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by

free on line 229

tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access

:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago