dt-bindings: net: Correct interrupt flags in examples
Subsystems (5)
PATCH 1/1 dt-bindings: net: Correct interrupt flags in examples
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags, assuming the author of the code wanted some logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
--- Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +- Documentation/devicetree/bindings/net/nfc/nxp-nci.txt | 2 +- Documentation/devicetree/bindings/net/nfc/pn544.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/net/can/tcan4x5x.txt +1 -1
@@ -33,7 +33,7 @@ tcan4x5x: tcan4x5x@0 { spi-max-frequency = <10000000>; bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>; interrupt-parent = <&gpio1>; - interrupts = <14 GPIO_ACTIVE_LOW>; + interrupts = <14 IRQ_TYPE_LEVEL_LOW>; device-state-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; device-wake-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
Documentation/devicetree/bindings/net/nfc/nxp-nci.txt +1 -1
@@ -25,7 +25,7 @@ Example (for ARM-based BeagleBone with NPC100 NFC controller on I2C2): clock-frequency = <100000>; interrupt-parent = <&gpio1>; - interrupts = <29 GPIO_ACTIVE_HIGH>; + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>; enable-gpios = <&gpio0 30 GPIO_ACTIVE_HIGH>; firmware-gpios = <&gpio0 31 GPIO_ACTIVE_HIGH>;
Documentation/devicetree/bindings/net/nfc/pn544.txt +1 -1
@@ -25,7 +25,7 @@ Example (for ARM-based BeagleBone with PN544 on I2C2): clock-frequency = <400000>; interrupt-parent = <&gpio1>; - interrupts = <17 GPIO_ACTIVE_HIGH>; + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.17.1
Quoted 23 lines · Krzysztof Kozlowski
GPIO_ACTIVE_xflags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning:
1.GPIO_ACTIVE_HIGH= 0 =IRQ_TYPE_NONE
2.GPIO_ACTIVE_LOW= 1 =IRQ_TYPE_EDGE_RISINGCorrect the interrupt flags, assuming the author of the code wanted some logical behavior behind the name "
ACTIVE_xxx", this is:
ACTIVE_LOW=>IRQ_TYPE_LEVEL_LOW
ACTIVE_HIGH=>IRQ_TYPE_LEVEL_HIGHSigned-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +- Documentation/devicetree/bindings/net/nfc/nxp-nci.txt | 2 +- Documentation/devicetree/bindings/net/nfc/pn544.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/net/can/tcan4x5x.txt +0
-0
Documentation/devicetree/bindings/net/can/tcan4x5x.txt tcan4x5x: tcan4x5x@0 { · line 39
Quoted 8 lines
Documentation/devicetree/bindings/net/can/tcan4x5x.txt +1
-1@@ -33,7 +33,7 @@ tcan4x5x: tcan4x5x@0 { spi-max-frequency = <10000000>; bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>; interrupt-parent = <&gpio1>; - interrupts = <14 GPIO_ACTIVE_LOW>; + interrupts = <14 IRQ_TYPE_LEVEL_LOW>; device-state-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; device-wake-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
For the tcan4x5x.txt:
regards,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 11 lines · Krzysztof Kozlowski
GPIO_ACTIVE_xflags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning:
1.GPIO_ACTIVE_HIGH= 0 =IRQ_TYPE_NONE
2.GPIO_ACTIVE_LOW= 1 =IRQ_TYPE_EDGE_RISINGCorrect the interrupt flags, assuming the author of the code wanted some logical behavior behind the name "
ACTIVE_xxx", this is:
ACTIVE_LOW=>IRQ_TYPE_LEVEL_LOW
ACTIVE_HIGH=>IRQ_TYPE_LEVEL_HIGH
Quoted 7 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +- Documentation/devicetree/bindings/net/nfc/nxp-nci.txt | 2 +- Documentation/devicetree/bindings/net/nfc/pn544.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)