Skip to contentSkip to conversation

package/kbd: needs gcc 4.9

PATCH New Fabrice Fontaine 2 participants 2 messages Sep 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kbd: needs gcc 4.9

kbd uses _Generic since version 2.2.90 and
https://github.com/legionus/kbd/commit/da5feb8fd90c3a0df9d505d4604c629d051d3d7d

However, _Generic is not available until gcc 4.9:
https://gcc.gnu.org/wiki/C11Status

As a result, build with gcc 4.8 fails on:

setleds.c:352:3: warning: implicit declaration of function '_Generic' [-Wimplicit-function-declaration]
ndefflags = BITMASK_SET(BITMASK_UNSET(odefflags, ndef), nval);
^
setleds.c:22:2: error: expected expression before 'unsigned'
unsigned char: (unsigned char)(~(x)) \
^

Fixes:
- http://autobuild.buildroot.org/results/b74ecdda44543da1d47fa2c027fb046a3ca1e2d1

---
 package/kbd/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/kbd/Config.in +4 -0
index 6cf2fc0dc6..0099bc750c 100644
@@ -2,7 +2,11 @@ config BR2_PACKAGE_KBD
 	bool "kbd"
 	# Uses fork()
 	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Generic
 	help
 	  Keytable files and keyboard utilities.
 
 	  http://kernel.org/pub/linux/utils/kbd/
+
+comment "kbd needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/kbd: needs gcc 4.9

Fabrice, All,

On 2020-09-08 21:45 +0200, Fabrice Fontaine spake thusly:

Quoted 29 lines

kbd uses _Generic since version 2.2.90 and
https://github.com/legionus/kbd/commit/da5feb8fd90c3a0df9d505d4604c629d051d3d7d

However, _Generic is not available until gcc 4.9:
https://gcc.gnu.org/wiki/C11Status

As a result, build with gcc 4.8 fails on:

setleds.c:352:3: warning: implicit declaration of function '_Generic' [-Wimplicit-function-declaration]

   ndefflags = BITMASK_SET(BITMASK_UNSET(odefflags, ndef), nval);
   ^

setleds.c:22:2: error: expected expression before 'unsigned'
unsigned char: (unsigned char)(~(x)) \
^

Fixes:
- http://autobuild.buildroot.org/results/b74ecdda44543da1d47fa2c027fb046a3ca1e2d1

---
 package/kbd/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/kbd/Config.in +0 -0
index 6cf2fc0dc6..0099bc750c 100644
@@ -2,7 +2,11 @@ config BR2_PACKAGE_KBD
 	bool "kbd"

package/kbd/Config.in config BR2_PACKAGE_KBD · line 12

Quoted 10 lines
package/kbd/Config.in +4 -0
 	# Uses fork()
 	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Generic
 	help
 	  Keytable files and keyboard utilities.
 
 	  http://kernel.org/pub/linux/utils/kbd/
+
+comment "kbd needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

You forgot the MMU dependency in the comment, so I added it and pushed to master, thanks!

Regards,
Yann E. MORIN.

Quoted 7 lines
Signature · 6 lines
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'