Skip to contentSkip to conversation

package/sentry-native: new package

PATCH Superseded Joseph Kogut 3 participants 6 messages Sep 8, 2020 – Sep 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sentry-native: new package

---
 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 .../0001-sentry.h-include-ucontext.h.patch    | 28 +++++++++++++++++++
 package/sentry-native/Config.in               | 25 +++++++++++++++++
 package/sentry-native/sentry-native.hash      |  3 ++
 package/sentry-native/sentry-native.mk        | 18 ++++++++++++
 6 files changed, 76 insertions(+)
 create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
 create mode 100644 package/sentry-native/Config.in
 create mode 100644 package/sentry-native/sentry-native.hash
 create mode 100644 package/sentry-native/sentry-native.mk
DEVELOPERS +1 -0
index 3c3dcda859..342eefc368 100644
@@ -1392,6 +1392,7 @@ F:	package/python-schedule/
 F:	package/python-sentry-sdk/
 F:	package/python-websockets/
 F:	package/python-xlib/
+F:	package/sentry-native/
 F:	package/unclutter-xfixes/
 
 N:	Joshua Henderson <[email protected]>
package/Config.in +1 -0
index d7e79f4795..365d274c57 100644
@@ -129,6 +129,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/ramspeed/Config.in"
 	source "package/rt-tests/Config.in"
 	source "package/spidev_test/Config.in"
+	source "package/sentry-native/Config.in"
 	source "package/strace/Config.in"
 	source "package/stress/Config.in"
 	source "package/stress-ng/Config.in"
package/sentry-native/0001-sentry.h-include-ucontext.h.patch new file +28 -0
new file mode 100644
index 0000000000..b4a427072c
@@ -0,0 +1,28 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <[email protected]>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an
+unknown type name error in older versions.
+
+Signed-off-by: Joseph Kogut <[email protected]>
+---
+ include/sentry.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sentry.h b/include/sentry.h
+index 25754d9..a55cc00 100644
+--- a/include/sentry.h
++++ b/include/sentry.h
+@@ -78,6 +78,7 @@ extern "C" {
+ #    include <wtypes.h>
+ #else
+ #    include <signal.h>
++#    include <ucontext.h>
+ #endif
+ 
+ /**
+-- 
+2.28.0
+
package/sentry-native/Config.in new file +25 -0
new file mode 100644
index 0000000000..a65aca5155
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_SENTRY_NATIVE
+	bool "sentry-native"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	select BR2_PACKAGE_GOOGLE_BREAKPAD
+	select BR2_PACKAGE_LIBCURL
+	help
+	  The Sentry Native SDK is an error and crash
+	  reporting client for native applications,
+	  optimized for C and C++.
+
+	  https://github.com/getsentry/sentry-native
+
+comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8"
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
package/sentry-native/sentry-native.hash new file +3 -0
new file mode 100644
index 0000000000..dffc7aeca3
@@ -0,0 +1,3 @@
+# locally calculated
+sha256  a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b  sentry-native-0.4.1.tar.gz
+sha256  5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523  LICENSE
package/sentry-native/sentry-native.mk new file +18 -0
new file mode 100644
index 0000000000..aaaeee1e43
@@ -0,0 +1,18 @@
+################################################################################
+#
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_TARGET = NO
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
+
+# Use the built system breakpad client instead of bundling
+SENTRY_NATIVE_CONF_OPTS += -DSENTRY_BREAKPAD_SYSTEM=ON
+
+$(eval $(cmake-package))
Signature · 1 line
2.28.0
#1 lore raw

PATCH v2 1/1 package/sentry-native: new package

---
Changes v1 -> v2:
- Install libsentry to target

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 .../0001-sentry.h-include-ucontext.h.patch    | 27 +++++++++++++++++++
 package/sentry-native/Config.in               | 25 +++++++++++++++++
 package/sentry-native/sentry-native.hash      |  3 +++
 package/sentry-native/sentry-native.mk        | 22 +++++++++++++++
 6 files changed, 79 insertions(+)
 create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
 create mode 100644 package/sentry-native/Config.in
 create mode 100644 package/sentry-native/sentry-native.hash
 create mode 100644 package/sentry-native/sentry-native.mk
DEVELOPERS +1 -0
index d59d538e42..931f3a35f2 100644
@@ -1422,6 +1422,7 @@ F:	package/python-schedule/
 F:	package/python-sentry-sdk/
 F:	package/python-websockets/
 F:	package/python-xlib/
+F:	package/sentry-native/
 F:	package/unclutter-xfixes/
 
 N:	Joshua Henderson <[email protected]>
package/Config.in +1 -0
index 1cf36fa28a..3672ad1f06 100644
@@ -130,6 +130,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/ramspeed/Config.in"
 	source "package/rt-tests/Config.in"
 	source "package/spidev_test/Config.in"
+	source "package/sentry-native/Config.in"
 	source "package/strace/Config.in"
 	source "package/stress/Config.in"
 	source "package/stress-ng/Config.in"
package/sentry-native/0001-sentry.h-include-ucontext.h.patch new file +27 -0
new file mode 100644
index 0000000000..9505787245
@@ -0,0 +1,27 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <[email protected]>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an
+unknown type name error in older versions.
+
+Signed-off-by: Joseph Kogut <[email protected]>
+---
+ include/sentry.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sentry.h b/include/sentry.h
+index 25754d9..a55cc00 100644
+--- a/include/sentry.h
++++ b/include/sentry.h
+@@ -78,6 +78,7 @@ extern "C" {
+ #    include <wtypes.h>
+ #else
+ #    include <signal.h>
++#    include <ucontext.h>
+ #endif
+
+ /**
+--
+2.28.0
package/sentry-native/Config.in new file +25 -0
new file mode 100644
index 0000000000..a65aca5155
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_SENTRY_NATIVE
+	bool "sentry-native"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	select BR2_PACKAGE_GOOGLE_BREAKPAD
+	select BR2_PACKAGE_LIBCURL
+	help
+	  The Sentry Native SDK is an error and crash
+	  reporting client for native applications,
+	  optimized for C and C++.
+
+	  https://github.com/getsentry/sentry-native
+
+comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8"
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
package/sentry-native/sentry-native.hash new file +3 -0
new file mode 100644
index 0000000000..dffc7aeca3
@@ -0,0 +1,3 @@
+# locally calculated
+sha256  a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b  sentry-native-0.4.1.tar.gz
+sha256  5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523  LICENSE
package/sentry-native/sentry-native.mk new file +22 -0
new file mode 100644
index 0000000000..dcfdc1cee5
@@ -0,0 +1,22 @@
+################################################################################
+#
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
+
+# Use the built system breakpad client instead of bundling
+SENTRY_NATIVE_CONF_OPTS += -DSENTRY_BREAKPAD_SYSTEM=ON
+
+define SENTRY_NATIVE_INSTALL_TARGET_CMDS
+	$(INSTALL) -m755 -t $(TARGET_DIR)/usr/lib/ \
+		$(@D)/libsentry.so
+endef
+
+$(eval $(cmake-package))

--
2.28.0

#2 lore raw

PATCH v2 1/1 package/sentry-native: new package

Hello Joseph and all,

Quoted 35 lines · Joseph Kogut

---
Changes v1 -> v2:
- Install libsentry to target

  DEVELOPERS                                    |  1 +
  package/Config.in                             |  1 +
  .../0001-sentry.h-include-ucontext.h.patch    | 27 +++++++++++++++++++
  package/sentry-native/Config.in               | 25 +++++++++++++++++
  package/sentry-native/sentry-native.hash      |  3 +++
  package/sentry-native/sentry-native.mk        | 22 +++++++++++++++
  6 files changed, 79 insertions(+)

create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch create mode 100644 package/sentry-native/Config.in
create mode 100644 package/sentry-native/sentry-native.hash
create mode 100644 package/sentry-native/sentry-native.mk

DEVELOPERS +1 -0
index d59d538e42..931f3a35f2 100644
@@ -1422,6 +1422,7 @@ F:	package/python-schedule/
  F:	package/python-sentry-sdk/
  F:	package/python-websockets/
  F:	package/python-xlib/
+F:	package/sentry-native/
  F:	package/unclutter-xfixes/
 
  N:	Joshua Henderson <[email protected]>
package/Config.in +0 -0
index 1cf36fa28a..3672ad1f06 100644

package/Config.in menu "Debugging, profiling and benchmark" · line 133

Quoted 4 lines
package/Config.in +1 -0
@@ -130,6 +130,7 @@ menu "Debugging, profiling and benchmark"
  	source "package/ramspeed/Config.in"
  	source "package/rt-tests/Config.in"
  	source "package/spidev_test/Config.in"
+	source "package/sentry-native/Config.in"

You should place this one line above to maintain the alphabetic order. Besides this cosmetic comment,

Cheers,
Titouan

#3 lore raw

PATCH v3 1/1 package/sentry-native: new package

---
Changes v2 -> v3:
- Fix order of Config.in entry (suggested by Titouan)

Changes v1 -> v2:
- Install libsentry to target

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 .../0001-sentry.h-include-ucontext.h.patch    | 27 +++++++++++++++++++
 package/sentry-native/Config.in               | 25 +++++++++++++++++
 package/sentry-native/sentry-native.hash      |  3 +++
 package/sentry-native/sentry-native.mk        | 22 +++++++++++++++
 6 files changed, 79 insertions(+)
 create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
 create mode 100644 package/sentry-native/Config.in
 create mode 100644 package/sentry-native/sentry-native.hash
 create mode 100644 package/sentry-native/sentry-native.mk
DEVELOPERS +1 -0
index d59d538e42..931f3a35f2 100644
@@ -1422,6 +1422,7 @@ F:	package/python-schedule/
 F:	package/python-sentry-sdk/
 F:	package/python-websockets/
 F:	package/python-xlib/
+F:	package/sentry-native/
 F:	package/unclutter-xfixes/
 
 N:	Joshua Henderson <[email protected]>
package/Config.in +1 -0
index 1cf36fa28a..6b2a2eb48c 100644
@@ -129,6 +129,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/ramsmp/Config.in"
 	source "package/ramspeed/Config.in"
 	source "package/rt-tests/Config.in"
+	source "package/sentry-native/Config.in"
 	source "package/spidev_test/Config.in"
 	source "package/strace/Config.in"
 	source "package/stress/Config.in"
package/sentry-native/0001-sentry.h-include-ucontext.h.patch new file +27 -0
new file mode 100644
index 0000000000..9505787245
@@ -0,0 +1,27 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <[email protected]>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an
+unknown type name error in older versions.
+
+Signed-off-by: Joseph Kogut <[email protected]>
+---
+ include/sentry.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sentry.h b/include/sentry.h
+index 25754d9..a55cc00 100644
+--- a/include/sentry.h
++++ b/include/sentry.h
+@@ -78,6 +78,7 @@ extern "C" {
+ #    include <wtypes.h>
+ #else
+ #    include <signal.h>
++#    include <ucontext.h>
+ #endif
+
+ /**
+--
+2.28.0
package/sentry-native/Config.in new file +25 -0
new file mode 100644
index 0000000000..a65aca5155
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_SENTRY_NATIVE
+	bool "sentry-native"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	select BR2_PACKAGE_GOOGLE_BREAKPAD
+	select BR2_PACKAGE_LIBCURL
+	help
+	  The Sentry Native SDK is an error and crash
+	  reporting client for native applications,
+	  optimized for C and C++.
+
+	  https://github.com/getsentry/sentry-native
+
+comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8"
+	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
package/sentry-native/sentry-native.hash new file +3 -0
new file mode 100644
index 0000000000..dffc7aeca3
@@ -0,0 +1,3 @@
+# locally calculated
+sha256  a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b  sentry-native-0.4.1.tar.gz
+sha256  5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523  LICENSE
package/sentry-native/sentry-native.mk new file +22 -0
new file mode 100644
index 0000000000..dcfdc1cee5
@@ -0,0 +1,22 @@
+################################################################################
+#
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
+
+# Use the built system breakpad client instead of bundling
+SENTRY_NATIVE_CONF_OPTS += -DSENTRY_BREAKPAD_SYSTEM=ON
+
+define SENTRY_NATIVE_INSTALL_TARGET_CMDS
+	$(INSTALL) -m755 -t $(TARGET_DIR)/usr/lib/ \
+		$(@D)/libsentry.so
+endef
+
+$(eval $(cmake-package))

--
2.28.0

#5 lore raw

PATCH v3 1/1 package/sentry-native: new package

In reply to Joseph Kogut

Hello,

Quoted 1 line · On Tue, 15 Sep 2020 14:01:22 -0700 Joseph Kogut <[email protected]> wrote:

I've applied, with some changes, see below.

package/sentry-native/0001-sentry.h-include-ucontext.h.patch line 6

Quoted 12 lines
package/sentry-native/0001-sentry.h-include-ucontext.h.patch new file +6 -0
new file mode 100644
index 0000000000..9505787245
@@ -0,0 +1,27 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <[email protected]>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an

signal.h is not from GCC, but from the C library (in this case, glibc).

Quoted 17 lines
package/sentry-native/sentry-native.hash new file +3 -0
new file mode 100644
index 0000000000..dffc7aeca3
@@ -0,0 +1,3 @@
+# locally calculated
+sha256  a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b  sentry-native-0.4.1.tar.gz
+sha256  5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523  LICENSE
package/sentry-native/sentry-native.mk new file +2 -0
new file mode 100644
index 0000000000..dcfdc1cee5
@@ -0,0 +1,22 @@
+################################################################################
+#

package/sentry-native/sentry-native.mk line 12

Quoted 10 lines
package/sentry-native/sentry-native.mk new file +10 -0
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support

sentry-native does not use linux-syscall-support directly as far as I can see, and you were anyway not selecting this package in your Config.in file, so I dropped this.

I've added SENTRY_NATIVE_INSTALL_STAGING = YES, because sentry-native is essentially a library... so if you don't have it in staging, no other package can link against it.

package/sentry-native/sentry-native.mk line 20

Quoted 4 lines
package/sentry-native/sentry-native.mk new file +4 -0
+define SENTRY_NATIVE_INSTALL_TARGET_CMDS
+	$(INSTALL) -m755 -t $(TARGET_DIR)/usr/lib/ \
+		$(@D)/libsentry.so
+endef

This was not needed, the default "make install" does the right thing already, so I dropped that.

As said: applied with those various issues fixed. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com