Skip to contentSkip to conversation

misc: rtsx: Add power saving functions and fix driving parameter

PATCH In review [email protected] 4 participants 12 messages Sep 7, 2020 – Mar 25, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v5 2/2 misc: rtsx: Add power saving functions and fix driving parameter

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145 ++++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
drivers/misc/cardreader/rts5227.c +110 -2
index 747391e3fb5d..8859011672cb 100644
@@ -72,15 +72,80 @@ static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr)
 
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);
+
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2, &val);
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}
+
 static int rts5227_extra_init_hw(struct rtsx_pcr *pcr)
 {
 	u16 cap;
+	struct rtsx_cr_option *option = &pcr->option;
 
+	rts5227_init_from_cfg(pcr);
 	rtsx_pci_init_cmd(pcr);
 
 	/* Configure GPIO as output */
@@ -102,9 +167,17 @@ static int rts5227_extra_init_hw(struct rtsx_pcr *pcr)
 	rts5227_fill_driving(pcr, OUTPUT_3V3);
 	/* Configure force_clock_req */
 	if (pcr->flags & PCR_REVERSE_SOCKET)
-		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PETXCFG, 0xB8, 0xB8);
+		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PETXCFG, 0x30, 0x30);
 	else
-		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PETXCFG, 0xB8, 0x88);
+		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PETXCFG, 0x30, 0x00);
+
+	if (option->force_clkreq_0)
+		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PETXCFG,
+				FORCE_CLKREQ_DELINK_MASK, FORCE_CLKREQ_LOW);
+	else
+		rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, PETXCFG,
+				FORCE_CLKREQ_DELINK_MASK, FORCE_CLKREQ_HIGH);
+
 	rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, pcr->reg_pm_ctrl3, 0x10, 0x00);
 
 	return rtsx_pci_send_cmd(pcr, 100);
@@ -359,6 +432,27 @@ static int rts522a_switch_output_voltage(struct rtsx_pcr *pcr, u8 voltage)
 	return rtsx_pci_send_cmd(pcr, 100);
 }
 
+static void rts522a_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int active)
+{
+	struct rtsx_cr_option *option = &pcr->option;
+	int aspm_L1_1, aspm_L1_2;
+	u8 val = 0;
+
+	aspm_L1_1 = rtsx_check_dev_flag(pcr, ASPM_L1_1_EN);
+	aspm_L1_2 = rtsx_check_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (active) {
+		/* run, latency: 60us */
+		if (aspm_L1_1)
+			val = option->ltr_l1off_snooze_sspwrgate;
+	} else {
+		/* l1off, latency: 300us */
+		if (aspm_L1_2)
+			val = option->ltr_l1off_sspwrgate;
+	}
+
+	rtsx_set_l1off_sub(pcr, val);
+}
 
 /* rts522a operations mainly derived from rts5227, except phy/hw init setting.
  */
@@ -375,15 +469,29 @@ static const struct pcr_ops rts522a_pcr_ops = {
 	.switch_output_voltage = rts522a_switch_output_voltage,
 	.cd_deglitch = NULL,
 	.conv_clk_and_div_n = NULL,
+	.set_l1off_cfg_sub_d0 = rts522a_set_l1off_cfg_sub_d0,
 };
 
 void rts522a_init_params(struct rtsx_pcr *pcr)
 {
+	struct rtsx_cr_option *option = &pcr->option;
+
 	rts5227_init_params(pcr);
 	pcr->ops = &rts522a_pcr_ops;
 	pcr->tx_initial_phase = SET_CLOCK_PHASE(20, 20, 11);
 	pcr->reg_pm_ctrl3 = RTS522A_PM_CTRL3;
 
+	option->dev_flags = LTR_L1SS_PWR_GATE_EN;
+	option->ltr_en = true;
+
+	/* init latency of active, idle, L1OFF to 60us, 300us, 3ms */
+	option->ltr_active_latency = LTR_ACTIVE_LATENCY_DEF;
+	option->ltr_idle_latency = LTR_IDLE_LATENCY_DEF;
+	option->ltr_l1off_latency = LTR_L1OFF_LATENCY_DEF;
+	option->l1_snooze_delay = L1_SNOOZE_DELAY_DEF;
+	option->ltr_l1off_sspwrgate = 0x7F;
+	option->ltr_l1off_snooze_sspwrgate = 0x78;
+
 	pcr->option.ocp_en = 1;
 	if (pcr->option.ocp_en)
 		pcr->hw_param.interrupt_en |= SD_OC_INT_EN;
drivers/misc/cardreader/rts5249.c +142 -3

190 lines not on this page · raw message

drivers/misc/cardreader/rts5260.c +14 -14
index 897cfee350e7..080a7d67a8e1 100644
@@ -26,21 +26,17 @@ static u8 rts5260_get_ic_version(struct rtsx_pcr *pcr)
 
 static void rts5260_fill_driving(struct rtsx_pcr *pcr, u8 voltage)
 {
-	u8 driving_3v3[6][3] = {
-		{0x94, 0x94, 0x94},
-		{0x11, 0x11, 0x18},
-		{0x55, 0x55, 0x5C},
-		{0x94, 0x94, 0x94},
-		{0x94, 0x94, 0x94},
-		{0xFF, 0xFF, 0xFF},
+	u8 driving_3v3[4][3] = {
+		{0x11, 0x11, 0x11},
+		{0x22, 0x22, 0x22},
+		{0x55, 0x55, 0x55},
+		{0x33, 0x33, 0x33},
 	};
-	u8 driving_1v8[6][3] = {
-		{0x9A, 0x89, 0x89},
-		{0xC4, 0xC4, 0xC4},
-		{0x3C, 0x3C, 0x3C},
+	u8 driving_1v8[4][3] = {
+		{0x35, 0x33, 0x33},
+		{0x8A, 0x88, 0x88},
+		{0xBD, 0xBB, 0xBB},
 		{0x9B, 0x99, 0x99},
-		{0x9A, 0x89, 0x89},
-		{0xFE, 0xFE, 0xFE},
 	};
 	u8 (*driving)[3], drive_sel;
 
@@ -58,7 +54,7 @@ static void rts5260_fill_driving(struct rtsx_pcr *pcr, u8 voltage)
 	rtsx_pci_write_register(pcr, SD30_CMD_DRIVE_SEL,
 			 0xFF, driving[drive_sel][1]);
 
-	rtsx_pci_write_register(pcr, SD30_CMD_DRIVE_SEL,
+	rtsx_pci_write_register(pcr, SD30_DAT_DRIVE_SEL,
 			 0xFF, driving[drive_sel][2]);
 }
 
@@ -82,6 +78,8 @@ static void rtsx_base_fetch_vendor_settings(struct rtsx_pcr *pcr)
 
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
@@ -559,6 +557,8 @@ static int rts5260_extra_init_hw(struct rtsx_pcr *pcr)
 		rtsx_pci_write_register(pcr, PETXCFG,
 				 FORCE_CLKREQ_DELINK_MASK, FORCE_CLKREQ_HIGH);
 
+	rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x10, 0x00);
+
 	return 0;
 }
 
drivers/misc/cardreader/rtsx_pcr.h +17 -0
index 6b322db8738e..fe5f4ca0f937 100644
@@ -18,7 +18,24 @@
 #define RTS522A_PM_CTRL3		0xFF7E
 
 #define RTS524A_PME_FORCE_CTL		0xFF78
+#define REG_EFUSE_BYPASS		0x08
+#define REG_EFUSE_POR			0x04
+#define REG_EFUSE_POWER_MASK		0x03
+#define REG_EFUSE_POWERON		0x03
+#define REG_EFUSE_POWEROFF		0x00
+#define RTS5250_CLK_CFG3		0xFF79
+#define RTS525A_CFG_MEM_PD		0xF0
 #define RTS524A_PM_CTRL3		0xFF7E
+#define RTS525A_BIOS_CFG		0xFF2D
+#define RTS525A_LOAD_BIOS_FLAG	0x01
+#define RTS525A_CLEAR_BIOS_FLAG	0x00
+
+#define RTS525A_EFUSE_CTL		0xFC32
+#define REG_EFUSE_ENABLE		0x80
+#define REG_EFUSE_MODE			0x40
+#define RTS525A_EFUSE_ADD		0xFC33
+#define REG_EFUSE_ADD_MASK		0x3F
+#define RTS525A_EFUSE_DATA		0xFC35
 
 #define LTR_ACTIVE_LATENCY_DEF		0x883C
 #define LTR_IDLE_LATENCY_DEF		0x892C
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected] wrote:

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 29 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145 ++++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
drivers/misc/cardreader/rts5227.c +4 -0
index 747391e3fb5d..8859011672cb 100644
@@ -72,15 +72,80 @@ static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr)
 
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 93

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

Quoted 21 lines
drivers/misc/cardreader/rts5227.c +21 -0
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 125

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2, &val);

Same thing here. I don't think the PCI core currently changes PCI_EXP_DEVCTL2 after boot, but it's not a good idea to assume it's going to be constant.

Quoted 16 lines
drivers/misc/cardreader/rts5227.c +16 -0
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}
#2 lore raw
Quoted 69 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 7 lines · On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected] wrote:

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Review

Quoted 5 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void rts5227_fetch_vendor_settings(struct

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 93

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 4 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time,
if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 27 lines
Quoted 27 lines
drivers/misc/cardreader/rts5227.c +27 -0
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
Quoted 9 lines

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 125

Quoted 4 lines
drivers/misc/cardreader/rts5227.c +4 -0
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2, &val);

Same thing here. I don't think the PCI core currently changes PCI_EXP_DEVCTL2 after boot, but it's not a good idea to assume it's going to be constant.

The same reply

Quoted 18 lines
Quoted 6 lines
drivers/misc/cardreader/rts5227.c +6 -0
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 141

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}

------Please consider the environment before printing this e-mail.

#3 lore raw
Quoted 69 lines · 吳昊澄 Ricky
Quoted 69 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 7 lines · On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected] wrote:

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Review

Quoted 5 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void rts5227_fetch_vendor_settings(struct

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 93

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Quoted 57 lines
Quoted 27 lines
Quoted 27 lines
drivers/misc/cardreader/rts5227.c +27 -0
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
Quoted 9 lines

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 125

Quoted 4 lines
drivers/misc/cardreader/rts5227.c +4 -0
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2, &val);

Same thing here. I don't think the PCI core currently changes PCI_EXP_DEVCTL2 after boot, but it's not a good idea to assume it's going to be constant.

The same reply

Quoted 18 lines
Quoted 6 lines
drivers/misc/cardreader/rts5227.c +6 -0
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 141

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}

------Please consider the environment before printing this e-mail.

#4 lore raw
Quoted 91 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, September 10, 2020 1:44 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 6 lines · 吳昊澄 Ricky
Quoted 6 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 60 lines
Quoted 60 lines

parameter

Quoted 7 lines · On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected] wrote:

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Review

Quoted 5 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void rts5227_fetch_vendor_settings(struct

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 93

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 7 lines

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Our power saving function have 2 different flow L1 and L1substate, so we need to check it for which flow we are going to Detail to see below reply

Quoted 19 lines

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

Quoted 9 lines

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Talk about our power saving function
a) basic L1 power saving
b) advance L1 power saving
c) advance L1 substate power saving

at initial , we check pci port support L1 subs or not, if not we are going to b) otherwise going to c). Assume aspm.c change bit of L1 PM Substates capability after our driver probe, we are going to a)

So far we did not see any platform change L1 PM Substates capability after our driver probe.

Quoted 57 lines
Quoted 57 lines
Quoted 27 lines
Quoted 27 lines
drivers/misc/cardreader/rts5227.c +27 -0
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
Quoted 9 lines

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 125

Quoted 4 lines
drivers/misc/cardreader/rts5227.c +4 -0
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2, &val);

Same thing here. I don't think the PCI core currently changes PCI_EXP_DEVCTL2 after boot, but it's not a good idea to assume it's going to be constant.

The same reply

Quoted 18 lines
Quoted 6 lines
drivers/misc/cardreader/rts5227.c +6 -0
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 141

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}

------Please consider the environment before printing this e-mail.

#5 lore raw
Quoted 126 lines · 吳昊澄 Ricky
Quoted 91 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, September 10, 2020 1:44 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 6 lines · 吳昊澄 Ricky
Quoted 6 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 60 lines
Quoted 60 lines

parameter

Quoted 7 lines · On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected] wrote:

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Review

Quoted 5 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void rts5227_fetch_vendor_settings(struct

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 93

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 6 lines

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Our power saving function have 2 different flow L1 and L1substate, so we need to check it for which flow we are going to Detail to see below reply

Quoted 24 lines

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

Quoted 8 lines
Quoted 3 lines

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Talk about our power saving function
a) basic L1 power saving
b) advance L1 power saving
c) advance L1 substate power saving

I have no idea what the difference between "basic L1 power saving" and "advance L1 power saving" is, so I assume those are device-specific things. If not, please use the same terminology as the PCIe spec.

Quoted 2 lines

at initial, we check pci port support L1 subs or not, if not we are going to b) otherwise going to c).

You're not checking whether the port *supports* L1 substates. You would look at PCI_L1SS_CAP to learn that. You're looking at PCI_L1SS_CTL1, which tells you whether L1 substates are *enabled*.

Quoted 5 lines

Assume aspm.c change bit of L1 PM Substates capability after our driver probe, we are going to a)

So far we did not see any platform change L1 PM Substates capability after our driver probe.

You should expect that aspm.c will change bits in the L1 PM *control* register (PCI_L1SS_CTL1) after probe.

You might not actually see it change, depending on how you tested, but you cannot rely on PCI_L1SS_CTL1 being constant. It may change based on power/performance tradeoffs, e.g., whether the system is plugged into AC power, whether it's idle, etc.

Quoted 57 lines
Quoted 57 lines
Quoted 57 lines
Quoted 27 lines
Quoted 27 lines
drivers/misc/cardreader/rts5227.c +27 -0
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
Quoted 9 lines

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 125

Quoted 4 lines
drivers/misc/cardreader/rts5227.c +4 -0
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2, &val);

Same thing here. I don't think the PCI core currently changes PCI_EXP_DEVCTL2 after boot, but it's not a good idea to assume it's going to be constant.

The same reply

Quoted 18 lines
Quoted 6 lines
drivers/misc/cardreader/rts5227.c +6 -0
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 141

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}

------Please consider the environment before printing this e-mail.

#6 lore raw
Quoted 169 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Friday, September 11, 2020 10:56 PM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 6 lines · 吳昊澄 Ricky
Quoted 6 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, September 10, 2020 1:44 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 8 lines
Quoted 8 lines

parameter

Quoted 5 lines · 吳昊澄 Ricky
Quoted 5 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected];

[email protected];

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line

[email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 3 lines
Quoted 3 lines

parameter

On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected]

Quoted 23 lines · wrote:
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Quoted 4 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void

rts5227_fetch_vendor_settings(struct

Quoted 71 lines
Quoted 36 lines
Quoted 28 lines
Quoted 28 lines

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 93

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 6 lines

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Our power saving function have 2 different flow L1 and L1substate, so we need to check it for which flow we are going to Detail to see below reply

Quoted 24 lines

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

Quoted 8 lines
Quoted 3 lines

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Talk about our power saving function
a) basic L1 power saving
b) advance L1 power saving
c) advance L1 substate power saving

I have no idea what the difference between "basic L1 power saving" and "advance L1 power saving" is, so I assume those are device-specific things. If not, please use the same terminology as the PCIe spec.

Quoted 2 lines

at initial, we check pci port support L1 subs or not, if not we are going to b) otherwise going to c).

You're not checking whether the port *supports* L1 substates. You would look at PCI_L1SS_CAP to learn that. You're looking at PCI_L1SS_CTL1, which tells you whether L1 substates are *enabled*.

Quoted 5 lines

Assume aspm.c change bit of L1 PM Substates capability after our driver probe, we are going to a)

So far we did not see any platform change L1 PM Substates capability after our driver probe.

Quoted 8 lines

You should expect that aspm.c will change bits in the L1 PM *control* register (PCI_L1SS_CTL1) after probe.

You might not actually see it change, depending on how you tested, but you cannot rely on PCI_L1SS_CTL1 being constant. It may change based on power/performance tradeoffs, e.g., whether the system is plugged into AC power, whether it's idle, etc.

Our ASPM function is a HW solution follow the PCIe SPEC. don’t worry about crash the system
If HOST change our device config space setting at run time our HW will do the corresponding things which follows the SPEC. At initial time we set these parameter just good for more power saving

Quoted 58 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
drivers/misc/cardreader/rts5227.c +23 -0
+	if (CHK_PCI_PID(pcr, 0x522A)) {
+		if (0 == (lval & 0x0F))
+			rtsx_pci_enable_oobs_polling(pcr);
+		else
+			rtsx_pci_disable_oobs_polling(pcr);
+	}
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_1)
+		rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_ASPM_L1_2)
+		rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, ASPM_L1_2_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_1)
+		rtsx_set_dev_flag(pcr, PM_L1_1_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_1_EN);
+
+	if (lval & PCI_L1SS_CTL1_PCIPM_L1_2)
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr)

Quoted 8 lines
drivers/misc/cardreader/rts5227.c +8 -0
+		rtsx_set_dev_flag(pcr, PM_L1_2_EN);
+	else
+		rtsx_clear_dev_flag(pcr, PM_L1_2_EN);
+
+	if (option->ltr_en) {
+		u16 val;
+
+		pcie_capability_read_word(pcr->pci, PCI_EXP_DEVCTL2,

&val);

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines
Quoted 5 lines

Same thing here. I don't think the PCI core currently changes PCI_EXP_DEVCTL2 after boot, but it's not a good idea to assume it's going to be constant.

The same reply

Quoted 18 lines
Quoted 6 lines
drivers/misc/cardreader/rts5227.c +6 -0
+		if (val & PCI_EXP_DEVCTL2_LTR_EN) {
+			option->ltr_enabled = true;
+			option->ltr_active = true;
+			rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
+		} else {
+			option->ltr_enabled = false;

drivers/misc/cardreader/rts5227.c static void rts5227_fetch_vendor_settings(struct rtsx_pcr *pcr) · line 141

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+		}
+	}
+
+	if (rtsx_check_dev_flag(pcr, ASPM_L1_1_EN | ASPM_L1_2_EN
+				| PM_L1_1_EN | PM_L1_2_EN))
+		option->force_clkreq_0 = false;
+	else
+		option->force_clkreq_0 = true;
+
+}

------Please consider the environment before printing this e-mail.

#7 lore raw
Quoted 178 lines · 吳昊澄 Ricky
Quoted 169 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Friday, September 11, 2020 10:56 PM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 6 lines · 吳昊澄 Ricky
Quoted 6 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, September 10, 2020 1:44 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 8 lines
Quoted 8 lines

parameter

Quoted 5 lines · 吳昊澄 Ricky
Quoted 5 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected];

[email protected];

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line

[email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 3 lines
Quoted 3 lines

parameter

On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected]

Quoted 23 lines · wrote:
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Quoted 4 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void

rts5227_fetch_vendor_settings(struct

Quoted 71 lines
Quoted 36 lines
Quoted 28 lines
Quoted 28 lines

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void · line 92

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 6 lines

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Our power saving function have 2 different flow L1 and L1substate, so we need to check it for which flow we are going to Detail to see below reply

Quoted 24 lines

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

Quoted 8 lines
Quoted 3 lines

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Talk about our power saving function
a) basic L1 power saving
b) advance L1 power saving
c) advance L1 substate power saving

I have no idea what the difference between "basic L1 power saving" and "advance L1 power saving" is, so I assume those are device-specific things. If not, please use the same terminology as the PCIe spec.

Quoted 2 lines

at initial, we check pci port support L1 subs or not, if not we are going to b) otherwise going to c).

You're not checking whether the port *supports* L1 substates. You would look at PCI_L1SS_CAP to learn that. You're looking at PCI_L1SS_CTL1, which tells you whether L1 substates are *enabled*.

Quoted 5 lines

Assume aspm.c change bit of L1 PM Substates capability after our driver probe, we are going to a)

So far we did not see any platform change L1 PM Substates capability after our driver probe.

Quoted 8 lines

You should expect that aspm.c will change bits in the L1 PM *control* register (PCI_L1SS_CTL1) after probe.

You might not actually see it change, depending on how you tested, but you cannot rely on PCI_L1SS_CTL1 being constant. It may change based on power/performance tradeoffs, e.g., whether the system is plugged into AC power, whether it's idle, etc.

Quoted 5 lines

Our ASPM function is a HW solution follow the PCIe SPEC. don’t worry about crash the system If HOST change our device config space setting at run time our HW will do the corresponding things which follows the SPEC. At initial time we set these parameter just good for more power saving

OK. It would be better if your hardware would notice the PCI_L1SS_CTL1 change and set its own device-specific power-saving parameters. The drivers would be simpler, and the device behavior would be more consistent.

Drivers *writing* to standard PCI config things (64-byte config header or Capabilities like PCIe, PM, ASPM, L1 Substates) is a definite problem because the PCI core owns those and writes from drivers need to be mediated somehow. AFAICT your drivers don't write to these things.

Drivers *reading* these things (as your drivers do) shouldn't cause problems, but it does violate the interface abstractions that the PCI core should provide.

Bjorn

#8 lore raw
Quoted 196 lines · Bjorn Helgaas
Quoted 178 lines · 吳昊澄 Ricky
Quoted 169 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Friday, September 11, 2020 10:56 PM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 6 lines · 吳昊澄 Ricky
Quoted 6 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, September 10, 2020 1:44 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 8 lines
Quoted 8 lines

parameter

Quoted 5 lines · 吳昊澄 Ricky
Quoted 5 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected];

[email protected];

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line

[email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 3 lines
Quoted 3 lines

parameter

On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected]

Quoted 23 lines · wrote:
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Quoted 4 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void

rts5227_fetch_vendor_settings(struct

Quoted 71 lines
Quoted 36 lines
Quoted 28 lines
Quoted 28 lines

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void · line 92

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 6 lines

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Our power saving function have 2 different flow L1 and L1substate, so we need to check it for which flow we are going to Detail to see below reply

Quoted 24 lines

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

Quoted 8 lines
Quoted 3 lines

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Talk about our power saving function
a) basic L1 power saving
b) advance L1 power saving
c) advance L1 substate power saving

I have no idea what the difference between "basic L1 power saving" and "advance L1 power saving" is, so I assume those are device-specific things. If not, please use the same terminology as the PCIe spec.

Quoted 2 lines

at initial, we check pci port support L1 subs or not, if not we are going to b) otherwise going to c).

You're not checking whether the port *supports* L1 substates. You would look at PCI_L1SS_CAP to learn that. You're looking at PCI_L1SS_CTL1, which tells you whether L1 substates are *enabled*.

Quoted 5 lines

Assume aspm.c change bit of L1 PM Substates capability after our driver probe, we are going to a)

So far we did not see any platform change L1 PM Substates capability after our driver probe.

Quoted 8 lines

You should expect that aspm.c will change bits in the L1 PM *control* register (PCI_L1SS_CTL1) after probe.

You might not actually see it change, depending on how you tested, but you cannot rely on PCI_L1SS_CTL1 being constant. It may change based on power/performance tradeoffs, e.g., whether the system is plugged into AC power, whether it's idle, etc.

Quoted 5 lines

Our ASPM function is a HW solution follow the PCIe SPEC. don’t worry about crash the system If HOST change our device config space setting at run time our HW will do the corresponding things which follows the SPEC. At initial time we set these parameter just good for more power saving

OK. It would be better if your hardware would notice the PCI_L1SS_CTL1 change and set its own device-specific power-saving parameters. The drivers would be simpler, and the device behavior would be more consistent.

Drivers *writing* to standard PCI config things (64-byte config header or Capabilities like PCIe, PM, ASPM, L1 Substates) is a definite problem because the PCI core owns those and writes from drivers need to be mediated somehow. AFAICT your drivers don't write to these things.

Quoted 3 lines

Drivers *reading* these things (as your drivers do) shouldn't cause problems, but it does violate the interface abstractions that the PCI core should provide.

So is it ok to take this patch now, or does it need to be changed any?

thanks,

greg k-h

#9 lore raw
Quoted 197 lines · On Wed, Sep 16, 2020 at 02:30:20PM +0200, [email protected] wrote:
Quoted 196 lines · Bjorn Helgaas
Quoted 178 lines · 吳昊澄 Ricky
Quoted 169 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Friday, September 11, 2020 10:56 PM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

Quoted 6 lines · 吳昊澄 Ricky
Quoted 6 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, September 10, 2020 1:44 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 8 lines
Quoted 8 lines

parameter

Quoted 5 lines · 吳昊澄 Ricky
Quoted 5 lines

-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Wednesday, September 09, 2020 6:29 AM
To: 吳昊澄 Ricky
Cc: [email protected]; [email protected];

[email protected];

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line

[email protected]; [email protected];

[email protected];

Quoted 3 lines
Quoted 3 lines

[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix

driving

Quoted 3 lines
Quoted 3 lines

parameter

On Mon, Sep 07, 2020 at 06:07:31PM +0800, [email protected]

Quoted 23 lines · wrote:
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines

From: Ricky Wu <[email protected]>

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Hehe, this came out *above* the "---" line :)

Quoted 8 lines

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

---
 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145

++++++++++++++++++++++++++++-

Quoted 4 lines
 drivers/misc/cardreader/rts5260.c  |  28 +++---
 drivers/misc/cardreader/rtsx_pcr.h |  17 ++++
 4 files changed, 283 insertions(+), 19 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/misc/cardreader/rts5227.c

drivers/misc/cardreader/rts5227.c static void

Quoted 4 lines

index 747391e3fb5d..8859011672cb 100644

drivers/misc/cardreader/rts5227.c +0 -0
@@ -72,15 +72,80 @@ static void

rts5227_fetch_vendor_settings(struct

Quoted 71 lines
Quoted 36 lines
Quoted 28 lines
Quoted 28 lines

rtsx_pcr *pcr)

Quoted 12 lines
drivers/misc/cardreader/rts5227.c +4 -0
 	pci_read_config_dword(pdev, PCR_SETTING_REG2, &reg);
 	pcr_dbg(pcr, "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG2, reg);
+	if (rtsx_check_mmc_support(reg))
+		pcr->extra_caps |= EXTRA_CAPS_NO_MMC;
 	pcr->sd30_drive_sel_3v3 = rtsx_reg_to_sd30_drive_sel_3v3(reg);
 	if (rtsx_reg_check_reverse_socket(reg))
 		pcr->flags |= PCR_REVERSE_SOCKET;
 }
 
+static void rts5227_init_from_cfg(struct rtsx_pcr *pcr)
+{

drivers/misc/cardreader/rts5227.c static void · line 92

Quoted 10 lines
drivers/misc/cardreader/rts5227.c +10 -0
+	struct pci_dev *pdev = pcr->pci;
+	int l1ss;
+	u32 lval;
+	struct rtsx_cr_option *option = &pcr->option;
+
+	l1ss = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_L1SS);
+	if (!l1ss)
+		return;
+
+	pci_read_config_dword(pdev, l1ss + PCI_L1SS_CTL1, &lval);

This looks a little problematic. PCI_L1SS_CTL1 is an architected register in the ASPM L1 PM Substates capability, and its value may change at runtime because drivers/pci/pcie/aspm.c manages it.

Quoted 7 lines
Quoted 3 lines

It looks like the code below does device-specific configuration based on the current PCI_L1SS_CTL1 value. But what happens if aspm.c changes PCI_L1SS_CTL1 later?

We are going to make sure and set the best configuration on the current time, if host change the capability later, it doesn't affect function, only affect a little power saving

Quoted 6 lines

Why don't you unconditionally do the following?

  rtsx_set_dev_flag(pcr, ASPM_L1_1_EN);
  rtsx_set_dev_flag(pcr, ASPM_L1_2_EN);
  rtsx_set_dev_flag(pcr, PM_L1_1_EN);
  rtsx_set_dev_flag(pcr, PM_L1_2_EN);

Our power saving function have 2 different flow L1 and L1substate, so we need to check it for which flow we are going to Detail to see below reply

Quoted 24 lines

Let's assume the generic code in aspm.c has cleared all these bits:

PCI_L1SS_CTL1_ASPM_L1_1
PCI_L1SS_CTL1_ASPM_L1_2
PCI_L1SS_CTL1_PCIPM_L1_1
PCI_L1SS_CTL1_PCIPM_L1_2

in the L1 PM Substates capability.

I think you are saying that if you *also* clear ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN in your device-specific registers, it uses less power than if you set those device-specific bits. Right?

And moreover, I think you're saying that if aspm.c subsequently *sets* some of those bits in the L1 PM Substates capability, those substates *work* even though the device-specific ASPM_L1_1_EN, ASPM_L1_2_EN, PM_L1_1_EN, and PM_L1_2_EN bits are not set. Right?

I do not feel good about this as a general strategy. I think we should program the device so the behavior is completely predictable, regardless of the generic enable bits happened to be set at probe-time.

Quoted 8 lines
Quoted 3 lines

The current approach means that if we enable L1 substates after the driver probe, the device is configured differently than if we enabled L1 substates before probe. That's not a reliable way to operate it.

Talk about our power saving function
a) basic L1 power saving
b) advance L1 power saving
c) advance L1 substate power saving

I have no idea what the difference between "basic L1 power saving" and "advance L1 power saving" is, so I assume those are device-specific things. If not, please use the same terminology as the PCIe spec.

Quoted 2 lines

at initial, we check pci port support L1 subs or not, if not we are going to b) otherwise going to c).

You're not checking whether the port *supports* L1 substates. You would look at PCI_L1SS_CAP to learn that. You're looking at PCI_L1SS_CTL1, which tells you whether L1 substates are *enabled*.

Quoted 5 lines

Assume aspm.c change bit of L1 PM Substates capability after our driver probe, we are going to a)

So far we did not see any platform change L1 PM Substates capability after our driver probe.

Quoted 8 lines

You should expect that aspm.c will change bits in the L1 PM *control* register (PCI_L1SS_CTL1) after probe.

You might not actually see it change, depending on how you tested, but you cannot rely on PCI_L1SS_CTL1 being constant. It may change based on power/performance tradeoffs, e.g., whether the system is plugged into AC power, whether it's idle, etc.

Quoted 5 lines

Our ASPM function is a HW solution follow the PCIe SPEC. don’t worry about crash the system If HOST change our device config space setting at run time our HW will do the corresponding things which follows the SPEC. At initial time we set these parameter just good for more power saving

OK. It would be better if your hardware would notice the PCI_L1SS_CTL1 change and set its own device-specific power-saving parameters. The drivers would be simpler, and the device behavior would be more consistent.

Drivers *writing* to standard PCI config things (64-byte config header or Capabilities like PCIe, PM, ASPM, L1 Substates) is a definite problem because the PCI core owns those and writes from drivers need to be mediated somehow. AFAICT your drivers don't write to these things.

Quoted 5 lines
Quoted 3 lines

Drivers *reading* these things (as your drivers do) shouldn't cause problems, but it does violate the interface abstractions that the PCI core should provide.

So is it ok to take this patch now, or does it need to be changed any?

Yes, it's OK with me if you take this patch.

The ASPM hardware feature is designed to work without any driver support. It does need to be configured, which involves both the device and the upstream bridge, so it should be done by the BIOS or the PCI core. There are a few drivers (amdgpu, radeon, hfi1, e1000e, iwlegacy, ath10k, ath9k, mt76, rtlwifi, rtw88, and these rts cardreader drivers) that do it themselves, incorrectly.

But this particular patch only *reads* the ASPM control registers, without writing them, so it shouldn't make anything worse.

Bjorn

#10 lore raw
Quoted 11 lines · Bjorn Helgaas
Quoted 1 line

So is it ok to take this patch now, or does it need to be changed any?

Yes, it's OK with me if you take this patch.

The ASPM hardware feature is designed to work without any driver support. It does need to be configured, which involves both the device and the upstream bridge, so it should be done by the BIOS or the PCI core. There are a few drivers (amdgpu, radeon, hfi1, e1000e, iwlegacy, ath10k, ath9k, mt76, rtlwifi, rtw88, and these rts cardreader drivers) that do it themselves, incorrectly.

Quoted 2 lines

But this particular patch only *reads* the ASPM control registers, without writing them, so it shouldn't make anything worse.

Ok, thanks for the review, now queued up.

greg k-h

#11 lore raw

Sudden poweroffs when idle on ThinkPad x290s since v5.10-rc1 (bisected to 7c33e3c4c79a)

In reply to [email protected]

Hello,

After updating to the 5.10 kernel, my laptop will spontaneously poweroff when idle after some time (between 30 minutes and three days).

I have bisected it down to a rtsx driver update in 7c33e3c4c79a:

commit 7c33e3c4c79ac5def79e7c773e38a7113eb14204

Author: Ricky Wu <[email protected]>
Date:   Mon Sep 7 18:07:31 2020 +0800

misc: rtsx: Add power saving functions and fix driving parameter

v4:
split power down flow and power saving function to two patch

v5:
fix up modified change under the --- line

Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260 Fix rts5260 driving parameter

 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145 ++++++++++++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5260.c  |  28 +++----
 drivers/misc/cardreader/rtsx_pcr.h |  17 +++++
 4 files changed, 283 insertions(+), 19 deletions(-)

(See also <https://bugzilla.kernel.org/show_bug.cgi?id=211809>.)

I'm not sure whether this is a driver or hardware problem and am seeking feedback on how to further debug the issue.

FWIW the problem does not seem to reproduce on an AMD ThinkPad T14 Gen 1 with the same RTS522A PCIe card reader (on stock Arch 5.10.16 kernel).

Thanks & happy hacking,
Marius