Skip to contentSkip to conversation

scripts: coccicheck: Do not use shift command when rule is specified

PATCH Sumera Priyadarsini 1 participant 1 message Sep 9, 2020 1 message not in the archive Kernel janitors

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 8 lines · Markus Elfring

I find it helpful to avoid typos (like the following) in the change description.

Quoted 1 line

… Makfeile. …

… Makefile. …

Quoted 12 lines
Quoted 1 line

… paasing …

… passing …

Quoted 1 line

…, resuting …

…, resulting …

Quoted 1 line

This patch modifies coccicheck …

I did make those errors but I also rectified them. This is strange because my commit message shows the rectified version. Either way, I will send a v2. Thanks for pointing this out.

Quoted 5 lines

Would an imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8#n151

Regards,
Markus