Skip to contentSkip to conversation

riscv/mm/fault: fix old-style-declaration warning

PATCH In review Wei Yongjun 2 participants 2 messages Sep 9, 2020 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv/mm/fault: fix old-style-declaration warning

gcc report build warning as follows:

arch/riscv/mm/fault.c:81:1: warning:
'inline' is not at beginning of declaration [-Wold-style-declaration]
81 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)

      | ^~~~~~

This commit fix it by moving 'inline' after 'static'.

---
 arch/riscv/mm/fault.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/mm/fault.c +1 -1
index a23eaf5ce95c..a173432ccf82 100644
@@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
 	no_context(regs, addr);
 }
 
-static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
+static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
 {
 	pgd_t *pgd, *pgd_k;
 	pud_t *pud, *pud_k;

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#1 lore raw

Hi,

Quoted 11 lines · Wei Yongjun

gcc report build warning as follows:

arch/riscv/mm/fault.c:81:1: warning:
'inline' is not at beginning of declaration [-Wold-style-declaration]
81 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)

      | ^~~~~~

This commit fix it by moving 'inline' after 'static'.

Thanks for the fix, but Palmer committed similar fix from me to for-next:

https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=6f36a9635082e1d6910bc7853d0c9fd12d7890b5

- Pekka

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv