Skip to contentSkip to conversation

power: supply: charger-manager: Remove unused but set variable 'charger'

PATCH New Wei Yongjun 1 participant 1 message Sep 9, 2020 Power supply

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: supply: charger-manager: Remove unused but set variable 'charger'

Gcc report warning as follows:

drivers/power/supply/charger-manager.c:1626:29: warning:
variable 'charger' set but not used [-Wunused-but-set-variable]
1626 | struct charger_regulator *charger;
| ^~~~~~~

After c1f73028f75d ("power: supply: charger-manager: Update extcon functions"), 'charger' is never be used, so removing it to avoid build warning.

Fixes c1f73028f75d ("power: supply: charger-manager: Update extcon functions")
---
 drivers/power/supply/charger-manager.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/power/supply/charger-manager.c +1 -6
index 07992821e252..b2ca79173f95 100644
@@ -1622,13 +1622,8 @@ static int charger_manager_probe(struct platform_device *pdev)
 	return 0;
 
 err_reg_extcon:
-	for (i = 0; i < desc->num_charger_regulators; i++) {
-		struct charger_regulator *charger;
-
-		charger = &desc->charger_regulators[i];
-
+	for (i = 0; i < desc->num_charger_regulators; i++)
 		regulator_put(desc->charger_regulators[i].consumer);
-	}
 
 	power_supply_unregister(cm->charger_psy);