media: marvell-ccic: mmp: mark PM functions as __maybe_unused
PATCH 1/1 media: marvell-ccic: mmp: mark PM functions as __maybe_unused
The suspend/resume functions have no callers depending on configuration, so they must be marked __maybe_unused to avoid these harmless warnings:
drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning:
'mmpcam_resume' defined but not used [-Wunused-function]
347 | static int mmpcam_resume(struct device *dev)
| ^~~~~~~~~~~~~
drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning:
'mmpcam_suspend' defined but not used [-Wunused-function]
338 | static int mmpcam_suspend(struct device *dev)
| ^~~~~~~~~~~~~~Fixes 55cd34524aa3 ("media: marvell-ccic: add support for runtime PM")
Reported-by Hulk Robot <[email protected]>
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/media/platform/marvell-ccic/mmp-driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/marvell-ccic/mmp-driver.c +2 -2
@@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)return 0 ; } -static int mmpcam_suspend (struct device *dev) +static int __maybe_unused mmpcam_suspend (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);
@@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)return 0 ; } -static int mmpcam_resume (struct device *dev) +static int __maybe_unused mmpcam_resume (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);
Quoted 13 lines · Wei Yongjun
The suspend/resume functions have no callers depending on configuration, so they must be marked
__maybe_unusedto avoid these harmless warnings:
drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning:
'mmpcam_resume' defined but not used [-Wunused-function]
347 | static intmmpcam_resume(struct device *dev)| ^~~~~~~~~~~~~ drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: 'mmpcam_suspend' defined but not used [-Wunused-function] 338 | static int mmpcam_suspend(struct device *dev) | ^~~~~~~~~~~~~~
Quoted 3 lines
Fixes 55cd34524aa3 ("media: marvell-ccic: add support for runtime PM")Reported-by Hulk Robot <[email protected]>Signed-off-by Wei Yongjun <[email protected]>
Acked-by Lubomir Rintel <[email protected]>
Thank you!
Lubo
Quoted 27 lines
--- drivers/media/platform/marvell-ccic/mmp-driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/marvell-ccic/mmp-driver.c +2
-2@@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)return 0 ; } -static int mmpcam_suspend (struct device *dev) +static int __maybe_unused mmpcam_suspend (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);@@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)return 0 ; } -static int mmpcam_resume (struct device *dev) +static int __maybe_unused mmpcam_resume (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);