drm/panfrost: Ensure GPU quirks are always initialised
Subsystems (3)
Steven Price
maintainerPATCH 1/1 drm/panfrost: Ensure GPU quirks are always initialised
The GPU 'CONFIG' registers used to work around hardware issues are cleared on reset so need to be programmed every time the GPU is reset. However panfrost_device_reset() failed to do this.
To avoid this in future instead move the call to panfrost_gpu_init_quirks() to panfrost_gpu_power_on() so that the regsiters are always programmed just before the cores are powered.
--- drivers/gpu/drm/panfrost/panfrost_gpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/panfrost/panfrost_gpu.c +2 -1
@@ -305,6 +305,8 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)int ret;u32 val; +panfrost_gpu_init_quirks (pfdev); +/* Just turn on everything for now */ gpu_write (pfdev,L2_PWRON_LO , pfdev->features.l2_present); ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,
@@ -356,7 +358,6 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)return err; } -panfrost_gpu_init_quirks (pfdev);panfrost_gpu_power_on (pfdev);return 0 ;
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 24 lines
drivers/gpu/drm/panfrost/panfrost_gpu.c +2
-1@@ -305,6 +305,8 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)int ret;u32 val; +panfrost_gpu_init_quirks (pfdev); +/* Just turn on everything for now */ gpu_write (pfdev,L2_PWRON_LO , pfdev->features.l2_present); ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,@@ -356,7 +358,6 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)return err; } -panfrost_gpu_init_quirks (pfdev);panfrost_gpu_power_on (pfdev);return 0 ;Signature · 1 line
2.20.1
Quoted 10 lines · Steven Price
The GPU 'CONFIG' registers used to work around hardware issues are cleared on reset so need to be programmed every time the GPU is reset. However
panfrost_device_reset()failed to do this.To avoid this in future instead move the call to
panfrost_gpu_init_quirks()topanfrost_gpu_power_on()so that the regsiters are always programmed just before the cores are powered.Fixes f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")Signed-off-by Steven Price <[email protected]>
Applied to drm-misc-next
Steve
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel