linux-next: build warning after merge of the pci tree
Hi all,
After merging the pci tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:
drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off' [-Wunused-variable]
142 | u32 exp_cap_off = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
| ^~~~~~~~~~~Introduced by commit
3af45d34d30c ("PCI: dwc: Centralize link gen setting")
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 5 lines · Stephen Rothwell
Hi all,
After merging the pci tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
Uggg. I guess 0-day just doesn't do arm32 builds anymore as it caught more obscure build issues, but not this one (and some others I've had recently).
Quoted 12 lines
drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off' [-Wunused-variable]142 | u32 exp_cap_off = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); | ^~~~~~~~~~~Introduced by commit
3af45d34d30c("PCI: dwc: Centralize link gen setting")--
Cheers,
Stephen Rothwell
Hi all,
Quoted 18 lines · On Wed, 9 Sep 2020 10:06:20 -0600 Rob Herring <[email protected]> wrote:
Quoted 3 lines · Stephen Rothwell
After merging the pci tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:Uggg. I guess 0-day just doesn't do arm32 builds anymore as it caught more obscure build issues, but not this one (and some others I've had recently).
Quoted 8 lines
drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off' [-Wunused-variable]142 | u32 exp_cap_off = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); | ^~~~~~~~~~~Introduced by commit
3af45d34d30c("PCI: dwc: Centralize link gen setting")
I am still getting this warning.
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 18 lines · Stephen Rothwell
Hi all,
Quoted 15 lines · On Wed, 9 Sep 2020 10:06:20 -0600 Rob Herring <[email protected]> wrote:
Quoted 3 lines · Stephen Rothwell
After merging the pci tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:Uggg. I guess 0-day just doesn't do arm32 builds anymore as it caught more obscure build issues, but not this one (and some others I've had recently).
Quoted 5 lines
drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off' [-Wunused-variable]142 | u32 exp_cap_off = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); | ^~~~~~~~~~~
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Introduced by commit
3af45d34d30c("PCI: dwc: Centralize link gen setting")I am still getting this warning.
I have pushed out a fix-up on my pci/dwc branch, the warning should disappear as soon as Bjorn pulls it.
Thanks,
Lorenzo
Quoted 19 lines · Lorenzo Pieralisi
Quoted 18 lines · Stephen Rothwell
Hi all,
Quoted 15 lines · On Wed, 9 Sep 2020 10:06:20 -0600 Rob Herring <[email protected]> wrote:
Quoted 3 lines · Stephen Rothwell
After merging the pci tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:Uggg. I guess 0-day just doesn't do arm32 builds anymore as it caught more obscure build issues, but not this one (and some others I've had recently).
Quoted 5 lines
drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off' [-Wunused-variable]142 | u32 exp_cap_off = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); | ^~~~~~~~~~~
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Introduced by commit
3af45d34d30c("PCI: dwc: Centralize link gen setting")I am still getting this warning.
I have pushed out a fix-up on my pci/dwc branch, the warning should disappear as soon as Bjorn pulls it.
Thanks for the reminder. Should be fixed.