configure: Do not intent to build WHPX on 32-bit host
PATCH 1/1 configure: Do not intent to build WHPX on 32-bit host
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.
--- configure | 3 +++ 1 file changed, 3 insertions(+)
configure +3 -0
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then fi whpx="no" fi + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then + error_exit "WHPX requires 64-bit host" + fi fi ##########################################
Signature · 1 line
2.26.2
Quoted 13 lines · Philippe Mathieu-Daudé
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 3 +++ 1 file changed, 3 insertions(+)configure +0
-0
configure if test "$whpx" != "no" ; then · line 2995
Quoted 7 lines
configure +3
-0@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then fi whpx="no" fi + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then + error_exit "WHPX requires 64-bit host" + fi fi
I think you should also add a check to the MINGW32 case (see commit e7a222aeb813a) to prevent that the automatic detection kicks in (so that you would end up with this error message even if you did not specify --enable-whpx)
Thomas
Am 09.09.20 um 20:40 schrieb Thomas Huth:
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 13 lines
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 3 +++ 1 file changed, 3 insertions(+)configure +0
-0configure if test "$whpx" != "no" ; then · line 2995
Quoted 7 lines
configure +3
-0@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then fi whpx="no" fi + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then + error_exit "WHPX requires 64-bit host" + fi fiI think you should also add a check to the MINGW32 case (see commit
e7a222aeb813a) to prevent that the automatic detection kicks in (so that you would end up with this error message even if you did not specify --enable-whpx)
Quoted 2 lines
Thomas
Yes, that's definitely required. The automatic detection currently enables WHPX for 32 bit builds, too.
Stefan
Quoted 36 lines
Am 09.09.20 um 20:40 schrieb Thomas Huth:
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 13 lines
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 3 +++ 1 file changed, 3 insertions(+)configure +0
-0configure if test "$whpx" != "no" ; then · line 2995
Quoted 7 lines
configure +3
-0@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then fi whpx="no" fi + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then + error_exit "WHPX requires 64-bit host" + fi fiI think you should also add a check to the MINGW32 case (see commit
e7a222aeb813a) to prevent that the automatic detection kicks in (so that you would end up with this error message even if you did not specify --enable-whpx)Quoted 2 lines
Thomas
Yes, that's definitely required. The automatic detection currently enables WHPX for 32 bit builds, too.
Stefan
Paolo Bonzini
AppliedQuoted 14 lines · Philippe Mathieu-Daudé
Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- configure | 3 +++ 1 file changed, 3 insertions(+)configure +0
-0
configure if test "$whpx" != "no" ; then · line 2997
Quoted 9 lines
configure +3
-0@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then fi whpx="no" fi + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then + error_exit "WHPX requires 64-bit host" + fi fi ##########################################
Queued, thanks.
Paolo