Skip to contentSkip to conversation

configure: Do not intent to build WHPX on 32-bit host

PATCH Applied Philippe Mathieu-Daudé 5 participants 5 messages Sep 9, 2020 – Sep 11, 2020

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Do not intent to build WHPX on 32-bit host

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +3 -0
index 4231d56bcc0..4bd08f5469b 100755
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
         fi
         whpx="no"
     fi
+    if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
+      error_exit "WHPX requires 64-bit host"
+    fi
 fi
 
 ##########################################
Signature · 1 line
2.26.2
#1 lore raw
Quoted 13 lines · Philippe Mathieu-Daudé

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +0 -0
index 4231d56bcc0..4bd08f5469b 100755

configure if test "$whpx" != "no" ; then · line 2995

Quoted 7 lines
configure +3 -0
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
         fi
         whpx="no"
     fi
+    if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
+      error_exit "WHPX requires 64-bit host"
+    fi
 fi

I think you should also add a check to the MINGW32 case (see commit e7a222aeb813a) to prevent that the automatic detection kicks in (so that you would end up with this error message even if you did not specify --enable-whpx)

Thomas

#2 lore raw

Am 09.09.20 um 20:40 schrieb Thomas Huth:

Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 13 lines

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +0 -0
index 4231d56bcc0..4bd08f5469b 100755

configure if test "$whpx" != "no" ; then · line 2995

Quoted 7 lines
configure +3 -0
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
         fi
         whpx="no"
     fi
+    if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
+      error_exit "WHPX requires 64-bit host"
+    fi
 fi

I think you should also add a check to the MINGW32 case (see commit e7a222aeb813a) to prevent that the automatic detection kicks in (so that you would end up with this error message even if you did not specify --enable-whpx)

Quoted 2 lines

Thomas

Yes, that's definitely required. The automatic detection currently enables WHPX for 32 bit builds, too.

Stefan

#3 lore raw
Quoted 36 lines

Am 09.09.20 um 20:40 schrieb Thomas Huth:

Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 13 lines

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +0 -0
index 4231d56bcc0..4bd08f5469b 100755

configure if test "$whpx" != "no" ; then · line 2995

Quoted 7 lines
configure +3 -0
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
         fi
         whpx="no"
     fi
+    if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
+      error_exit "WHPX requires 64-bit host"
+    fi
 fi

I think you should also add a check to the MINGW32 case (see commit e7a222aeb813a) to prevent that the automatic detection kicks in (so that you would end up with this error message even if you did not specify --enable-whpx)

Quoted 2 lines

Thomas

Yes, that's definitely required. The automatic detection currently enables WHPX for 32 bit builds, too.

Stefan

#4 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 14 lines · Philippe Mathieu-Daudé

Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions.

---
 configure | 3 +++
 1 file changed, 3 insertions(+)
configure +0 -0
index 4231d56bcc0..4bd08f5469b 100755

configure if test "$whpx" != "no" ; then · line 2997

Quoted 9 lines
configure +3 -0
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
         fi
         whpx="no"
     fi
+    if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
+      error_exit "WHPX requires 64-bit host"
+    fi
 fi
 
 ##########################################

Queued, thanks.

Paolo