Skip to contentSkip to conversation

libcap: disable GOLANG

PATCH New Tian Yuanhao 4 participants 6 messages Aug 31, 2020 – Sep 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libcap: disable GOLANG

libcap is a pure C library before 2.27, it lacks some environment variables set in pkg-golang.mk.

---
 ?package/libcap/libcap.mk | 4 ++--

?1 file changed, 2 insertions(+), 2 deletions(-)

package/libcap/libcap.mk +2 -2
index 08c1bc9..5843ef9 100644
@@ -62,12 +62,12 @@ endef
 
 ?define HOST_LIBCAP_BUILD_CMDS
 ???? $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)\
-??? ??? RAISE_SETFCAP=no
+??? ??? GOLANG=no RAISE_SETFCAP=no
 ?endef
 
 ?define HOST_LIBCAP_INSTALL_CMDS
 ???? $(HOST_MAKE_ENV) $(MAKE) -C $(@D) prefix=$(HOST_DIR) \
-??? ??? RAISE_SETFCAP=no lib=lib install
+??? ??? GOLANG=no RAISE_SETFCAP=no lib=lib install
 ?endef
 
 ?$(eval $(generic-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 libcap: disable GOLANG

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Tian" == Tian Yuanhao via buildroot <[email protected]> writes:

libcap is a pure C library before 2.27, it lacks some environment variables set in pkg-golang.mk.

Can you be more specific? What exactly is this fixing? I don't see any related autobuilder errors?

http://autobuild.buildroot.net/?reason=libcap-2.27

And I don't see any reference to GOLANG in libcap-2.27?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 libcap: disable GOLANG

This patch is for the next branch.

Recently, the go infrastructure has changed, and libcap has been upgraded to 2.42. libcap introduced golang in 2.28, see:

https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f

When you compile host-go and then compile host-libcap, GOLANG will be automatically set to yes. Because libcap.mk lacks golang support, compilation will fail.

Quoted 9 lines
Quoted 2 lines

libcap is a pure C library before 2.27, it lacks some environment variables set in pkg-golang.mk.

Can you be more specific? What exactly is this fixing? I don't see any related autobuilder errors?

http://autobuild.buildroot.net/?reason=libcap-2.27

And I don't see any reference to GOLANG in libcap-2.27?

#3 lore raw

PATCH 1/1 libcap: disable GOLANG

Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Tian" == Tian Yuanhao via buildroot <[email protected]> writes:

This patch is for the next branch.

Ahh, then please mention that. An easy way to do that is using the --subject-prefix argument to git send-email, E.G.:

git send-email --subject-prefix='PATCH-NEXT' ..

Quoted 8 lines

Recently, the go infrastructure has changed, and libcap has been upgraded to 2.42. libcap introduced golang in 2.28, see:

https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f

When you compile host-go and then compile host-libcap, GOLANG will be automatically set to yes. Because libcap.mk lacks golang support, compilation will fail.

OK.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 libcap: disable GOLANG

Hi,

Quoted 19 lines · Peter Korsgaard
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Tian" == Tian Yuanhao via buildroot <[email protected]> writes:

This patch is for the next branch.

Ahh, then please mention that. An easy way to do that is using the --subject-prefix argument to git send-email, E.G.:

git send-email --subject-prefix='PATCH-NEXT' ..

Quoted 8 lines

Recently, the go infrastructure has changed, and libcap has been upgraded to 2.42. libcap introduced golang in 2.28, see:

https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f

When you compile host-go and then compile host-libcap, GOLANG will be automatically set to yes. Because libcap.mk lacks golang support, compilation will fail.

This fixes a build issue with libcap 2.42 when ccache is enabled.

https://gist.github.com/jakogut/3675b4a692da1b87b59056fec71575b4

Minor suggestion, but perhaps we should move these flags to HOST_LIBCAP_MAKE_FLAGS to mirror how the target package is built?

Regardless,

#5 lore raw

PATCH 1/1 libcap: disable GOLANG

In reply to Tian Yuanhao

Tian Yuanhao, All,

On 2020-09-01 00:14 +0800, Tian Yuanhao via buildroot spake thusly:

Quoted 10 lines

This patch is for the next branch.

Recently, the go infrastructure has changed, and libcap has been upgraded to 2.42. libcap introduced golang in 2.28, see:

https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f

When you compile host-go and then compile host-libcap, GOLANG will be automatically set to yes. Because libcap.mk lacks golang support, compilation will fail.

I've taken those explanations and used them as the new commit log, and applied the patch.

However, the patch was mangled: TABs were replaced by spaces, so I had to fix that too.

Applied to master, thanks!

Regards,
Yann E. MORIN.

Quoted 14 lines
Quoted 9 lines
Quoted 2 lines

libcap is a pure C library before 2.27, it lacks some environment variables set in pkg-golang.mk.

Can you be more specific? What exactly is this fixing? I don't see any related autobuilder errors?

http://autobuild.buildroot.net/?reason=libcap-2.27

And I don't see any reference to GOLANG in libcap-2.27?

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'