Skip to contentSkip to conversation

gitignore: Create .gitignore file for tools/ocaml/

RFC PATCH In review Elliott Mitchell 2 participants 2 messages Sep 9, 2020 – Sep 10, 2020

lore
Share & tools
lore
#0 lore raw

RFC PATCH 5/11 gitignore: Create .gitignore file for tools/ocaml/

The portion of the global .gitignore attributeable to tools/ocaml/ is significant. As such, create a local .gitignore file. Currently the OCAML bits for Xen are also somewhat contained to this one area too.

Slashes were left at the start of all filenames. Entries without slashes match files in subdirectories, entries with a slash anywhere are a specific path. I feel it is more consistent to have leading slashes on all full paths.

---
I have a suspicion several of the patterns *should* be more general and/or the OCAML area could use some local ignore patterns.

In particular "*.annot", "*.cm[ixao]", "*.cmxa", ".ocamldep.make" and "META" might be appropriate as general patterns for tools/ocaml/ and not be restricted to subdirectories.

---
 .gitignore             | 28 ----------------------------
 tools/ocaml/.gitignore | 24 ++++++++++++++++++++++++
 2 files changed, 24 insertions(+), 28 deletions(-)
 create mode 100644 tools/ocaml/.gitignore
.gitignore +0 -28
index 08800a11d5..297cd59c5c 100644
@@ -284,34 +284,6 @@ tools/libxl/test_timedereg
 tools/libxl/test_fdderegrace
 tools/libvchan/vchan-node[12]
 tools/libvchan/vchan-socket-proxy
-tools/ocaml/*/.ocamldep.make
-tools/ocaml/*/*.cm[ixao]
-tools/ocaml/*/*.cmxa
-tools/ocaml/*/*.annot
-tools/ocaml/*/*/.ocamldep.make
-tools/ocaml/*/*/*.cm[ixao]
-tools/ocaml/*/*/*.cmxa
-tools/ocaml/*/*/*.annot
-tools/ocaml/*/*/META
-tools/ocaml/libs/xl/_libxl_types.inc
-tools/ocaml/libs/xl/_libxl_types.ml.in
-tools/ocaml/libs/xl/_libxl_types.mli.in
-tools/ocaml/libs/xl/xenlight.ml
-tools/ocaml/libs/xl/xenlight.mli
-tools/ocaml/libs/xentoollog/_xtl_levels.*
-tools/ocaml/libs/xentoollog/xentoollog.ml
-tools/ocaml/libs/xentoollog/xentoollog.mli
-tools/ocaml/libs/xs/paths.ml
-tools/ocaml/libs/xc/xenctrl_abi_check.h
-tools/ocaml/xenstored/_paths.h
-tools/ocaml/xenstored/oxenstored
-tools/ocaml/xenstored/oxenstored.conf
-tools/ocaml/xenstored/paths.ml
-tools/ocaml/test/xtl
-tools/ocaml/test/send_debug_keys
-tools/ocaml/test/list_domains
-tools/ocaml/test/dmesg
-tools/ocaml/test/raise_exception
 tools/debugger/kdd/kdd
 tools/python/xen/lowlevel/xl/_pyxl_types.c
 tools/python/xen/lowlevel/xl/_pyxl_types.h
tools/ocaml/.gitignore new file +24 -0
new file mode 100644
index 0000000000..8b50454937
@@ -0,0 +1,24 @@
+/*/**/*.annot
+/*/**/*.cm[ixao]
+/*/**/*.cmxa
+/*/**/.ocamldep.make
+/*/*/META
+/libs/xc/xenctrl_abi_check.h
+/libs/xentoollog/_xtl_levels.*
+/libs/xentoollog/xentoollog.ml
+/libs/xentoollog/xentoollog.mli
+/libs/xl/_libxl_types.inc
+/libs/xl/_libxl_types.ml.in
+/libs/xl/_libxl_types.mli.in
+/libs/xl/xenlight.ml
+/libs/xl/xenlight.mli
+/libs/xs/paths.ml
+/test/dmesg
+/test/list_domains
+/test/raise_exception
+/test/send_debug_keys
+/test/xtl
+/xenstored/_paths.h
+/xenstored/oxenstored
+/xenstored/oxenstored.conf
+/xenstored/paths.ml
Signature · 5 lines
-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         [email protected]  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
Acked-by on v1 5/11
#1 lore raw

Fine with me. Edvin is using locally for the OCaml part a Dune-based build that does away with a lot of the cruft because it puts all files generated during a build into _build/ directory which then is enough to ignore. IMHO that is the direction of the future.

--

________________________________
From: Elliott Mitchell <[email protected]>
Sent: 03 September 2020 05:10
To: [email protected] <[email protected]>
Cc: Andrew Cooper <[email protected]>; George Dunlap <[email protected]>; Ian Jackson <[email protected]>; Jan Beulich <[email protected]>; Julien Grall <[email protected]>; Stefano Stabellini <[email protected]>; Wei Liu <[email protected]>; Christian Lindig <[email protected]>; David Scott <[email protected]>
Subject: [PATCH 05/11 RFC] gitignore: Create .gitignore file for tools/ocaml/

The portion of the global .gitignore attributeable to tools/ocaml/ is significant. As such, create a local .gitignore file. Currently the OCAML bits for Xen are also somewhat contained to this one area too.

Slashes were left at the start of all filenames. Entries without slashes match files in subdirectories, entries with a slash anywhere are a specific path. I feel it is more consistent to have leading slashes on all full paths.

---
I have a suspicion several of the patterns *should* be more general and/or the OCAML area could use some local ignore patterns.

In particular "*.annot", "*.cm[ixao]", "*.cmxa", ".ocamldep.make" and "META" might be appropriate as general patterns for tools/ocaml/ and not be restricted to subdirectories.

---
 .gitignore             | 28 ----------------------------
 tools/ocaml/.gitignore | 24 ++++++++++++++++++++++++
 2 files changed, 24 insertions(+), 28 deletions(-)
 create mode 100644 tools/ocaml/.gitignore
.gitignore +0 -28
index 08800a11d5..297cd59c5c 100644
@@ -284,34 +284,6 @@ tools/libxl/test_timedereg
 tools/libxl/test_fdderegrace
 tools/libvchan/vchan-node[12]
 tools/libvchan/vchan-socket-proxy
-tools/ocaml/*/.ocamldep.make
-tools/ocaml/*/*.cm[ixao]
-tools/ocaml/*/*.cmxa
-tools/ocaml/*/*.annot
-tools/ocaml/*/*/.ocamldep.make
-tools/ocaml/*/*/*.cm[ixao]
-tools/ocaml/*/*/*.cmxa
-tools/ocaml/*/*/*.annot
-tools/ocaml/*/*/META
-tools/ocaml/libs/xl/_libxl_types.inc
-tools/ocaml/libs/xl/_libxl_types.ml.in
-tools/ocaml/libs/xl/_libxl_types.mli.in
-tools/ocaml/libs/xl/xenlight.ml
-tools/ocaml/libs/xl/xenlight.mli
-tools/ocaml/libs/xentoollog/_xtl_levels.*
-tools/ocaml/libs/xentoollog/xentoollog.ml
-tools/ocaml/libs/xentoollog/xentoollog.mli
-tools/ocaml/libs/xs/paths.ml
-tools/ocaml/libs/xc/xenctrl_abi_check.h
-tools/ocaml/xenstored/_paths.h
-tools/ocaml/xenstored/oxenstored
-tools/ocaml/xenstored/oxenstored.conf
-tools/ocaml/xenstored/paths.ml
-tools/ocaml/test/xtl
-tools/ocaml/test/send_debug_keys
-tools/ocaml/test/list_domains
-tools/ocaml/test/dmesg
-tools/ocaml/test/raise_exception
 tools/debugger/kdd/kdd
 tools/python/xen/lowlevel/xl/_pyxl_types.c
 tools/python/xen/lowlevel/xl/_pyxl_types.h
tools/ocaml/.gitignore new file +24 -0
new file mode 100644
index 0000000000..8b50454937
@@ -0,0 +1,24 @@
+/*/**/*.annot
+/*/**/*.cm[ixao]
+/*/**/*.cmxa
+/*/**/.ocamldep.make
+/*/*/META
+/libs/xc/xenctrl_abi_check.h
+/libs/xentoollog/_xtl_levels.*
+/libs/xentoollog/xentoollog.ml
+/libs/xentoollog/xentoollog.mli
+/libs/xl/_libxl_types.inc
+/libs/xl/_libxl_types.ml.in
+/libs/xl/_libxl_types.mli.in
+/libs/xl/xenlight.ml
+/libs/xl/xenlight.mli
+/libs/xs/paths.ml
+/test/dmesg
+/test/list_domains
+/test/raise_exception
+/test/send_debug_keys
+/test/xtl
+/xenstored/_paths.h
+/xenstored/oxenstored
+/xenstored/oxenstored.conf
+/xenstored/paths.ml

--

--
(\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/)

 \BS (    |         [email protected]  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445