container-base: rename recipe
PATCH 1/1 container-base: rename recipe
Change to container-base-image since the convention is to have "image" in image recipe names.
---
recipes-extended/images/{container-base.bb => contain-base-image.bb} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename recipes-extended/images/{container-base.bb => contain-base-image.bb} (100%)recipes-extended/images/contain-base-image.bb renamed from recipes-extended/images/container-base.bb +0 -0
Signature · 1 line
2.7.4
Except that this breaks existing users.
We'll leave this as-is.
Bruce
Quoted 18 lines · Joe Slater
Change to container-base-image since the convention is to have "image" in image recipe names.
Signed-off-by Joe Slater <[email protected]>--- recipes-extended/images/{container-base.bb => contain-base-image.bb} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename recipes-extended/images/{container-base.bb => contain-base-image.bb} (100%)recipes-extended/images/contain-base-image.bb renamed from recipes-extended/images/container-base.bb +0
-1--2.7.4
Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
Quoted 10 lines
-----Original Message-----
From: [email protected] <meta- [email protected]> On Behalf Of Bruce Ashfield
Sent: den 10 september 2020 02:03
To: Joe Slater <[email protected]>
Cc: meta-virtualization <[email protected]>; Randy MacLeod <[email protected]>
Subject: Re: [meta-virtualization] [meta-virt][PATCH 1/1] container-base:
rename recipe
Quoted 3 lines
Except that this breaks existing users.
We'll leave this as-is.
Well, you could add a new container-base.bb recipe that only does:
# This recipe is deprecated. Please use container-base-image instead
require container-base-image.bb
to care for backwards compatibility. You could also add an anonymous Python function, or probably better, hook into ROOTFS_PREPROCESS_COMMAND, with a bb.warn() about the deprecation state of the old name.
Regarding the name of the image recipe, wouldn't "container-image-base" be more in line with existing image recipes?
Quoted 11 lines
Bruce
Quoted 7 lines · Joe Slater
Change to container-base-image since the convention is to have "image" in image recipe names.
Signed-off-by Joe Slater <[email protected]>--- recipes-extended/images/{container-base.bb => contain-base-image.bb} | 0
I believe the intended name was "container-base-image.bb"?
Quoted 7 lines
recipes-extended/images/contain-base-image.bb
Quoted 7 lines
1 file changed, 0 insertions(+), 0 deletions(-) rename recipes-extended/images/{container-base.bb => contain-base-image.bb} (100%)recipes-extended/images/contain-base-image.bb renamed from recipes-extended/images/container-base.bb +0
-0
//Peter
Quoted 11 lines · Peter Kjellerstedt
Quoted 11 lines
-----Original Message-----
From: [email protected] <meta- [email protected]> On Behalf Of Bruce Ashfield
Sent: den 10 september 2020 02:03
To: Joe Slater <[email protected]>
Cc: meta-virtualization <[email protected]>; Randy MacLeod <[email protected]>
Subject: Re: [meta-virtualization] [meta-virt][PATCH 1/1] container-base:
rename recipe
Quoted 6 lines
Quoted 3 lines
Except that this breaks existing users.
We'll leave this as-is.
Well, you could add a new container-base.bb recipe that only does:
Of course .. there's literally 10 different ways it could be done.
But in the end, it is all churn for the sake of churn, and I'll opt to leave things as-is, since nothing is broken and no harm is being done.
Cheers,
Bruce
Quoted 36 lines
# This recipe is deprecated. Please use container-base-image instead
require container-base-image.bb
to care for backwards compatibility. You could also add an anonymous Python function, or probably better, hook into
ROOTFS_PREPROCESS_COMMAND, with abb.warn()about the deprecation state of the old name.Regarding the name of the image recipe, wouldn't "container-image-base" be more in line with existing image recipes?
Quoted 11 lines
Bruce
Quoted 7 lines · Joe Slater
Change to container-base-image since the convention is to have "image" in image recipe names.
Signed-off-by Joe Slater <[email protected]>--- recipes-extended/images/{container-base.bb => contain-base-image.bb} | 0I believe the intended name was "container-base-image.bb"?
Quoted 7 lines
recipes-extended/images/contain-base-image.bb
Quoted 7 lines
1 file changed, 0 insertions(+), 0 deletions(-) rename recipes-extended/images/{container-base.bb => contain-base-image.bb} (100%)recipes-extended/images/contain-base-image.bb renamed from recipes-extended/images/container-base.bb +0
-0//Peter
Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II