Arm Tune Clean-Ups
cover Arm Tune Clean-Ups
A few clean-ups and fixes for Arm tune files found while working on the follow-on series. Since the changes are needed and not necessarily part of that series, I'm sending it as a separate series.
Jon Mason (4):
cortex-m0plus.inc: change file permissions tune-cortexa55.inc: clean-up ARMv8.2a uses tune-cortexa57-cortexa53.inc: add CRC and set march tune-cortexa*: Cleanups
meta/conf/machine/include/tune-cortex-m0plus.inc | 0 meta/conf/machine/include/tune-cortexa32.inc | 2 +- meta/conf/machine/include/tune-cortexa35.inc | 2 +- meta/conf/machine/include/tune-cortexa53.inc | 2 +- meta/conf/machine/include/tune-cortexa55.inc | 4 ++-- meta/conf/machine/include/tune-cortexa57-cortexa53.inc | 4 ++-- meta/conf/machine/include/tune-cortexa57.inc | 2 +- meta/conf/machine/include/tune-cortexa72-cortexa53.inc | 2 +- meta/conf/machine/include/tune-cortexa73-cortexa53.inc | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) mode change 100755 => 100644 meta/conf/machine/include/tune-cortex-m0plus.inc
Signature · 1 line
2.20.1
PATCH 1/4 cortex-m0plus.inc: change file permissions
File is executable, and should be read/write.
--- meta/conf/machine/include/tune-cortex-m0plus.inc | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 meta/conf/machine/include/tune-cortex-m0plus.inc
meta/conf/machine/include/tune-cortex-m0plus.inc +0 -0
Signature · 1 line
2.20.1
PATCH 2/4 tune-cortexa55.inc: clean-up ARMv8.2a uses
In reply to Jon MasonRemove 'crc', as that is implied by 8.2 (per GCC
https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html#AArch64-Options).
Also, the PACKAGE_EXTRA_ARCHS should refer to the ARMv8.2a version, not the more generic ARMv8 version.
--- meta/conf/machine/include/tune-cortexa55.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/machine/include/tune-cortexa55.inc +2 -2
@@ -8,6 +8,6 @@ require conf/machine/include/arm/arch-armv8-2a.inc # Little Endian base configs AVAILTUNES += "cortexa55" ARMPKGARCH_tune-cortexa55 = "cortexa55" -TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crc crypto" -PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa55" +TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8-2a-crypto} cortexa55" BASE_LIB_tune-cortexa55 = "lib64"
Signature · 1 line
2.20.1
PATCH 3/4 tune-cortexa57-cortexa53.inc: add CRC and set march
In reply to Jon MasonAdd CRC to the default tuning of big.LITTLE Cortex-A57-A53. This puts it inline with all other ARMv8a tunings. Also, reference PACKAGE_EXTRA_ARCHS_tune-armv8a-crc instead of PACKAGE_EXTRA_ARCHS_tune-aarch64, which sets the -march to armv8 and enables the CRC.
--- meta/conf/machine/include/tune-cortexa57-cortexa53.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/machine/include/tune-cortexa57-cortexa53.inc +2 -2
@@ -10,6 +10,6 @@ require conf/machine/include/arm/arch-armv8a.inc # Little Endian base configs AVAILTUNES += "cortexa57-cortexa53" ARMPKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53" -TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 cortexa57-cortexa53" -PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa57-cortexa53" +TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 crc cortexa57-cortexa53" +PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57-cortexa53" BASE_LIB_tune-cortexa57-cortexa53 = "lib64"
Signature · 1 line
2.20.1
Re: [OE-core] [meta-oe][PATCH 3/4] tune-cortexa57-cortexa53.inc: add CRC and set march
Quoted 16 lines · Jon Mason
Add CRC to the default tuning of big.LITTLE Cortex-A57-A53. This puts it inline with all other ARMv8a tunings. Also, reference PACKAGE_EXTRA_ARCHS_tune-armv8a-crc instead of PACKAGE_EXTRA_ARCHS_tune-aarch64, which sets the -march to armv8 and enables the CRC.
Signed-off-by Jon Mason <[email protected]>--- meta/conf/machine/include/tune-cortexa57-cortexa53.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)meta/conf/machine/include/tune-cortexa57-cortexa53.inc +0
-0
meta/conf/machine/include/tune-cortexa57-cortexa53.inc require conf/machine/include/arm/arch-armv8a.inc · line 14
Quoted 7 lines
meta/conf/machine/include/tune-cortexa57-cortexa53.inc +2
-2@@ -10,6 +10,6 @@ require conf/machine/include/arm/arch-armv8a.inc # Little Endian base configs AVAILTUNES += "cortexa57-cortexa53" ARMPKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53" -TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 cortexa57-cortexa53" -PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa57-cortexa53" +TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 crc cortexa57-cortexa53" +PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57-cortexa53"
So all a57 and a53 (as well as big.LITTLE) contain the CRC unit?
I use the a72/a53, but I use it as a common intersection for software for multiple products. One has an a72 and one has an a53, so it's not a true bigLittle configuration. I could see someone try this using this tune as well.
--Mark
Quoted 5 lines
meta/conf/machine/include/tune-cortexa57-cortexa53.inc +0
-0BASE_LIB_tune-cortexa57-cortexa53 = "lib64"
PATCH 4/4 tune-cortexa*: Cleanups
In reply to Jon MasonMake the existing ARMv8 Cortex-A tunings similar in the way the cascade the settings.
--- meta/conf/machine/include/tune-cortexa32.inc | 2 +- meta/conf/machine/include/tune-cortexa35.inc | 2 +- meta/conf/machine/include/tune-cortexa53.inc | 2 +- meta/conf/machine/include/tune-cortexa57.inc | 2 +- meta/conf/machine/include/tune-cortexa72-cortexa53.inc | 2 +- meta/conf/machine/include/tune-cortexa73-cortexa53.inc | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/tune-cortexa32.inc +1 -1
@@ -11,7 +11,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto" ARMPKGARCH_tune-cortexa32 = "cortexa32" ARMPKGARCH_tune-cortexa32-crypto = "cortexa32" TUNE_FEATURES_tune-cortexa32 = "armv8a cortexa32 crc" -TUNE_FEATURES_tune-cortexa32-crypto = "armv8a cortexa32 crc crypto" +TUNE_FEATURES_tune-cortexa32-crypto = "${TUNE_FEATURES_tune-cortexa32} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa32 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa32" PACKAGE_EXTRA_ARCHS_tune-cortexa32-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa32 cortexa32-crypto" BASE_LIB_tune-cortexa32 = "lib"
meta/conf/machine/include/tune-cortexa35.inc +1 -1
@@ -10,7 +10,7 @@ AVAILTUNES += "cortexa35 cortexa35-crypto" ARMPKGARCH_tune-cortexa35 = "cortexa35" ARMPKGARCH_tune-cortexa35-crypto = "cortexa35" TUNE_FEATURES_tune-cortexa35 = "aarch64 cortexa35 crc" -TUNE_FEATURES_tune-cortexa35-crypto = "aarch64 cortexa35 crc crypto" +TUNE_FEATURES_tune-cortexa35-crypto = "${TUNE_FEATURES_tune-cortexa35} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa35 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa35" PACKAGE_EXTRA_ARCHS_tune-cortexa35-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa35 cortexa35-crypto" BASE_LIB_tune-cortexa35 = "lib64"
meta/conf/machine/include/tune-cortexa53.inc +1 -1
@@ -10,7 +10,7 @@ AVAILTUNES += "cortexa53 cortexa53-crypto" ARMPKGARCH_tune-cortexa53 = "cortexa53" ARMPKGARCH_tune-cortexa53-crypto = "cortexa53-crypto" TUNE_FEATURES_tune-cortexa53 = "aarch64 cortexa53 crc" -TUNE_FEATURES_tune-cortexa53-crypto = "aarch64 cortexa53 crc crypto" +TUNE_FEATURES_tune-cortexa53-crypto = "${TUNE_FEATURES_tune-cortexa53} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa53 cortexa53-crypto"
meta/conf/machine/include/tune-cortexa57.inc +1 -1
@@ -10,7 +10,7 @@ AVAILTUNES += "cortexa57 cortexa57-crypto" ARMPKGARCH_tune-cortexa57 = "cortexa57" ARMPKGARCH_tune-cortexa57-crypto = "cortexa57-crypto" TUNE_FEATURES_tune-cortexa57 = "aarch64 cortexa57 crc" -TUNE_FEATURES_tune-cortexa57-crypto = "aarch64 cortexa57 crc crypto" +TUNE_FEATURES_tune-cortexa57-crypto = "${TUNE_FEATURES_tune-cortexa57} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa57 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57" PACKAGE_EXTRA_ARCHS_tune-cortexa57-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa57 cortexa57-crypto" BASE_LIB_tune-cortexa57 = "lib64"
meta/conf/machine/include/tune-cortexa72-cortexa53.inc +1 -1
@@ -12,7 +12,7 @@ AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto" ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53" ARMPKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53-crypto" TUNE_FEATURES_tune-cortexa72-cortexa53 = "aarch64 crc cortexa72-cortexa53" -TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "aarch64 crc crypto cortexa72-cortexa53" +TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "${TUNE_FEATURES_tune-cortexa72-cortexa53} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72-cortexa53 cortexa72-cortexa53-crypto" BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
meta/conf/machine/include/tune-cortexa73-cortexa53.inc +1 -1
@@ -12,7 +12,7 @@ AVAILTUNES += "cortexa73-cortexa53 cortexa73-cortexa53-crypto" ARMPKGARCH_tune-cortexa73-cortexa53 = "cortexa73-cortexa53" ARMPKGARCH_tune-cortexa73-cortexa53-crypto = "cortexa73-cortexa53-crypto" TUNE_FEATURES_tune-cortexa73-cortexa53 = "aarch64 crc cortexa73-cortexa53" -TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "aarch64 crc crypto cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "${TUNE_FEATURES_tune-cortexa73-cortexa53} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa73-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa73-cortexa53 cortexa73-cortexa53-crypto" BASE_LIB_tune-cortexa73-cortexa53 = "lib64"
Signature · 1 line
2.20.1