Skip to contentSkip to conversation

package/wlroots: disable xcb-errors

PATCH New Fabrice Fontaine 3 participants 3 messages Sep 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wlroots: disable xcb-errors

wlroots enable or disable xcb-errors depending on xcb-util availability since its addition with commit db5bccc04489672ded8a639f97b19a18e85ddd70

However xcb-errors is not provided by xcb-util, it is provided by xcb-util-errors (https://cgit.freedesktop.org/xcb/util-errors) which is not yet available in buildroot

As a result, the build will fail on:

Run-time dependency xcb-errors found: NO (tried pkgconfig)
Message: Install "xcb-errors" or pass "-Dxcb-errors=disabled". Required for printing X11 errors.

../output-1/build/wlroots-0.11.0/xwayland/meson.build:42:1: ERROR: Dependency "xcb-errors" not found, tried pkgconfig

Fixes:
- http://autobuild.buildroot.org/results/1891aa624b29e4bbcbbe6bc752a1cc90c316024e

---
 package/wlroots/wlroots.mk | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
package/wlroots/wlroots.mk +3 -8
index 27ccc8d5f3..fb26593073 100644
@@ -21,7 +21,9 @@ WLROOTS_DEPENDENCIES = \
 	wayland \
 	wayland-protocols
 
-WLROOTS_CONF_OPTS = -Dexamples=false
+WLROOTS_CONF_OPTS = \
+	-Dexamples=false \
+	-Dxcb-errors=disabled
 
 ifeq ($(BR2_PACKAGE_FFMPEG),y)
 WLROOTS_DEPENDENCIES += ffmpeg
@@ -52,13 +54,6 @@ else
 WLROOTS_CONF_OPTS += -Dxwayland=disabled
 endif
 
-ifeq ($(BR2_PACKAGE_XCB_UTIL),y)
-WLROOTS_CONF_OPTS += -Dxcb-errors=enabled
-WLROOTS_DEPENDENCIES += xcb-util
-else
-WLROOTS_CONF_OPTS += -Dxcb-errors=disabled
-endif
-
 ifeq ($(BR2_PACKAGE_XCB_UTIL_WM),y)
 WLROOTS_CONF_OPTS += -Dxcb-icccm=enabled
 WLROOTS_DEPENDENCIES += xcb-util-wm
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/wlroots: disable xcb-errors

Hi Fabrice,

I submitted basically the same patch a couple of minutes after you. Let's use yours instead, I'll withdraw mine from Patchwork.

Quoted 13 lines · On Wed, 09 Sep 2020 23:00:22 +0200 Fabrice Fontaine…

wlroots enable or disable xcb-errors depending on xcb-util availability since its addition with commit db5bccc04489672ded8a639f97b19a18e85ddd70

However xcb-errors is not provided by xcb-util, it is provided by xcb-util-errors (https://cgit.freedesktop.org/xcb/util-errors) which is not yet available in buildroot

As a result, the build will fail on:

Run-time dependency xcb-errors found: NO (tried pkgconfig)
Message: Install "xcb-errors" or pass "-Dxcb-errors=disabled". Required for printing X11 errors.

Quoted 6 lines

../output-1/build/wlroots-0.11.0/xwayland/meson.build:42:1: ERROR: Dependency "xcb-errors" not found, tried pkgconfig

Fixes:
- http://autobuild.buildroot.org/results/1891aa624b29e4bbcbbe6bc752a1cc90c316024e

Quoted 36 lines
---
 package/wlroots/wlroots.mk | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
package/wlroots/wlroots.mk +3 -8
index 27ccc8d5f3..fb26593073 100644
@@ -21,7 +21,9 @@ WLROOTS_DEPENDENCIES = \
 	wayland \
 	wayland-protocols
 
-WLROOTS_CONF_OPTS = -Dexamples=false
+WLROOTS_CONF_OPTS = \
+	-Dexamples=false \
+	-Dxcb-errors=disabled
 
 ifeq ($(BR2_PACKAGE_FFMPEG),y)
 WLROOTS_DEPENDENCIES += ffmpeg
@@ -52,13 +54,6 @@ else
 WLROOTS_CONF_OPTS += -Dxwayland=disabled
 endif
 
-ifeq ($(BR2_PACKAGE_XCB_UTIL),y)
-WLROOTS_CONF_OPTS += -Dxcb-errors=enabled
-WLROOTS_DEPENDENCIES += xcb-util
-else
-WLROOTS_CONF_OPTS += -Dxcb-errors=disabled
-endif
-
 ifeq ($(BR2_PACKAGE_XCB_UTIL_WM),y)
 WLROOTS_CONF_OPTS += -Dxcb-icccm=enabled
 WLROOTS_DEPENDENCIES += xcb-util-wm
Signature · 1 line
2.28.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200910/30309b86/attachment.asc>

#2 lore raw

PATCH 1/1 package/wlroots: disable xcb-errors

In reply to Fabrice Fontaine

Fabrice, All,

On 2020-09-09 23:00 +0200, Fabrice Fontaine spake thusly:

Quoted 13 lines

wlroots enable or disable xcb-errors depending on xcb-util availability since its addition with commit db5bccc04489672ded8a639f97b19a18e85ddd70

However xcb-errors is not provided by xcb-util, it is provided by xcb-util-errors (https://cgit.freedesktop.org/xcb/util-errors) which is not yet available in buildroot

As a result, the build will fail on:

Run-time dependency xcb-errors found: NO (tried pkgconfig)
Message: Install "xcb-errors" or pass "-Dxcb-errors=disabled". Required for printing X11 errors.

Quoted 6 lines

../output-1/build/wlroots-0.11.0/xwayland/meson.build:42:1: ERROR: Dependency "xcb-errors" not found, tried pkgconfig

Fixes:
- http://autobuild.buildroot.org/results/1891aa624b29e4bbcbbe6bc752a1cc90c316024e

Sorry, I missed your patch, and I instead applied Adrian's.

Regards,
Yann E. MORIN.

Quoted 40 lines
---
 package/wlroots/wlroots.mk | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
package/wlroots/wlroots.mk +3 -8
index 27ccc8d5f3..fb26593073 100644
@@ -21,7 +21,9 @@ WLROOTS_DEPENDENCIES = \
 	wayland \
 	wayland-protocols
 
-WLROOTS_CONF_OPTS = -Dexamples=false
+WLROOTS_CONF_OPTS = \
+	-Dexamples=false \
+	-Dxcb-errors=disabled
 
 ifeq ($(BR2_PACKAGE_FFMPEG),y)
 WLROOTS_DEPENDENCIES += ffmpeg
@@ -52,13 +54,6 @@ else
 WLROOTS_CONF_OPTS += -Dxwayland=disabled
 endif
 
-ifeq ($(BR2_PACKAGE_XCB_UTIL),y)
-WLROOTS_CONF_OPTS += -Dxcb-errors=enabled
-WLROOTS_DEPENDENCIES += xcb-util
-else
-WLROOTS_CONF_OPTS += -Dxcb-errors=disabled
-endif
-
 ifeq ($(BR2_PACKAGE_XCB_UTIL_WM),y)
 WLROOTS_CONF_OPTS += -Dxcb-icccm=enabled
 WLROOTS_DEPENDENCIES += xcb-util-wm
Signature · 6 lines
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'