idr: Document calling context for IDA APIs mustn't use locks
Subsystems (3)
PATCH v3 1/2 idr: Document calling context for IDA APIs mustn't use locks
The documentation for these functions indicates that callers don't need to hold a lock while calling them, but that documentation is only in one place under "IDA Usage". Let's state the same information on each IDA function so that it's clear what the calling context requires. Furthermore, let's document ida_simple_get() with the same information so that callers know how this API works.
--- include/linux/idr.h | 9 ++++++--- lib/idr.c | 9 ++++++--- 2 files changed, 12 insertions(+), 6 deletions(-)
include/linux/idr.h +6 -3
@@ -263,7 +263,8 @@ void ida_destroy(struct ida *ida);* * Allocate an ID between 0 and %INT_MAX, inclusive. * -* Context: Any context. +* Context: Any context. It is safe to call this function without +* locking in your code. * Return: The allocated ID, or %-ENOMEM if memory could not be allocated, * or %-ENOSPC if there are no free IDs. */
@@ -280,7 +281,8 @@ static inline int ida_alloc(struct ida *ida, gfp_t gfp)* * Allocate an ID between @min and %INT_MAX, inclusive. * -* Context: Any context. +* Context: Any context. It is safe to call this function without +* locking in your code. * Return: The allocated ID, or %-ENOMEM if memory could not be allocated, * or %-ENOSPC if there are no free IDs. */
@@ -297,7 +299,8 @@ static inline int ida_alloc_min(struct ida *ida, unsigned int min, gfp_t gfp)* * Allocate an ID between 0 and @max, inclusive. * -* Context: Any context. +* Context: Any context. It is safe to call this function without +* locking in your code. * Return: The allocated ID, or %-ENOMEM if memory could not be allocated, * or %-ENOSPC if there are no free IDs. */
lib/idr.c +6 -3
@@ -372,7 +372,8 @@ EXPORT_SYMBOL(idr_replace);* Allocate an ID between @min and @max, inclusive. The allocated ID will * not exceed %INT_MAX, even if @max is larger. * -* Context: Any context. +* Context: Any context. It is safe to call this function without +* locking in your code. * Return: The allocated ID, or %-ENOMEM if memory could not be allocated, * or %-ENOSPC if there are no free IDs. */
@@ -479,7 +480,8 @@ EXPORT_SYMBOL(ida_alloc_range);* @ida: IDA handle. * @id: Previously allocated ID. * -* Context: Any context. +* Context: Any context. It is safe to call this function without +* locking in your code. */ void ida_free (struct ida *ida,unsigned int id) {
@@ -531,7 +533,8 @@ EXPORT_SYMBOL(ida_free);* or freed. If the IDA is already empty, there is no need to call this * function. * -* Context: Any context. +* Context: Any context. It is safe to call this function without +* locking in your code. */ void ida_destroy (struct ida *ida) {
base-commit: d012a7190fc1fd72ed48911e77ca97ba4521bccd
Signature · 1 line
Sent by a computer, using git, on the internet
PATCH v3 2/2 idr: Document that ida_simple_{get,remove}() are deprecated
These two functions are deprecated. Users should call ida_alloc() or ida_free() respectively instead. Add documentation to this effect until the macro can be removed.
--- include/linux/idr.h | 4 ++++ 1 file changed, 4 insertions(+)
include/linux/idr.h +4 -0
@@ -314,6 +314,10 @@ static inline void ida_init(struct ida *ida)xa_init_flags (&ida->xa,IDA_INIT_FLAGS ); } +/* +* ida_simple_get() and ida_simple_remove() are deprecated. Use +* ida_alloc() and ida_free() instead respectively. +*/ #define ida_simple_get (ida, start, end, gfp) \ ida_alloc_range(ida, start, (end) - 1, gfp)#define ida_simple_remove (ida, id) ida_free(ida, id)
Signature · 1 line
Sent by a computer, using git, on the internet
Quoted 6 lines · Stephen Boyd
The documentation for these functions indicates that callers don't need to hold a lock while calling them, but that documentation is only in one place under "IDA Usage". Let's state the same information on each IDA function so that it's clear what the calling context requires. Furthermore, let's document
ida_simple_get()with the same information so that callers know how this API works.
Thank you for this, I always have to go look it up too...