Skip to contentSkip to conversation

package/iwd: fix build with uclibc

PATCH New Fabrice Fontaine 3 participants 3 messages Sep 10, 2020 – Sep 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/iwd: fix build with uclibc

This patch is needed to fix a build failure with iwd 1.9.0 and uclibc

Fixes:
- http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d

---
 .../0001-src-ap.c-fix-build-with-uclibc.patch | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch new file +37 -0
new file mode 100644
index 0000000000..b4e18098c0
@@ -0,0 +1,37 @@
+From 377df79e83e2127a087e1aa5ba6173e195e50933 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Thu, 10 Sep 2020 07:47:14 +0200
+Subject: [PATCH] src/ap.c: fix build with uclibc
+
+explicit_bzero is used in src/ap.c since commit
+d55e00b31d7bccdbb2ea1cdeb0a749df77a51e47 but src/missing.h is not
+included, as a result build with uclibc fails on:
+
+/srv/storage/autobuild/run/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: src/ap.o: in function `ap_probe_req_cb':
+ap.c:(.text+0x23d8): undefined reference to `explicit_bzero'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status:
+https://lists.01.org/hyperkitty/list/iwd at lists.01.org/thread/SSEFPYCJWH2CQGY7IV6BPNOPMQWYYZPD/]
+---
+ src/ap.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/ap.c b/src/ap.c
+index c972cfcb..ac705c31 100644
+--- a/src/ap.c
++++ b/src/ap.c
+@@ -31,6 +31,7 @@
+ 
+ #include "linux/nl80211.h"
+ 
++#include "src/missing.h"
+ #include "src/iwd.h"
+ #include "src/module.h"
+ #include "src/scan.h"
+-- 
+2.28.0
+
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/iwd: fix build with uclibc

Hello Fabrice,

Quoted 25 lines · Fabrice Fontaine

This patch is needed to fix a build failure with iwd 1.9.0 and uclibc

Fixes:
- http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d

---
 .../0001-src-ap.c-fix-build-with-uclibc.patch | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch new file +8 -0
new file mode 100644
index 0000000000..b4e18098c0
@@ -0,0 +1,37 @@
+From 377df79e83e2127a087e1aa5ba6173e195e50933 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Thu, 10 Sep 2020 07:47:14 +0200
+Subject: [PATCH] src/ap.c: fix build with uclibc
+
+explicit_bzero is used in src/ap.c since commit
+d55e00b31d7bccdbb2ea1cdeb0a749df77a51e47 but src/missing.h is not
+included, as a result build with uclibc fails on:

package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch line 18

Quoted 10 lines
package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch new file +10 -0
+
+/srv/storage/autobuild/run/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: src/ap.o: in function `ap_probe_req_cb':
+ap.c:(.text+0x23d8): undefined reference to `explicit_bzero'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status:
+https://lists.01.org/hyperkitty/list/iwd at lists.01.org/thread/SSEFPYCJWH2CQGY7IV6BPNOPMQWYYZPD/]

And upstream accepted, see [1]...

Regards,
Peter

[1] https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=0a6de7932a61ec82aca4f78f71dab7247c897860

Quoted 19 lines
package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch new file +19 -0
+---
+ src/ap.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/ap.c b/src/ap.c
+index c972cfcb..ac705c31 100644
+--- a/src/ap.c
++++ b/src/ap.c
+@@ -31,6 +31,7 @@
+
+ #include "linux/nl80211.h"
+
++#include "src/missing.h"
+ #include "src/iwd.h"
+ #include "src/module.h"
+ #include "src/scan.h"
+--
+2.28.0
+
#2 lore raw

PATCH 1/1 package/iwd: fix build with uclibc

In reply to Fabrice Fontaine
Quoted 10 lines · On Thu, 10 Sep 2020 08:20:26 +0200 Fabrice Fontaine…

This patch is needed to fix a build failure with iwd 1.9.0 and uclibc

Fixes:
- http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d

---
 .../0001-src-ap.c-fix-build-with-uclibc.patch | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch

Applied to master, thanks. I have updated the upstream status, as the patch was accepted upstream as pointed out by Peter Seiderer.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com